Tianocore/edk2.git/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView, branch master

ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (4/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Lower the indentation level in the newly created MainCmdXXX() functions. To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - SerMode.c - SetSize.c - SetVar.c - SmbiosView/SmbiosView.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (4/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package For the MemMap and SetVar commands, ShellCommandLineFreeVarList() calls are removed as the Package is now freed in the caller function: ShellCommandRunXXX(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - SerMode.c - SetSize.c - SetVar.c - SmbiosView/SmbiosView.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/ShellDebug1: Rationalize Package init/free

2026-08-04T07:35:35+00:00

Package is sometimes initialized to NULL and only freed if not NULL. Remove these as: - Package is initialized in ShellCommandLineParse(). - If ShellCommandLineFreeVarList() is reached, Package cannot be NULL. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (4/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - SerMode.c - SetSize.c - SetVar.c - SmbiosView/SmbiosView.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg: Add missing smbiosview Type 28 locations

2026-07-02T07:22:54+00:00

Add the missing SMBIOS Type 28 Temperature Probe location decode values to smbiosview. The Type 28 Location field defines values 0x0C through 0x0F for Front Panel Board, Back Panel Board, Power System Board, and Drive Back Plane, but smbiosview only decoded values up to 0x0B. Signed-off-by: VarshitPandya

ShellPkg: Fix smbiosview Type 26 location/status decode

2026-07-02T07:22:54+00:00

The smbiosview Type 26 Voltage Probe decoder uses the low 5 bits of LocationAndStatus as the probe location and the high 3 bits as the probe status. However, the Type 26 lookup tables were swapped: VPLocationTable contained status strings and VPStatusTable contained location strings. This caused valid records to be displayed as, for example: Voltage Probe - Location: OK Voltage Probe - Status: Processor Swap the table contents so Type 26 output matches the SMBIOS LocationAndStatus bit layout. Signed-off-by: VarshitPandya

ShellPkg: ShellPkg: Fix SMBIOS Type 28 probe labels

2026-06-29T17:19:33+00:00

Use a Temperature Probe specific HII string when displaying the Type 28 Location field in smbiosview. The Type 28 decoder was using the Voltage Probe location label, causing temperature probe records to be displayed with the wrong field name. Signed-off-by: Varshit Pandya

ShellPkg: Fix SMBIOS Type 26 probe decoding

2026-06-29T17:19:33+00:00

Decode the Type 26 Voltage Probe Location and Status fields according to the SMBIOS 3.9.0 specification, section 7.27, "Voltage Probe (Type 26)". Table 95, "Voltage Probe: Location and Status fields", defines bits 4:0 as the Location field and bits 7:5 as the Status field. smbiosview was decoding these fields in the opposite order, causing the displayed voltage probe location and status to be swapped. Signed-off-by: Varshit Pandya

ShellPkg/SmbiosView: Fix clang compatibility issue

2026-03-07T02:50:50+00:00

Signed-off-by: Michael D Kinney

ShellPkg/SmbiosView: Support print Protocol Records of SMBIOS type42

2026-03-06T08:35:45+00:00

SmbiosView tool changes for Protocol Records info decode and print. This commit adds the following decoding functionality: First, it prints the `MCHostInterfaceProtocol Number`, then print the `ProtocolType` with the prefix #x(0 based index), and finally dump `ProtocolTypeData` as hex. Signed-off-by: Yang Gang