Tianocore/edk2.git/ShellPkg/Library/UefiShellDebug1CommandsLib/SerMode.c, branch master

ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (4/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Lower the indentation level in the newly created MainCmdXXX() functions. To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - SerMode.c - SetSize.c - SetVar.c - SmbiosView/SmbiosView.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (4/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package For the MemMap and SetVar commands, ShellCommandLineFreeVarList() calls are removed as the Package is now freed in the caller function: ShellCommandRunXXX(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - SerMode.c - SetSize.c - SetVar.c - SmbiosView/SmbiosView.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/ShellDebug1: Rationalize Package init/free

2026-08-04T07:35:35+00:00

Package is sometimes initialized to NULL and only freed if not NULL. Remove these as: - Package is initialized in ShellCommandLineParse(). - If ShellCommandLineFreeVarList() is reached, Package cannot be NULL. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (4/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - SerMode.c - SetSize.c - SetVar.c - SmbiosView/SmbiosView.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/SerMode: Add ValidDataBits() function

2026-04-24T18:18:47+00:00

Add a ValidDataBits() utility function to check the Data Bits are valid. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/SerMode: Add GetStopBits() function

2026-04-24T18:18:47+00:00

Add a GetStopBits() utility function to convert the StopBits to the EFI_STOP_BITS_TYPE type. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/SerMode: Lower indentation level in DisplaySettings()

2026-04-24T18:18:47+00:00

Invert error handling to lower the indentation level in DisplaySettings(). No functional change. Signed-off-by: Pierre Gondois

ShellPkg/SerMode: Add GetParityType() function

2026-04-24T18:18:47+00:00

Add a GetParityType() utility function to convert the Parity to the EFI_PARITY_TYPE type. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/SerMode: Add name conversion arrays for parity/stop bits

2026-04-24T18:18:47+00:00

Add name conversion arrays: - ParityBitName - StopBitsName to seamlessly convert parity/stop bits to a matching name. No functional change. Signed-off-by: Pierre Gondois

ShellPkg: Use the newly introduced ShellPrintHiiDefaultEx() alias

2025-10-01T08:02:57+00:00

Make use the newly introduced ShellPrintHiiDefaultEx() alias and replace wherever it is possible: - "ShellPrintHiiEx (-1, -1, NULL," with: - "ShellPrintHiiDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois