Tianocore/edk2.git/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c, branch master

ShellPkg/Pci: Extract ParsePciBdf()

2026-08-04T07:35:35+00:00

Extract BDF argument parsing into a helper. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/Pci: Extract PciEnumerateAll()

2026-08-04T07:35:35+00:00

Extract the default PCI enumeration path into a helper. No functional change. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (3/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Lower the indentation level in the newly created MainCmdXXX() functions. To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - MemMap.c - Mm.c - Mode.c - Pci.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (3/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package For the MemMap and SetVar commands, ShellCommandLineFreeVarList() calls are removed as the Package is now freed in the caller function: ShellCommandRunXXX(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - MemMap.c - Mm.c - Mode.c - Pci.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/ShellDebug1: Rationalize Package init/free

2026-08-04T07:35:35+00:00

Package is sometimes initialized to NULL and only freed if not NULL. Remove these as: - Package is initialized in ShellCommandLineParse(). - If ShellCommandLineFreeVarList() is reached, Package cannot be NULL. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (3/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - MemMap.c - Mm.c - Mode.c - Pci.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/Pci: Restore BAR informations

2026-07-17T22:58:58+00:00

Restore informations lost in the pci shell command. sbsa-ref Host Bridge: ``` Cache Line Size(C): 00 Latency Timer(D): 00 Header Type(0E): 00, Single function, PCI device Class: Bridge Device - Host/PCI bridge - +Base Address Registers(10): + (None) +Expansion ROM Disabled(30) + +Cardbus CIS ptr(28): 00000000 +Sub VendorID(2C): 1AF4 Subsystem ID(2E): 1100 +Capabilities Ptr(34): 00 +Interrupt Line(3C): FF Interrupt Pin(3D): 00 +Min_Gnt(3E): 00 Max_Lat(3F): 00 ``` sbsa-ref Ethernet Controller: ``` Cache Line Size(C): 00 Latency Timer(D): 00 Header Type(0E): 00, Single function, PCI device Class: Network Controller - Ethernet controller - +Base Address Registers(10): + Start_Address Type Space Prefetchable? Size Limit + -------------------------------------------------------------------------- + 81060000 Mem 32 bits No 00020000 8107FFFF + 81040000 Mem 32 bits No 00020000 8105FFFF + 0000 I/O 0020 001F + 81080000 Mem 32 bits No 00004000 81083FFF + -------------------------------------------------------------------------- +Expansion ROM Disabled(30) + +Cardbus CIS ptr(28): 00000000 +Sub VendorID(2C): 8086 Subsystem ID(2E): 0000 +Capabilities Ptr(34): C8 +Interrupt Line(3C): FF Interrupt Pin(3D): 01 +Min_Gnt(3E): 00 Max_Lat(3F): 00 Pci Express device capability structure: CapID( 0): 10 NextCap Ptr( 1): A0 ``` Signed-off-by: Vincent Gatine

Global: Fix Spelling Errors in PCI/PCIe Definitions

2026-05-08T02:15:34+00:00

Fix spelling errors in definitions in Pci22.h. Update consumers in MdeModulePkg, OvmfPkg, ShellPkg, and SourceLevelDebugPkg. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Oliver Smith-Denny

ShellPkg/pci.c: Fix typo in source code.

2025-10-03T17:14:30+00:00

Signed-off-by: Chasel Chiu

ShellPkg: Add PCIe boundary check and enhance DVSEC size calculation

2025-10-03T17:14:30+00:00

1. Safe wrapper function for DumpHex that validates PCI configuration space boundaries. This function ensures that hex dumps do not exceed the standard 4KB PCIe configuration space boundary. If the requested dump would exceed this boundary, it prints an error message and truncates the dump size to remain within valid bounds. 2. Enhance DVSEC capability structure size calculation method. Size is now obtained from the DesignatedVendorSpecificHeader1.Bits.DvsecLength register. Issue: https://github.com/tianocore/edk2/issues/11554 Signed-off-by: Pranav V V