Tianocore/edk2.git/ShellPkg/Library/UefiShellDebug1CommandsLib/MemMap.c, branch master

ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (3/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Lower the indentation level in the newly created MainCmdXXX() functions. To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - MemMap.c - Mm.c - Mode.c - Pci.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (3/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package For the MemMap and SetVar commands, ShellCommandLineFreeVarList() calls are removed as the Package is now freed in the caller function: ShellCommandRunXXX(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - MemMap.c - Mm.c - Mode.c - Pci.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (3/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - MemMap.c - Mm.c - Mode.c - Pci.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg: Use the newly introduced ShellPrintHiiDefaultEx() alias

2025-10-01T08:02:57+00:00

Make use the newly introduced ShellPrintHiiDefaultEx() alias and replace wherever it is possible: - "ShellPrintHiiEx (-1, -1, NULL," with: - "ShellPrintHiiDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg/MemMap: Extract a ParseMemoryDescriptors() function

2025-10-01T08:02:57+00:00

In an effort to simplify the code in the ShellPkg, extract a ParseMemoryDescriptors() function. No functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg/MemMap: Create arrays of MemoryType configuration and Page

2025-10-01T08:02:57+00:00

In an effort to simplify the code in the ShellPkg: - create a MEMORY_TYPE_INFO struct, storing per-MemoryType configuration information to facilitate the operations to do for each MemoryType. - create a MEMORY_TYPE_PAGES_INFO struct, storing per-MemoryType Pages and PagesSize count. Also use these arrays to facilitate Pages accounting and remove per-MemoryType variables. No functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg/MemMap: Create array of MemoryType names

2025-10-01T08:02:57+00:00

In an effort to simplify the code in the ShellPkg, replace the MemoryType names that are currently stored in individual variables by an array of names, facilitating access to these names. No functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg: CodeQL Fixes

2024-10-29T02:09:18+00:00

Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe Signed-off-by: Oliver Smith-Denny

ShellPkg: UefiShellDebug1CommandsLib: CodeQL Fixes

2024-10-29T02:09:18+00:00

ShellPkg: Update shell command memmap to show unaccepted memory

2022-11-01T10:08:10+00:00

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 ShellCommandRunMemMap() is updated to handle the case of unaccepted memory type. Cc: Ray Ni Cc: Zhichao Gao Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Acked-by: Gerd Hoffmann Acked-by: Zhichao Gao Signed-off-by: Min Xu