EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=master 2026-08-04T07:35:35+00:00 2026-08-04T07:35:35+00:00 Pierre Gondois pierre.gondois@arm.com 2026-05-27T14:55:26+00:00 urn:sha1:fa41c179db1f9fc21eb425f44b85a16262c806ca Fix codeql reported issues by flattening MainCmdEfiDecompress(), making it easier for the tool to evaluate potential risks. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2026-08-04T07:35:35+00:00 Pierre Gondois pierre.gondois@arm.com 2026-05-26T10:31:10+00:00 urn:sha1:35a2f2754615bb3e029d3c86da09f8a32e5b14a1 Check the return value of LocateProtocol() before using the decompression protocol. This avoids a potential NULL pointer derefence spotted by codeql. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2026-08-04T07:35:35+00:00 Pierre Gondois pierre.gondois@arm.com 2026-06-04T09:21:00+00:00 urn:sha1:d395696428e7198a7369f52a61e579d7a2bf8cd6 This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Lower the indentation level in the newly created MainCmdXXX() functions. To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - Edit/Edit.c - EfiCompress.c - EfiDecompress.c - LoadPciRom.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2026-08-04T07:35:35+00:00 Pierre Gondois pierre.gondois@arm.com 2026-06-04T09:19:05+00:00 urn:sha1:5bdbf4462bd50762b308a62498f587650ebaf656 This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package For the MemMap and SetVar commands, ShellCommandLineFreeVarList() calls are removed as the Package is now freed in the caller function: ShellCommandRunXXX(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - Edit/Edit.c - EfiCompress.c - EfiDecompress.c - HexEdit/HexEdit.c - LoadPciRom.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2026-08-04T07:35:35+00:00 Pierre Gondois pierre.gondois@arm.com 2026-06-04T09:16:21+00:00 urn:sha1:d23559e847f41d9c8fa69cb801a31a9ffda9baa1 This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - Edit/Edit.c - EfiCompress.c - EfiDecompress.c - HexEdit/HexEdit.c - LoadPciRom.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-10-01T08:02:57+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-18T12:12:11+00:00 urn:sha1:c4a8b001f34c19cd411566cb4cd672eb1fac5478 Make use the newly introduced ShellPrintHiiDefaultEx() alias and replace wherever it is possible: - "ShellPrintHiiEx (-1, -1, NULL," with: - "ShellPrintHiiDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2024-10-29T02:09:18+00:00 Oliver Smith-Denny osde@microsoft.com 2024-10-03T17:31:31+00:00 urn:sha1:334f5748869996eee994f9dee41f3e6a3d9bd087 Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com> 2024-10-29T02:09:18+00:00 Oliver Smith-Denny osde@microsoft.com 2024-10-03T17:23:33+00:00 urn:sha1:040afc1e3be6e3d334c2483803b0470a34bced55 Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com> 2023-04-03T15:29:08+00:00 Michael Kubacki michael.kubacki@microsoft.com 2022-11-08T20:35:39+00:00 urn:sha1:11dd44dfbefab2ca0b9160bb5ebe40bc1c70f7c1 Fixes CodeQL alerts for CWE-457: https://cwe.mitre.org/data/definitions/457.html Cc: Erich McMillan <emcmillan@microsoft.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Co-authored-by: Erich McMillan <emcmillan@microsoft.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Oliver Smith-Denny <osd@smith-denny.com> 2021-12-07T17:24:28+00:00 Michael Kubacki michael.kubacki@microsoft.com 2021-12-05T22:54:13+00:00 urn:sha1:47d20b54f9a65b08aa602a1866c1b59a69088dfc REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the ShellPkg package Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Ray Ni <ray.ni@intel.com>