Tianocore/edk2.git/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c, branch master

ShellPkg/Dmem: Refactor MainCmdDmem()

2026-08-04T07:35:35+00:00

Refactor MainCmdDmem() to make it easier to understand. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (1/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Lower the indentation level in the newly created MainCmdXXX() functions. To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - Comp.c - Cxl.c - Dblk.c - Dmem.c - DmpStore.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (1/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Extract a MainCmdXXX() function for each shell command. This command contains the possible operations the command aims to operate. The ShellCommandRunXXX() function from which it is extracted is only responsible of: - initializing the shell/command environment - parsing the command parameter and creating a Package - freeing the Package For the MemMap and SetVar commands, ShellCommandLineFreeVarList() calls are removed as the Package is now freed in the caller function: ShellCommandRunXXX(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - Comp.c - Cxl.c - Dblk.c - Dmem.c - DmpStore.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (1/4)

2026-08-04T07:35:35+00:00

This patch aims to help breaking down the long functions present in the ShellPkg and reduce complexity/nested code and conditions. Return directly if ShellCommandLineParse() returned an error Status. In such case, the "Package" that should be allocated by ShellCommandLineParse() is already freed in: ShellCommandLineParse() \-ShellCommandLineParseEx() \-InternalCommandLineParse() so there is no need to free it with ShellCommandLineFreeVarList(). To avoid having one large commit updating all the UefiShellDebug1 commands, only update these files: - Comp.c - Cxl.c - Dblk.c - Dmem.c - DmpStore.c No functional change should be induced by this patch. Signed-off-by: Pierre Gondois

ShellPkg: Use the newly introduced ShellPrintHiiDefaultEx() alias

2025-10-01T08:02:57+00:00

Make use the newly introduced ShellPrintHiiDefaultEx() alias and replace wherever it is possible: - "ShellPrintHiiEx (-1, -1, NULL," with: - "ShellPrintHiiDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg/Dmem: Remove return parameter from DisplayXXX() functions

2025-10-01T08:02:57+00:00

In an effort to simplify the code in the ShellPkg, remove the SHELL_STATUS parameter returned by: - DisplayRtProperties() - DisplayImageExecutionEntries() - DisplayConformanceProfiles() These functions are independent display functions. Thus failing to display a configuration table should not prevent from displaying the remaining tables. Signed-off-by: Pierre Gondois

ShellPkg/Dmem: Remove unnecessary EfiGetSystemConfigurationTable() calls

2025-10-01T08:02:57+00:00

In an effort to simplify the code in the ShellPkg, remove EfiGetSystemConfigurationTable() calls fetching Configuration Table addresses that have already been collected. No functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg/Dmem: Simplify logic by inverting Address checks

2025-10-01T08:02:57+00:00

In an effort to simplify the code in the ShellPkg, inverse checks against the 'Address'. This also lowers the indentation level. No functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg/Dmem: Replace per-System Table variable by indexed arrays

2025-10-01T08:02:57+00:00

In an effort to simplify the code in the ShellPkg, remove the per-System Table variables by indexed arrays. The only functional change introduced is that a non-null Smbios3 System Table: - always replaces an Smbios System Table - ASSERT if (Smbios3 != 0) and (Smbios != 0) Otherwise no functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg/Dmem: Remove Memory Range Capsule support

2025-10-01T08:02:57+00:00

Memory Range Capsule is described in the UEFI spec 2.9 s8.5.3 Update Capsule with the following GUID: {0DE9F0EC-88B6-428F-977A-258F1D0E5E72} Support to print the EFI_MEMORY_RANGE_CAPSULE address in the EFI Configuration table was added in commit: 42b0443599a6 ("ShellPkg: UefiShellDebug1CommandsLib: Uefi Config Tables in Dmem.c") but EFI_MEMORY_RANGE_CAPSULE type and GUID is not present in edk2. Thus dmem always print a 0 value for this configuration table. Remove support of EFI_MEMORY_RANGE_CAPSULE in dmem. Signed-off-by: Pierre Gondois