Tianocore/edk2.git/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c, branch edk2_masterEDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=edk2_master2025-10-01T08:02:57+00:00ShellPkg: Use the newly introduced ShellPrintHiiDefaultEx() alias2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T12:12:11+00:00urn:sha1:c4a8b001f34c19cd411566cb4cd672eb1fac5478
Make use the newly introduced ShellPrintHiiDefaultEx() alias and
replace wherever it is possible:
- "ShellPrintHiiEx (-1, -1, NULL,"
with:
- "ShellPrintHiiDefaultEx ("
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Dmem: Remove return parameter from DisplayXXX() functions2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-19T13:22:12+00:00urn:sha1:0f57fc7cf751a960252c06c63190ac3e0ed0b90d
In an effort to simplify the code in the ShellPkg,
remove the SHELL_STATUS parameter returned by:
- DisplayRtProperties()
- DisplayImageExecutionEntries()
- DisplayConformanceProfiles()
These functions are independent display functions. Thus failing to
display a configuration table should not prevent from displaying
the remaining tables.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Dmem: Remove unnecessary EfiGetSystemConfigurationTable() calls2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-19T13:17:06+00:00urn:sha1:2bebeb1ad408cc30f4ce717f4ce15eb3b5754053
In an effort to simplify the code in the ShellPkg,
remove EfiGetSystemConfigurationTable() calls fetching Configuration
Table addresses that have already been collected.
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Dmem: Simplify logic by inverting Address checks2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-19T13:09:35+00:00urn:sha1:482781a7f95d293c48479f6d6fbb56108fe342c5
In an effort to simplify the code in the ShellPkg,
inverse checks against the 'Address'. This also lowers the
indentation level.
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Dmem: Replace per-System Table variable by indexed arrays2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T08:28:19+00:00urn:sha1:e78453fb5485e8fda9469daa150a0c86ce924ee7
In an effort to simplify the code in the ShellPkg,
remove the per-System Table variables by indexed arrays.
The only functional change introduced is that a non-null Smbios3
System Table:
- always replaces an Smbios System Table
- ASSERT if (Smbios3 != 0) and (Smbios != 0)
Otherwise no functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Dmem: Remove Memory Range Capsule support2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T08:09:15+00:00urn:sha1:0235ac23c516fc29d5fff2e1c2f2c6fb2429c0e0
Memory Range Capsule is described in the UEFI spec 2.9
s8.5.3 Update Capsule with the following GUID:
{0DE9F0EC-88B6-428F-977A-258F1D0E5E72}
Support to print the EFI_MEMORY_RANGE_CAPSULE address in the EFI
Configuration table was added in commit: 42b0443599a6
("ShellPkg: UefiShellDebug1CommandsLib: Uefi Config Tables in Dmem.c")
but EFI_MEMORY_RANGE_CAPSULE type and GUID is not present in edk2.
Thus dmem always print a 0 value for this configuration table.
Remove support of EFI_MEMORY_RANGE_CAPSULE in dmem.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Dmem: Remove remaining of SAL System Table2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T07:22:12+00:00urn:sha1:cf67a0c78e1497ba64184af67f6760de2f1a7747
The SAL System Table is unsupported and its support was
removed in commit:
f4c874c45dbc ("ShellPkg/UefiShellDebug1CommandsLib")
Remove remaining of SAL System Table handling.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/Dmem: Extract a DisplaySystemTable() function2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-17T10:45:57+00:00urn:sha1:ace36ed376144db2f3d63c849ca88843668ea1b0
In an effort to simplify the code in the ShellPkg,
extract a DisplaySystemTable().
This also lowers the indentation level.
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: DtbTableAddress via config in dmem2025-07-24T05:59:45+00:00Prachotan Reddy BathiPrachotan.Bathi@arm.com2025-02-12T18:36:45+00:00urn:sha1:01295fd25b0465f6a82682e7adbfdbec70c4beb1
DTB address can be modified through the config table. Use
this address in dmem output.
EmbeddedPkg dependency added to
ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
and ShellPkg/ShellPkg.ci.yaml
Adds to: 42b0443599a6
("ShellPkg: UefiShellDebug1CommandsLib: Uefi Config Tables in Dmem.c")
Signed-off-by: Prachotan Reddy Bathi <Prachotan.Bathi@arm.com>
ShellPkg: fix warnings about uninitialized variable2025-01-29T16:20:57+00:00Mike Maslenkinmike.maslenkin@gmail.com2025-01-09T18:50:12+00:00urn:sha1:254937f0bca17649b5d213381a38ffe9ff66acec
Dmem.c: In function 'GetImageExecutionInfo':
Dmem.c:241:10: error: 'Status' may be used uninitialized
in this function [-Werror=maybe-uninitialized]
return Status;
^~~~~~
Dmem.c:284:35: note: 'Status' was declared here
EFI_STATUS Status;
^~~~~~
Dmem.c: In function 'ShellCommandRunDmem':
Dmem.c:586:27: error: 'ConformanceProfileTableAddress' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
ShellStatus = DisplayConformanceProfiles (ConformanceProfileTableAddress);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dmem.c:582:27: error: 'ImageExecutionTableAddress' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
ShellStatus = DisplayImageExecutionEntries (ImageExecutionTableAddress);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dmem.c:578:27: error: 'RtPropertiesTableAddress' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
ShellStatus = DisplayRtProperties (RtPropertiesTableAddress);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>