Tianocore/edk2.git/ShellPkg/Library/UefiShellDebug1CommandsLib/Cxl.c, branch masterEDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=master2026-08-04T07:35:35+00:00ShellPkg/UefiShellDebug1: Lower indentation level in MainCmdXXX() (1/4)2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-06-04T09:20:45+00:00urn:sha1:cad93da7e5efead7c9a7ddb774b968894a538cbd
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Lower the indentation level in the newly created MainCmdXXX()
functions.
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Comp.c
- Cxl.c
- Dblk.c
- Dmem.c
- DmpStore.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellDebug1: Extract MainCmdXXX() function (1/4)2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-06-04T09:18:46+00:00urn:sha1:6d0ef532c633f9924f3f416e744653a0639e7c4e
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Extract a MainCmdXXX() function for each shell command.
This command contains the possible operations the command aims
to operate. The ShellCommandRunXXX() function from which it
is extracted is only responsible of:
- initializing the shell/command environment
- parsing the command parameter and creating a Package
- freeing the Package
For the MemMap and SetVar commands, ShellCommandLineFreeVarList()
calls are removed as the Package is now freed in the caller
function: ShellCommandRunXXX().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Comp.c
- Cxl.c
- Dblk.c
- Dmem.c
- DmpStore.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/ShellDebug1: Rationalize Package init/free2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-05-04T12:32:05+00:00urn:sha1:adad73339ddfe5b91d0cc00fea8ac1bdd7a15d81
Package is sometimes initialized to NULL and only
freed if not NULL. Remove these as:
- Package is initialized in ShellCommandLineParse().
- If ShellCommandLineFreeVarList() is reached,
Package cannot be NULL.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg/UefiShellDebug1: Return if ShellCommandLineParse() failed (1/4)2026-08-04T07:35:35+00:00Pierre Gondoispierre.gondois@arm.com2026-06-04T09:15:37+00:00urn:sha1:7ee84dc437ec4df895ebe69a08352e3c13e99f17
This patch aims to help breaking down the long functions present in
the ShellPkg and reduce complexity/nested code and conditions.
Return directly if ShellCommandLineParse() returned an error Status.
In such case, the "Package" that should be allocated by
ShellCommandLineParse() is already freed in:
ShellCommandLineParse()
\-ShellCommandLineParseEx()
\-InternalCommandLineParse()
so there is no need to free it with ShellCommandLineFreeVarList().
To avoid having one large commit updating all the UefiShellDebug1
commands, only update these files:
- Comp.c
- Cxl.c
- Dblk.c
- Dmem.c
- DmpStore.c
No functional change should be induced by this patch.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
ShellPkg: Add 'cxl' command2026-05-01T06:48:04+00:00Oleksandr Tymoshenkoovt@google.com2026-03-13T21:40:25+00:00urn:sha1:68662fd712b9ade4f18b2a1fed5f823563b8c4d4
Add a 'cxl' command to list and query CXL devices.
Signed-off-by: Oleksandr Tymoshenko <ovt@google.com>