EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=edk2_master 2025-10-01T08:02:57+00:00 2025-10-01T08:02:57+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-18T12:13:00+00:00 urn:sha1:aa29d51637d75aaf398fc8bda60af9726690615c Make use the newly introduced ShellPrintDefaultEx() alias and replace wherever it is possible: - "ShellPrintEx (-1, -1," with: - "ShellPrintDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-10-01T08:02:57+00:00 Pierre Gondois pierre.gondois@arm.com 2025-09-18T12:12:11+00:00 urn:sha1:c4a8b001f34c19cd411566cb4cd672eb1fac5478 Make use the newly introduced ShellPrintHiiDefaultEx() alias and replace wherever it is possible: - "ShellPrintHiiEx (-1, -1, NULL," with: - "ShellPrintHiiDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2024-10-29T02:09:18+00:00 Oliver Smith-Denny osde@microsoft.com 2024-10-03T17:31:31+00:00 urn:sha1:334f5748869996eee994f9dee41f3e6a3d9bd087 Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com> 2024-10-29T02:09:18+00:00 Oliver Smith-Denny osde@microsoft.com 2024-10-03T17:23:33+00:00 urn:sha1:040afc1e3be6e3d334c2483803b0470a34bced55 Includes changes across the module for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <taylor.d.beebe@gmail.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com> 2021-12-07T17:24:28+00:00 Michael Kubacki michael.kubacki@microsoft.com 2021-12-05T22:54:13+00:00 urn:sha1:47d20b54f9a65b08aa602a1866c1b59a69088dfc REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the ShellPkg package Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Ray Ni <ray.ni@intel.com> 2021-01-19T18:23:28+00:00 Laszlo Ersek lersek@redhat.com 2021-01-13T08:54:44+00:00 urn:sha1:f72fd9616eedac9a521adcbbe5086dd666c67232 The COMP shell command compares two files byte for byte. In order to retrieve the bytes to compare, it currently invokes gEfiShellProtocol->ReadFile() on both files, using a single-byte buffer every time. This is very inefficient; the underlying EFI_FILE_PROTOCOL.Read() function may be costly. Read both file operands in chunks of "PcdShellFileOperationSize" bytes. Draw bytes for comparison from the internal read-ahead buffers. Some ad-hoc measurements on my laptop, using OVMF, and the 4KB default of "PcdShellFileOperationSize": - When comparing two identical 1MB files that are served by EnhancedFatDxe on top of VirtioScsiDxe, this patch brings no noticeable improvement; the comparison completes in <1s both before and after. - When comparing two identical 1MB files served by VirtioFsDxe, the comparison time improves from 2 minutes 25 seconds to <1s. Cc: Philippe Mathieu-Daudé <philmd@redhat.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3123 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Message-Id: <20210113085453.10168-2-lersek@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> 2019-04-09T17:58:25+00:00 Michael D Kinney michael.d.kinney@intel.com 2019-04-03T23:07:06+00:00 urn:sha1:56ba37463a5ffa44df1c5741184ba0594fadbeba https://bugzilla.tianocore.org/show_bug.cgi?id=1373 Replace BSD 2-Clause License with BSD+Patent License. This change is based on the following emails: https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html RFCs with detailed process for the license change: V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> 2018-06-28T03:19:51+00:00 Liming Gao liming.gao@intel.com 2018-06-27T13:13:38+00:00 urn:sha1:ba0014b9f8ae1a593f03e744f26008214c2b06a8 1. Do not use tab characters 2. No trailing white space in one line 3. All files must end with CRLF Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao <liming.gao@intel.com> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com> 2018-06-21T07:24:56+00:00 Ruiyu Ni ruiyu.ni@intel.com 2018-06-14T05:55:21+00:00 urn:sha1:c2d6e2bc12b2a4e99304a1ebbc3474638721f5a8 Today's implementation returns 0 even when compared files are different. The patch returns 27 (SHELL_NOT_QUAL) in such case to follow the shell spec. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> 2017-04-20T02:44:13+00:00 Ruiyu Ni ruiyu.ni@intel.com 2017-04-20T02:16:12+00:00 urn:sha1:a32c1a5b1c0945a7159a42a28aafcde4011ad55d Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chen A Chen <chen.a.chen@intel.com> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>