EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=master 2025-12-04T08:43:02+00:00 2025-12-04T08:43:02+00:00 Ard Biesheuvel ardb@kernel.org 2025-11-26T12:33:00+00:00 urn:sha1:3bc03ff552c81259cb838cd286a5a7c074c1aaba Clang complains about unused variables: ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rimt/RimtParser.c:21:60: error: variable 'mRimtNodeHeader' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration] 21 | STATIC EFI_ACPI_6_6_RIMT_NODE_HEADER_STRUCTURE mRimtNodeHeader; | ^~~~~~~~~~~~~~~ ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rimt/RimtParser.c:25:60: error: variable 'mRimtIdMappingNode' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration] 25 | STATIC EFI_ACPI_6_6_RIMT_ID_MAPPING_STRUCTURE mRimtIdMappingNode; | ^~~~~~~~~~~~~~~~~~ 28 | STATIC EFI_ACPI_6_6_RIMT_PCIE_ROOT_COMPLEX_NODE_STRUCTURE mRimtPcieRootComplexNode; | ^~~~~~~~~~~~~~~~~~~~~~~~ ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rimt/RimtParser.c:29:60: error: variable 'mRimtIommuNode' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration] 29 | STATIC EFI_ACPI_6_6_RIMT_IOMMU_NODE_STRUCTURE mRimtIommuNode; | ^~~~~~~~~~~~~~ 4 errors generated. This is because these variables are only used to take the size of their fields using the sizeof() operator, which does not support type names directly. So create a helper macro SIZE_OF_T () that provides the functionality we need, and drop the unused variables. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> 2025-11-23T21:20:54+00:00 Krzysztof Drobinski krzysztof@plasteli.net 2025-09-11T13:04:30+00:00 urn:sha1:7e9901887e0a533500087d71e80e0ca92bbbb19d Implementation tested on Qemu-10.1 virt machine with IOMMU enabled. Signed-off-by: Krzysztof Drobiński <krzysztof@plasteli.net>