EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=trunk 2024-06-04T03:43:08+00:00 2024-06-04T03:43:08+00:00 kx kx@radix.pro 2024-06-04T03:43:08+00:00 urn:sha1:7e2ccccace24636f29ddc210b94606abd4c7e42b 2021-12-07T17:24:28+00:00 Michael Kubacki michael.kubacki@microsoft.com 2021-12-05T22:54:13+00:00 urn:sha1:47d20b54f9a65b08aa602a1866c1b59a69088dfc REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the ShellPkg package Cc: Andrew Fish <afish@apple.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Ray Ni <ray.ni@intel.com> 2020-06-30T01:39:50+00:00 Tomas Pilar Tomas.Pilar@arm.com 2020-06-19T11:59:54+00:00 urn:sha1:db77d8f7ee9490138d853c4fb06e7a1e14a49148 The UefiShellAcpiViewCommandLib is converted from NULL library to a named library so that it may be used in modules other than shell. The library interface exposes the main method for to AcpiView functionality as well as a helper method to dump a buffer to a file. The Shell module is still built by pulling UefiShellAcpiViewCommandLib as a NULL library to preserve the modularity of shell builds. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Tomas Pilar <tomas.pilar@arm.com> 2020-06-30T01:39:50+00:00 Tomas Pilar Tomas.Pilar@arm.com 2020-06-19T11:59:54+00:00 urn:sha1:d45cf5ffdf65f6bfdde64886746d81a69ae31bf4 Method is refactored into two parts. A new method is created that dumps arbitrary buffers into a newly created file. This method is called from core code after the core code determined the appropriate filename to be used. This improves the modular design. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Tomas Pilar <tomas.pilar@arm.com> 2020-06-30T01:39:50+00:00 Tomas Pilar Tomas.Pilar@arm.com 2020-06-19T11:59:54+00:00 urn:sha1:422fe85cc3109684c81990911c79dc18d1828d96 Parsing command line parameters is done in the shell command wrapper. This declutters the core code and improves modular design. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Tomas Pilar <tomas.pilar@arm.com> 2020-06-30T01:39:50+00:00 Tomas Pilar Tomas.Pilar@arm.com 2020-06-19T11:59:54+00:00 urn:sha1:e46e3040fc3b39dcade8b88cdc02565ff6b26374 The table count module level symbols are now reset when executing the core method, rather than the shell command wrapper. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Tomas Pilar <tomas.pilar@arm.com> 2020-06-30T01:39:50+00:00 Tomas Pilar Tomas.Pilar@arm.com 2020-06-19T11:59:54+00:00 urn:sha1:e18ac66d84e68387dbbe4fd8761b8f3a889534a9 A new file and header (AcpiViewConfig.[ch]) is created that houses the user configuration. This declutters the core code and improves modularity of the design. The module level symbols for verbosity, table selection, and highlighting are refactored into the new file. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Tomas Pilar <tomas.pilar@arm.com> 2020-06-30T01:39:50+00:00 Tomas Pilar Tomas.Pilar@arm.com 2020-06-19T11:59:54+00:00 urn:sha1:cae974bea25a3193360390af0b405488a19e1e15 The error and warning counters are reset in the AcpiView main method. This improves reusability of the main method. Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Tomas Pilar <tomas.pilar@arm.com> 2020-05-06T17:00:57+00:00 Krzysztof Koch krzysztof.koch@arm.com 2020-03-25T09:39:24+00:00 urn:sha1:faef5a367c8345df906be3755e15e0dabc3105b3 For Arm-based platforms, count the instances of installed tables for each ACPI table listed as 'mandatory' in any Server Base Boot Requirements (SBBR) specification. Validate that the all the mandatory SBBR tables present. Report an error for each missing table. This new feature is optional and can be enabled with the -r command line parameter. Reference(s): - Arm Server Base Boot Requirements 1.2, September 2019 - Arm Server Base Boot Requirements 1.1, May 2018 - Arm Server Base Boot Requirements 1.0, March 2016 Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com> Reviewed-by: Sami Mujawar <Sami.Mujawar@arm.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> 2020-05-06T17:00:57+00:00 Krzysztof Koch krzysztof.koch@arm.com 2020-03-25T09:39:22+00:00 urn:sha1:8af507c1f16d9cc311e83397881016e3887acfbb Define a new command line parameter '-r' to enable checking if all mandatory ACPI tables listed in a specification are present. The -r parameter takes an integer value to specify which specification the validation should be performed against. The parameter is used to set two Acpiview variables. An interface to access these variables is implemented in this patch. The new functionality is aimed at Arm-based platforms, however, there are no restriction on extending it to other architectures. For the 32-bit and 64-bit Arm architectures, the possible values for the -r parameter are: 0: Arm Server Base Boot Requirements 1.0, March 2016 1: Arm Server Base Boot Requirements 1.1, May 2018 2: Arm Server Base Boot Requirements 1.2, September 2019 Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com> Reviewed-by: Sami Mujawar <Sami.Mujawar@arm.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>