Tianocore/edk2.git/ShellPkg/Application, branch dependabot/github_actions/github/issue-labeler-3.5

ShellPkg/Shell: Terminate and separate the ShellOpt command line

2026-10-15T10:15:44+00:00

CreatePopulateInstallShellParametersProtocol() combined image load options and ShellOpt without reserving a NUL terminator. Neither input must carry one, so ParseCommandLineToArgs() could read beyond the allocation. The load options also overwrote ShellOpt when both inputs were present. Read ShellOpt into a separately terminated buffer, validate its CHAR16 size, normalize its effective length, and propagate read failures. Reserve space for a separator and terminator in the combined buffer. Preserve the image name at Argv[0] and insert ShellOpt immediately after it, before the rest of the load options. Appending ShellOpt at the end would pass shell options as arguments to a script or application named in the load options. Use the parser's argument-boundary rules so quoted image paths retain their meaning. Fixes: https://github.com/tianocore/edk2/issues/10549 Signed-off-by: Jin Kang <112378607+JinKang021004@users.noreply.github.com>

ShellPkg: Trim cmd parameters if -? is present

2026-09-16T14:27:54+00:00

The presence of "-?" in a command line is equivalent to issuing "help " and displays the manual page of the command. However the additional command specific parameters/flags are also passed to the help command and are mis-interpreted by the help command. E.g. "ls -r -?" translates to "help ls -r" """ Shell> ls -r -? help: Unknown flag - '-r' """ Update DoHelpUpdate() to only keep the command name and trim additional command specific parameters. To pass "help" specific flags while getting the manual page for a command, the usage of the "help" command should be preferred over adding "-?". Note: As a side effect, issuing: """ Shell> -? """ - used to be translated to "help -?", i.e. request the manual for the help command - is now translated to "help", i.e. request all the shell command available Signed-off-by: Pierre Gondois

ShellPkg/Shell: Preserve multi-instance device paths

2026-08-26T11:32:07+00:00

EfiShellGetMapFromDevicePath() stops at any end-type node and converts an end-instance node into an end-entire node. This truncates a multi-instance device path and modifies the protocol data in place. Walk until the end-entire node instead. This leaves intermediate instances and the original device path unchanged. Signed-off-by: JinKang <2371488344@qq.com>

ShellPkg/Shell: Remove duplicate Guid in INF file

2026-04-29T09:18:10+00:00

In Shell driver, gShellAliasGuid appears twice in [Guids] section, so remove the duplicate one. Signed-off-by: Qihang Gao

ShellPkg/UefiShellLib: Add IsDotOrDotDot() function

2026-04-24T18:18:47+00:00

Replace existing checks against L"." and L".." by a named function. No functional change. Signed-off-by: Pierre Gondois

ShellPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

ShellPkg: Use the newly introduced ShellPrintDefaultEx() alias

2025-10-01T08:02:57+00:00

Make use the newly introduced ShellPrintDefaultEx() alias and replace wherever it is possible: - "ShellPrintEx (-1, -1," with: - "ShellPrintDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg: Use the newly introduced ShellPrintHiiDefaultEx() alias

2025-10-01T08:02:57+00:00

Make use the newly introduced ShellPrintHiiDefaultEx() alias and replace wherever it is possible: - "ShellPrintHiiEx (-1, -1, NULL," with: - "ShellPrintHiiDefaultEx (" No functional change is introduced. Signed-off-by: Pierre Gondois

ShellPkg: Deprecate EFI_UNICODE_COLLATION_PROTOCOL_GUID

2025-09-05T13:50:50+00:00

As EFI_UNICODE_COLLATION_PROTOCOL_GUID is being deprecated. Remove the instances used in ShellPkg. Cc: Sachin Ganesh Signed-off-by: Gowtham M

ShellPkg: Fixed Deadcode and Null field Coverity warnings.

2025-07-24T07:57:29+00:00

Updated fixes for all Deadcode and Null field Coverity fixes in ShellPkg Signed-off-by: Revathy