Tianocore/edk2.git/SecurityPkg/Library/SecureBootVariableLib, branch master

SecurityPkg/SecureBootVariableLib: Cleanup debug print readability

2026-05-06T10:43:05+00:00

All debug prints should end in a newline character. Signed-off-by: Benjamin Doron

SecurityPkg/Library/SecureBootVariableLib/UnitTest: Cmocka use issues

2026-01-21T09:15:06+00:00

Fix mocked versions of GetVariable() and SetVariable(). * VendorGuid parameter use expect_memory() not expect_value() * MockSetVariable() use check_expected() for Attributes parameter * MockSetVariable() use check_expected_ptr() for Data parameter * Calls to MockGetVariable() use (UINTN) cast for will_return() of pointer to data buffer returned. Issues found with Linux GCC NOOPT IA32 builds of unit tests. Signed-off-by: Michael D Kinney

SecurityPkg/Library/SecureBootVariableLib/UnitTest: Fix CLANG

2025-12-23T01:57:45+00:00

Fix uninitialized variable error in unit tests detected by clang by zeroing local variable structure before use in unit test cases. Signed-off-by: Michael D Kinney

SecurityPkg: Update SecureBootVariableLibUnitTest

2025-04-17T05:37:37+00:00

Updates SecureBootVariableLibUnitTest to use a valid EFI_SIGNATURE_LIST and EFI_SIGNATURE_DATA Signed-off-by: Doug Flick

SecurityPkg: SecureBootVariableLib: Prevent Invalid DBX

2025-04-17T05:37:37+00:00

This commit adds the ability to skip the setting the Dbx variable if the Default being provided is less than the size of the EFI_SIGNATURE_LIST structure. This is to prevent the setting of an invalid DBX which would cause the system to fail to boot. Additionally, this can be used to signal that setting the DBX should leave DBX undefined for Platforms that want to let the OS be the sole servicer of the DBX. Breakdown of the math is as follows: 1. **`sizeof(EFI_SIGNATURE_LIST)`**: - This is the size of the `EFI_SIGNATURE_LIST` structure itself, which includes: - `EFI_GUID SignatureType` (16 bytes) - `UINT32 SignatureListSize` (4 bytes) - `UINT32 SignatureHeaderSize` (4 bytes) - `UINT32 SignatureSize` (4 bytes) - Total: `16 + 4 + 4 + 4 = 28 bytes` 2. **`SignatureHeaderSize`**: - This is the size of the optional signature header. If no header is provided, this value is `0`. 3. **`SignatureSize`**: - This is the size of each `EFI_SIGNATURE_DATA` entry. For an empty list, this value is `0`. The total size of an empty `EFI_SIGNATURE_LIST` is: ```c sizeof(EFI_SIGNATURE_LIST) + SignatureHeaderSize ``` 1. **No Signature Header**: - If `SignatureHeaderSize = 0`, the size is: ```c 28 + 0 = 28 bytes ``` 2. **With a Signature Header**: - If `SignatureHeaderSize = 16` (example size for a header), the size is: ```c 28 + 16 = 44 bytes ``` - **Minimum Size**: `28 bytes` (if `SignatureHeaderSize = 0`). - **Additional Size**: Add the value of `SignatureHeaderSize` if a header is included. Signed-off-by: Doug Flick

SecurityPkg: Apply uncrustify formatting to relevant files

2023-10-27T00:50:49+00:00

Apply uncrustify formatting to GoogleTest cpp and header files. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Vivian Nowka-Keane Reviewed-by: Michael D Kinney

SecurityPkg: Update code to be more C11 compliant by using func

2023-04-10T14:19:57+00:00

__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among others support, while __func__ was standardized in C99. Since it's more standard, replace __FUNCTION__ with __func__ throughout SecurityPkg. Signed-off-by: Rebecca Cran Reviewed-by: Michael D Kinney Reviewed-by: Ard Biesheuvel

SecurityPkg/Library/SecureBootVariableLib: HOST_APPLICATION IA32/X64 only

2023-04-10T05:59:02+00:00

Update SecureBootVariableLib host-based unit test INF file to only list VALID_ARCHITECTURES of IA32 and X64 to align with all other host-based unit test INF files. The UnitTestFrameworkPkg only provides build support of host-based unit tests to OS applications for IA32 and X64. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Michael D Kinney Reviewed-by: Jiewen Yao Reviewed-by: Oliver Smith-Denny

SecurityPkg/Library/SecureBootVariableLib: Fix VS20xx 4122 errors

2023-04-10T05:59:02+00:00

The unit test code for the SecureBootVariableLib is initializing local variable structures in their declaration from other local variables that are also initialized in their declaration. ANSI C does not allow this and error 4122 is generated on VS20xx compilers. The test cases are updated to initialize the local structure fields in C statements instead of their local variable declaration. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Michael D Kinney Reviewed-by: Jiewen Yao Reviewed-by: Oliver Smith-Denny

SecurityPkg: Add gmock example

2023-04-10T05:59:02+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Chris Johnson Acked-by: Jiewen Yao Reviewed-by: Oliver Smith-Denny Reviewed-by: Michael D Kinney

Tianocore/edk2.git/SecurityPkg/Library/SecureBootVariableLib, branch master

SecurityPkg/SecureBootVariableLib: Cleanup debug print readability

SecurityPkg/Library/SecureBootVariableLib/UnitTest: Cmocka use issues

SecurityPkg/Library/SecureBootVariableLib/UnitTest: Fix CLANG

SecurityPkg: Update SecureBootVariableLibUnitTest

SecurityPkg: SecureBootVariableLib: Prevent Invalid DBX

SecurityPkg: Apply uncrustify formatting to relevant files

SecurityPkg: Update code to be more C11 compliant by using __func__

SecurityPkg/Library/SecureBootVariableLib: HOST_APPLICATION IA32/X64 only

SecurityPkg/Library/SecureBootVariableLib: Fix VS20xx 4122 errors

SecurityPkg: Add gmock example

SecurityPkg: Update code to be more C11 compliant by using func