Tianocore/edk2.git/RedfishPkg/Library, branch master

RedfishPkg/HiiUtilityLib: Fix memory leak in HiiUtilityInternal

2026-09-25T12:42:52+00:00

StrValue is obtained from HiiGetString(), which allocates a new string buffer. The buffer is used to set DefaultValue->Buffer but is never released, causing a memory leak each time this code path is executed. Add FreePool (StrValue) after it is no longer needed. No functional change intended. Signed-off-by: Qihang Gao

RedfishPkg: Remove unnecessary Depex section in library modules

2026-06-29T16:41:24+00:00

Libraries that may be consumed by UEFI_DRIVER should not have depex section for UEFI_DRIVER. The INF specification said: If the Module is a Library, then a [Depex] section is optional. Regarding HiiUtilityLib, RedfishDebugLib and RedfishHttpLib, they don't have additional dependence, so the Depex sections should be removed to ensure no adverse impact on the UEFI_DRIVER. Signed-off-by: Qihang Gao

RedfishPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

RedfishPkg/RedfishPlatformConfig: Fix CLANGPDB build failure

2026-01-22T01:27:21+00:00

CLANGPDB build fails because the intrinsic _memcpy is used by the compiler for the value structure passed via a function. Change the code to use the value reference. This fixes the issue: #11882 Signed-off-by: Abner Chang

RedfishPkg: Drop ARM32 Support

2025-09-25T22:04:10+00:00

edk2 is dropping support for the ARM32 architecture. This commit drops ARM32 code from RedfishPkg. This also drops irrelevant VALID_ARCHITECTURES comments in infs that are not arch specific. Signed-off-by: Oliver Smith-Denny

RedfishPkg/JsonLib: Define NO_MSABI_VA_FUNCS for GCC X64

2025-09-19T10:54:10+00:00

For GCC family X64 builds, add -DNO_MSABI_VA_FUNCS to force use of the compiler default vararg macros. This define is required in libraries that use a standard C source submodule and there are one or more vararg functions. The calling convention of the vararg function must match the calling convention of the vararg macros used within the vararg function. In the JsonLib case, jsonp_error_set() is a vararg function and generates the following error for CLANGDWARF X64 builds. RedfishPkg/Library/JsonLib/jansson/src/error.c:37:5: error: '__builtin_ms_va_start' used in System V ABI function 37 | va_start(ap, msg); | ^ This change matches CryptoPkg openssl and mbedtls library INF files that also define NO_MSABI_VA_FUNCS. Signed-off-by: Michael D Kinney

RedfishPkg/JsonLib: Use same defines for MSFT and GCC families

2025-06-13T15:47:59+00:00

CLANGPDB and CLANGDWARF are in GCC family. When CLANGPDB or CLANGDWARF are used from windows host, the same defines and undefines must be applied to GCC family for CLANG builds. This resolves CLANG 20.1.0 build errors. Signed-off-by: Michael D Kinney

RedfishPkg: introduce platform wanted device lib

2025-05-01T23:05:21+00:00

Introduce platform wanted device lib to RedfishPkg. This library provide the flexibility for platform owner to device which device we like to support Redfish service. This helps to reduce boot time and resource on devices that is not host interface. A null library is implemented and it accepts all devices as default behavior. Signed-off-by: Nickle Wang

RedfishPkg: Populate serial number in SMBIOS type 42 record

2025-04-02T03:32:19+00:00

Add a stub function to read host interface USB serial number, append serial number to SMBIOS type 42 record if valid data is returned. Signed-off-by: Thejaswani Putta

Redfish/HiiUtilityLib Fix incorrect type assignment

2024-12-27T09:06:40+00:00

Replaced direct assignment of 'Value = (EFI_HII_VALUE *)&Question->Value' with the correct usage of HiiStatementValueToHiiValue function. This resolves the issue where EFI_HII_VALUE and HII_STATEMENT_VALUE types are incompatible, ensuring proper handling of Question->Value. Signed-off-by: Igor Kulchytskyy