Tianocore/edk2.git/RedfishPkg/Library/HiiUtilityLib, branch dependabot/github_actions/actions/setup-python-7

RedfishPkg: Remove unnecessary Depex section in library modules

2026-06-29T16:41:24+00:00

Libraries that may be consumed by UEFI_DRIVER should not have depex section for UEFI_DRIVER. The INF specification said: If the Module is a Library, then a [Depex] section is optional. Regarding HiiUtilityLib, RedfishDebugLib and RedfishHttpLib, they don't have additional dependence, so the Depex sections should be removed to ensure no adverse impact on the UEFI_DRIVER. Signed-off-by: Qihang Gao

RedfishPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

Redfish/HiiUtilityLib Fix incorrect type assignment

2024-12-27T09:06:40+00:00

Replaced direct assignment of 'Value = (EFI_HII_VALUE *)&Question->Value' with the correct usage of HiiStatementValueToHiiValue function. This resolves the issue where EFI_HII_VALUE and HII_STATEMENT_VALUE types are incompatible, ensuring proper handling of Question->Value. Signed-off-by: Igor Kulchytskyy

RedfishPkg: add explicit variable initialization

2023-11-30T07:10:34+00:00

Ancient GCC 4.8.5 warned about variable may be unitialied. And it doesn't look like false alarm. The warning is: edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c: In function 'GetQuestionDefault': edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c:5519:6: error: 'ConfigAccess' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (ConfigAccess != NULL) { Cc: Abner Chang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang Signed-off-by: Mike Maslenkin

RedfishPkg: fix memory leak in HiiUtilityLib

2023-11-30T07:10:34+00:00

Cc: Abner Chang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang Signed-off-by: Mike Maslenkin

RedfishPkg: introduce HII utility helper library

2023-04-28T12:21:38+00:00

HiiUtilityLib is a helper library that provides the functions to manipulate HII options. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy