Tianocore/edk2.git/NetworkPkg, branch dependabot/github_actions/github/codeql-action-4EDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Fgithub%2Fcodeql-action-42025-10-31T19:35:42+00:00NetworkPkg/SnpDxe: Fix Snp used uninitialized2025-10-31T19:35:42+00:00eeshanleeshanlondhe@microsoft.com2025-10-31T17:27:50+00:00urn:sha1:9b71501f6c190a3767f50fdfff24bbe7f213a65f
Ensures the Snp Structure is initialized as NULL.
Signed-off-by: Eeshan Londhe <eeshanlondhe@microsoft.com>
NetworkPkg: Remove DXE_SAL_DRIVER2025-10-30T10:00:32+00:00Sathya Ravichandransathyar@ami.com2025-09-23T11:06:36+00:00urn:sha1:41f7c0cd9eb3e999268b43c30b7219563c62c234
The DXE_SAL_DRIVER module type was introduced to support
Itanium (IPF) platforms. Since support for Itanium processors has been
dropped, the instances of DXE_SAL_DRIVER have been removed.
Ref: [3cb0a311cb7e747d7be5c5076d0fff76ad256d2b]
Cc: Sachin Ganesh <sachinganesh@ami.com>
Signed-off-by: Sathya Ravichandran <sathyar@ami.com>
NetworkPkg/SnpDxe: Update SnpDxe SNP_DRIVER struct out of DMA-able memory.2025-10-29T18:32:42+00:00eeshanleeshanlondhe@microsoft.com2025-05-28T23:06:12+00:00urn:sha1:302cc88ab36ffb96622987a55f4abc22a4751fed
CPB, DB, and CDB structs to use DMA-able memory.
Updates the overall SNP_DRIVER allocation to use AllocatePool() instead of PciIo->AllocateBuffer(). This moves this struct out of DMA-able memory.
Allocates the PXE_CDB struct as a pointer instead, using PciIo->AllocateBuffer() for DMA-able memory.
End result:
CPB, DB, and CDB are allocated with individual PciIo->AllocateBuffer() calls with a size of 4096 for CPB and DB. and sizeof(PXE_CDB) for CDB.
Each of these members point to locations within the Allocated Buffer, and all of these pointers are at-least
8-Byte aligned.
SNP_DRIVER is allocated with AllocatePool()
In the SNP_DRIVER structure, the PXE_CDB member is changed to a pointer so we can allocate it with PciIo->AllocateBuffer()
Signed-off-by: Eeshan Londhe <eeshanlondhe@microsoft.com>
NetworkPkg/UefiPxeBcDxe: Add buffer check before reporting status code2025-10-01T16:46:03+00:00Marc Chenmarc.chen@microsoft.com2025-09-30T05:04:56+00:00urn:sha1:d3a64baf4b6706367c30a4886c01e95589861c9f
When PxeBcLoadBootFile() fails, it reports a status code to notify
listeners (such as telemetry/SEL logging drivers) about the error.
However, the current implementation reports the status code for all
error conditions, including benign cases, such as where the caller passes
Buffer == NULL with EFI_BUFFER_TOO_SMALL to query the required size.
This causes false positive error reports in telemetry systems, as
EFI_BUFFER_TOO_SMALL with Buffer == NULL is an expected and normal
operation for size queries, not an actual error condition.
The PXE-E05 error message is already correctly guarded with the
condition "(Status == EFI_BUFFER_TOO_SMALL) && (Buffer != NULL)",
but the status code reporting was unconditional.
Add a buffer null check before REPORT_STATUS_CODE_WITH_EXTENDED_DATA
to ensure status codes are only reported for actual errors:
- Report when Status != EFI_BUFFER_TOO_SMALL (all other errors)
- Report when Status == EFI_BUFFER_TOO_SMALL AND Buffer != NULL (PXE-E05)
- Skip when Status == EFI_BUFFER_TOO_SMALL AND Buffer == NULL (size query)
This prevents spurious error logs while maintaining proper error
reporting for genuine failures including PXE-E05, PXE-E07, PXE-E09,
PXE-E99, and all other error conditions.
Signed-off-by: Marc Chen <marc.chen@microsoft.com>
NetworkPkg: Use the newly introduced ShellPrintHiiDefaultEx() alias2025-10-01T08:02:57+00:00Pierre Gondoispierre.gondois@arm.com2025-09-18T12:12:04+00:00urn:sha1:432feb6b56f652decb1e3287554635b6253f52a5
Make use the newly introduced ShellPrintHiiDefaultEx() alias and
replace wherever it is possible:
- "ShellPrintHiiEx (-1, -1, NULL,"
with:
- "ShellPrintHiiDefaultEx ("
No functional change is introduced.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
NetworkPkg: Drop ARM32 Support2025-09-25T22:04:10+00:00Oliver Smith-Dennyosde@microsoft.com2025-09-15T14:56:45+00:00urn:sha1:1764d4eb2b1cc9e77640453e8465ddb107ea2b1c
edk2 is dropping support for the ARM32 architecture. This
commit removes ARM32 code from NetworkPkg. This also drops
irrelevant VALID_ARCHITECTURES comments from infs that are
not arch specific.
Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
NetworkPkg/UefiPceBcDxe/GoogleTest: Add missing EFIAPI2025-09-18T17:25:38+00:00Michael D Kinneymichael.d.kinney@intel.com2025-08-21T16:12:21+00:00urn:sha1:9ac6e450e40ef1b2db15ba456329c9fe4e986c8a
CLANGDWARF generates a build error for calling convention
mismatch in UdpRead(), UdpWrite(), and Configure() mock
functions. Add EFIAPI so mock function matches function
prototype of function being mocked.
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
NetworkPkg/Dhcp6Dxe/GoogleTest: Fix init of complex struct2025-09-18T17:25:38+00:00Michael D Kinneymichael.d.kinney@intel.com2025-08-21T16:09:19+00:00urn:sha1:b05c8d7b808d06915467649cf4e31668b5e7cd7a
CLANGDWARF generates build error for missing braces when
initializing a complex structure. Change initialization of
EFI_DHCP6_IA local variable to a call to ZeroMem() instead.
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
NetworkPkg/TlsDxe: Add SNI support2025-09-04T08:32:34+00:00INDIA\kanagavelskanagavels@ami.com2025-07-09T09:15:46+00:00urn:sha1:41cde6e2e313382f6ec4078577ad3dfbbd0c743c
Add Server Name Indication Support.
Signed-off-by: Kanagavel S <kanagavels@ami.com>
NetworkPkg/WifiConnectionManagerDxe: UI Disconnect2025-08-25T18:24:32+00:00Zachary Clark-Williamszachary.clark-williams@intel.com2025-08-20T07:46:44+00:00urn:sha1:d188ad6a1fb60f8331bb2e6a269836eba041d032
- Fix WifiMgrOnTimerTick to ensure the timer does
not exit early when a disconnect is pending,
allowing UI-initiated disconnects to complete as
expected.
Signed-off-by: Zachary Clark-Williams <Zachary.Clark-Williams@intel.com>