Tianocore/edk2.git/NetworkPkg, branch dependabot/github_actions/actions/github-script-9

NetworkPkg/DnsDxe: Refactor answer loop to for in ParseDnsResponse

2026-05-01T14:21:01+00:00

The answer section loop in ParseDnsResponse() iterated a counter AnswerSectionNum from 0 to DnsHeader->AnswersNum using a while loop with a manual increment at the bottom. Convert it to an equivalent for loop to make the initialization, condition, and increment explicit. Also replace the unconditional Status = EFI_NOT_FOUND assignment before the loop with a conditional that only sets it when the loop is never entered (DnsHeader->AnswersNum == 0). ParseDnsResponse() initializes Status to EFI_SUCCESS at function entry, and the loop body always overwrites Status, so the pre-assignment was dead code in the common case. The conditional form makes the intent explicit: EFI_NOT_FOUND is only the result when there are no answer records. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: abuthahirm

NetworkPkg/Ip4Dxe: Fix missing Status check on Ip4Cfg2->SetData call

2026-05-01T14:21:01+00:00

In Ip4Config2ConvertIfrNvDataToConfigNvData(), when the policy is changed away from a static configuration (PolicyChanged is TRUE), the first call to Ip4Cfg2->SetData() was not checking its return value and always returned EFI_SUCCESS. Fix this to check and return Status on error, consistent with the second SetData call in the same function. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: abuthahirm

NetworkPkg/Ip4Dxe: Reject IPv4 addresses ending with dot

2026-04-29T21:25:12+00:00

Issue: UI accepts invalid IPv4 addresses ending with a dot in the IPv4 Network Configuration page. Examples: - Local IP Address: 192.168.1.10. - Subnet Mask: 255.255.255.0. - Gateway: 2.2.2.2. - DNS Servers: 1.1.1.1. Root Cause: The function Ip4Config2StrToIp converts user-entered IPv4 strings into numbers. When an address ending with a dot like '1.1.1.1.' is entered, the code skips over the 4th dot, reaches the string's null terminator, and incorrectly treats it as valid. Fix: Refactor Ip4Config2StrToIp to be a thin wrapper around the existing BaseLib StrToIpv4Address() helper. After parsing, the EndPointer is checked to ensure the entire string was consumed (i.e. EndPointer points to the null terminator). Any trailing characters, including a trailing dot, cause EFI_INVALID_PARAMETER to be returned. Signed-off-by: Abuthahir M

NetworkPkg/GoogleTest: Remove duplicate file name in INF file

2026-04-29T09:18:10+00:00

In GoogleTest driver, Ip6OptionGoogleTest.h appears twice in [Sources] section, so remove the duplicate one. Signed-off-by: Qihang Gao

NetworkPkg/HttpBootDxe: Add all events to HttpBootHttpCallback()

2026-04-27T23:30:35+00:00

Include other events from EDKII_HTTP_CALLBACK_EVENT to print failure information in the event of HTTP Boot failure Signed-off-by: Saloni Kasbekar

NetworkPkg/HttpBootDxe: Print TLS errors on screen during HTTP boot

2026-04-06T19:25:44+00:00

Install EDKII_HTTP_CALLBACK_PROTOCOL in HttpBootDxe to receive TLS events from HttpDxe during the HTTP Boot process. When a TLS error occurs (failed TLS session connection or TLS configuration), print an error message on screen using AsciiPrint(). The callback is installed in HttpBootInstallCallback() and uninstalled in HttpBootUninstallCallback(), ensuring TLS errors are only printed during the HTTP Boot process and not for other TLS accesses. Signed-off-by: Saloni Kasbekar

NetworkPkg/UefiPxeBcDxe: Add missing Token.Context initialization

2026-04-01T00:11:57+00:00

Adds missing `Token.Context = Private` initialization in two MTFTP write-file functions. Without this, the `Context` field passed to the MTFTP `WriteFile` callback was uninitialized, which could lead to a page fault when the callback attempted to access the `Private` driver context. The corresponding read-file functions already set this field correctly. Signed-off-by: Michael Kubacki

NetworkPkg: Reset DHCP Service Binding IO Status on Stop

2026-03-26T17:07:43+00:00

Resets DhcpSb->IoStatus on stop to prevent a stale state from persisting which might impact future operations dependent on the IO status. Co-authored-by: Wenbo Hou Signed-off-by: Michael Kubacki

NetworkPkg: Ip4Dxe/Ip6Dxe: Set SB notify to NULL after event close

2026-03-17T21:55:49+00:00

Ip4StartAutoConfig() and Ip6ConfigStartStatefulAutoConfig() close the DHCP service binding notify event when the service child is successfully created, but do not NULL the instance field afterward. On re-entry, the stale handle passes the non-NULL condition and is closed a second time, which results in a page fault with memory protections enabled. This change sets the event field to NULL immediately after CloseEvent() so that subsequent calls skip attempting to close the event again. Signed-off-by: Michael Kubacki

NetworkPkg: align UNI file headers with UNI Spec standard

2026-03-02T19:32:17+00:00

The Uni file standard specifies that comments begin with the characters "//". The following files contained incorrectly formatted C-style comments and have been updated: NetworkPkg/Application/VConfig/VConfigStrings.uni NetworkPkg/HttpBootDxe/HttpBootConfigStrings.uni NetworkPkg/Ip6Dxe/Ip6DxeStrings.uni NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni The problems were identified during testing of the parser https://github.com/xpahos/edk2-idea. Signed-off-by: Alexander Gryanko