Tianocore/edk2.git/NetworkPkg/WifiConnectionManagerDxe, branch dependabot/github_actions/actions/setup-python-7

NetworkPkg: Remove redundant Status initializations

2026-06-04T15:32:31+00:00

Remove redundant Status = EFI_SUCCESS and Status = EFI_DEVICE_ERROR initializations that are immediately overwritten before being read, across multiple modules: Dhcp6Dxe, DnsDxe, HttpBootDxe, HttpDxe, Ip4Dxe, Ip6Dxe, MnpDxe, Mtftp4Dxe, Mtftp6Dxe, SnpDxe, TcpDxe, TlsAuthConfigDxe, UefiPxeBcDxe and WifiConnectionManagerDxe. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: abuthahirm

NetworkPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

NetworkPkg: Remove unused variable

2025-11-22T01:43:26+00:00

XCODE5 toolchain finds this, with error: WifiConnectionMgrHiiConfigAccess.c:393:29: error: variable 'AvailableCount' set but not used Fixes: https://github.com/tianocore/edk2/commit/90b24889f9ced53c18b73266d507e45fbd94fab0 Signed-off-by: Mike Beaton

NetworkPkg/WifiConnectionManagerDxe: UI Disconnect

2025-08-25T18:24:32+00:00

- Fix WifiMgrOnTimerTick to ensure the timer does not exit early when a disconnect is pending, allowing UI-initiated disconnects to complete as expected. Signed-off-by: Zachary Clark-Williams

NetworkPkg/WifiConnectionManager: net list scan ui

2025-06-25T11:49:21+00:00

Commit 7c204d7 changed the behavior of the WiFi Connection Manager. It no longer scans for available networks when the driver loads, because scanning during that time disrupts connections for other features. To avoid blocking other processes, the driver should initiate a scan only when appropriate. This update introduces a one-time scan that occurs when the user opens the network settings page in the UI, enables WiFi, and then opens the network list page to view available networks. Signed-off-by: Zachary Clark-Williams

WifiConnectionManagerDxe: clear timers not events

2025-06-25T01:21:51+00:00

Replace timer eventclose with scan timerset in WifiConnectionManagerDxe. This change ensures that the driver sets and manages scan timers correctly without requiring a reload when the user enables WiFi and initiates a scan for available networks. By using scan timerset directly, the driver maintains consistent behavior across WiFi sessions and avoids redundant event handling. Signed-off-by: Zachary Clark-Williams

WifiConnectionManagerDxe: HII missing EAP TLS case

2025-06-25T00:28:42+00:00

Add missing EAP-TLS option to HII configuration Implemented support for EAP-TLS authentication in the WifiConnectionManagerDxe HII interface. This change ensures that the EAP-TLS option is available for selection in the UI, addressing cases where it was previously missing. Signed-off-by: Zachary Clark-Williams

WifiConnectionManager: Scan timer reconfig connect

2025-05-28T01:37:34+00:00

When the Wifi network is enabled the connection manager will trigger a network scan without a profile to use. If there is a connected network or attempting a connection, the scan will interrupt and break the connection. Fix - The Wifi Connection Manager will register the scan on timer tick but will not set the timer. This timer will only be set when the user enters or selects a profile for connection in the BIOS menu. If the user does not select a profile there is no need to start a scan timer. Additionally the scan on timer tick will check for a profile to connect and if no profile found then cancel the timer and exit. When the driver loads it will check for a profile and if one is found then the scan timer will be set. If no profile is found then the driver will not set the scan timer and will not attempt to scan. This will prevent the driver from scanning and breaking a connection if the user does not select a profile. Signed-off-by: Zachary Clark-Williams

NetworkPkg/WifiConnectionManagerDxe: Keep Setup page on no Wi-Fi module

2024-12-18T21:04:51+00:00

With the driver, "Wi-Fi Configuration" Setup page is available regardless of Wi-Fi module existence. When there is no Wi-Fi module, it is found that entering the page causes exiting Setup browser. User would think the result as an error. For better user experience, the update enables the page to report the module status like a blank page. It prevents exiting Setup. Signed-off-by: Phil Noh

NetworkPkg/WifiConnectionManagerDxe: Fix Connection Manager HII errors

2024-09-03T06:24:43+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4824 Fix the wrong logic in WifiMgrDxeHiiConfigAccessCallback with EFI_BROWSER_ACTION_CHANGING action. Cc: Jiangang He Cc: Abner Chang Signed-off-by: Neo Hsueh