Tianocore/edk2.git/NetworkPkg/TlsAuthConfigDxe, branch dependabot/github_actions/actions/setup-python-7

NetworkPkg: Remove redundant Status initializations

2026-06-04T15:32:31+00:00

Remove redundant Status = EFI_SUCCESS and Status = EFI_DEVICE_ERROR initializations that are immediately overwritten before being read, across multiple modules: Dhcp6Dxe, DnsDxe, HttpBootDxe, HttpDxe, Ip4Dxe, Ip6Dxe, MnpDxe, Mtftp4Dxe, Mtftp6Dxe, SnpDxe, TcpDxe, TlsAuthConfigDxe, UefiPxeBcDxe and WifiConnectionManagerDxe. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: abuthahirm

NetworkPkg: align UNI file headers with UNI Spec standard

2026-03-02T19:32:17+00:00

The Uni file standard specifies that comments begin with the characters "//". The following files contained incorrectly formatted C-style comments and have been updated: NetworkPkg/Application/VConfig/VConfigStrings.uni NetworkPkg/HttpBootDxe/HttpBootConfigStrings.uni NetworkPkg/Ip6Dxe/Ip6DxeStrings.uni NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxeStrings.uni The problems were identified during testing of the parser https://github.com/xpahos/edk2-idea. Signed-off-by: Alexander Gryanko

NetworkPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

NetworkPkg: Change 'Tls' to 'TLS'

2025-06-16T23:03:46+00:00

Sicne it's a user-visible string, change 'Tls' to 'TLS', which is more correct. Signed-off-by: Rebecca Cran

NetworkPkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the NetworkPkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Maciej Rabeda

NetworkPkg/TlsAuthConfigDxe: Use HiiPopUp() instead of CreatePopUp()

2020-04-17T17:34:33+00:00

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2635 According to EDK2 Driver Writer's Guide For UEFI 2.3.1, 4.2.18 Offer alternatives to function keys. Configuration of drivers should be accomplished via HII and via OS-present interfaces. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Maciej Rabeda Reviewed-by: Siyuan Fu Reviewed-by: Maciej Rabeda

Revert "TlsAuthConfigDxe: fix TlsCaCertificate attributes retrieval"

2020-04-07T13:51:24+00:00

This reverts commit 6896efdec2709e530b23c688cf0f31706709a0c5. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062 GetVariable() now returns attributes when it fails with EFI_BUFFER_TOO_SMALL. Therefore, commit 6896efdec270 is reverted since it is no longer relevant. Cc: Laszlo Ersek Cc: Siyuan Fu Cc: Maciej Rabeda Cc: Jiaxin Wu Signed-off-by: Michael Kubacki Reviewed-by: Bret Barkelew Reviewed-by: Laszlo Ersek Reviewed-by: Siyuan Fu

NetworkPkg/Tls: Fix few typos

2020-02-10T22:30:07+00:00

Fix few typos in comments and documentation. Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Maciej Rabeda Signed-off-by: Philippe Mathieu-Daude Message-Id: <20200207010831.9046-50-philmd@redhat.com>

NetworkPkg: fix CloseProtocol & UninstallMultipleProtocolInterfaces calls

2019-10-09T07:40:10+00:00

Both the "ControllerHandle" parameter of CloseProtocol() and the "Handle" parameter of UninstallMultipleProtocolInterfaces() have type EFI_HANDLE, not (EFI_HANDLE*). This patch fixes actual bugs. The issues have been dormant likely because they are on error paths. (Or, in case of TlsAuthConfigDxe, because the driver is unloaded likely very infrequently.) Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Laszlo Ersek Reviewed-by: Siyuan Fu Reviewed-by: Philippe Mathieu-Daudé

NetworkPkg: Replace BSD License with BSD+Patent License

2019-04-09T17:58:15+00:00

https://bugzilla.tianocore.org/show_bug.cgi?id=1373 Replace BSD 2-Clause License with BSD+Patent License. This change is based on the following emails: https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html RFCs with detailed process for the license change: V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael D Kinney Reviewed-by: Siyuan Fu