Tianocore/edk2.git/NetworkPkg/HttpDxe, branch dependabot/github_actions/actions/setup-python-7

NetworkPkg/HttpDxe: Fix missing error check in TlsCommonTransmit

2026-06-04T15:32:31+00:00

In HttpsReceive(), the return value of TlsCommonTransmit() was not checked. Add error handling with proper cleanup of PacketOut and BufferOut before returning on failure. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: abuthahirm

NetworkPkg: Remove redundant Status initializations

2026-06-04T15:32:31+00:00

Remove redundant Status = EFI_SUCCESS and Status = EFI_DEVICE_ERROR initializations that are immediately overwritten before being read, across multiple modules: Dhcp6Dxe, DnsDxe, HttpBootDxe, HttpDxe, Ip4Dxe, Ip6Dxe, MnpDxe, Mtftp4Dxe, Mtftp6Dxe, SnpDxe, TcpDxe, TlsAuthConfigDxe, UefiPxeBcDxe and WifiConnectionManagerDxe. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: abuthahirm

NetworkPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

NetworkPkg: Correct spelling errors and typos

2025-07-04T01:41:47+00:00

Signed-off-by: Abdul Lateef Attar

NetworkPkg: Add PCD for HTTP transfer buffer size

2025-04-29T04:57:14+00:00

Current HTTP transfer size have a default value of 2M. This PCD change allows the platform code to change the transfer buffer size. Based on the network bandwidth, the buffer size can be adjusted to improve performance. Large buffer size provides better performance in high-bandwidth connections. However, small buffer size helps to reduce packet loss in low-bandwidth scenarios. Signed-off-by: Anbazhagan Baraneedharan

NetworkPkg/HttpDxe: Add HTTPS handling in HTTP CONNECT path.

2025-03-13T00:34:01+00:00

1. In EfiHttpRequest(): a) Decision to use HTTPS in HTTP CONNECT is based on Proxy URL. b) Support PUT/POST with no headers when connected to proxy. 2. In HttpConnectTcp4/6(): a) Add new argument to provide new TLS session establishment indication (TlsConfigure). a) Create HTTP connection only when not connected to proxy. b) Do not create new HTTP connection when client is connected to proxy. 3. In HttpInitSession(), pass TlsConfigure to HttpConnectTcp4 calls. 4. In TlsConfigureSession(), when connected to proxy, use recorded endpoint's host name for TLS VerifyHost. Implementation based on UEFI Specification v2.11 section 24.7.10 to use HTTP CONNECT method to connect to Proxy Server and use it to forward the HEAD/GET request to Endpoint Server's BootURI. Signed-off-by: Saloni Kasbekar

NetworkPkg/HttpDxe: Added support for HTTP CONNECT request.

2025-03-13T00:34:01+00:00

1. Store information in HttpInstance. a) Proxy URL from last HTTP CONNECT request (ProxyUrl) and its length (ProxyUrlLen). b) State of connection to proxy server (ProxyConnected) - TRUE after HTTP CONNECT success. c) Host name extracted from endpoint URL (EndPointHostName). 2. Modified EfiHttpRequest() flow to handle HTTP CONNECT request. a) Treating request's URL as "endpoint URL". In case of HTTP CONNECT request, directing it to Proxy URL with Host set to "endpoint URL". 3. Added PrintLib instance to cover AsciiSPrint() call. Implementation based on UEFI Specification v2.11 - Section 24.7.10 to use HTTP CONNECT method to connect to Proxy Server and use it to forward the HEAD/GET request to Endpoint Server's BootURI. - Section 29.6.6 to use EFI_HTTP_CONNECT_REQUEST_DATA structure for HttpMethodConnect usage in EFI_HTTP_PROTOCOL.Request() Signed-off-by: Saloni Kasbekar

Resolved Coverity Issues in Http Dxe

2025-01-28T20:38:38+00:00

1.HttpResponseWorker(DEADCODE) The result of pointer arithmetic "HttpHeaders+AsciiStrLen("HTTP/1.1") + 1" is never null. 2.HttpsSupport.c (NULL_RETURNS) NetbufAlloc might return null pointer ,so assigning "NULL" to "PacketOut" and "DataOut" pointer. Solution: 1.Removed the NULL Check for "StatusCodeStr" 2.Added Null Check for PacketOut and returned EFI_OUT_OF_RESOURCES on NULL case. Signed-off-by: santhosh kumar V

NetworkPkg/HttpDxe: Track HttpInstance URL buffer length.

2024-07-11T21:42:32+00:00

In EfiHttpRequest(), length of target URLs was always compared to fixed-size value, even after allocating a larger URL buffer. Added UrlLen to HTTP_PROTOCOL to store the size and reallocate if the size changes. Signed-off-by: Saloni Kasbekar

NetworkPkg/HttpDxe: Add HttpEventTlsConfigured HTTP callback event

2024-01-10T03:19:31+00:00

Add HttpEventTlsConfigured HTTP callback event and notify callback functions when TlsConfigureSession () returns. Signed-off-by: Abner Chang Cc: Saloni Kasbekar Cc: Zachary Clark-williams Cc: Michael Brown Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Michael Brown Reviewed-by: Saloni Kasbekar