Tianocore/edk2.git/MdePkg/Library/BasePeCoffLib, branch dependabot/github_actions/github/codeql-action-4

MdePkg: Remove ARM32 Support from PE/COFF Libs

2025-09-25T22:04:10+00:00

edk2 is dropping support for the ARM32 architecture. This commit removes ARM32 code from the PE/COFF libs. Signed-off-by: Oliver Smith-Denny

MdePkg/BasePeCoffLib: Remove DEBUG() statements from runtime code

2025-01-29T18:42:13+00:00

PeCoffLoaderRelocateImageForRuntime() executes after boot services, and so it should not use DEBUG() prints at all, given that these may rely on MMIO mappings or other boot time facilities that are no longer available. So revert the changes in aedcaa3df8a2 ("MdePkg: Fix overflow issue in PeCoffLoaderRelocateImageForRuntime") that replaced code comments with DBEUG() statements. Signed-off-by: Ard Biesheuvel

MdePkg: Fix Clang Build Error

2025-01-28T15:04:30+00:00

Fixed Clang build error introduced by unintialized variables in https://github.com/tianocore/edk2/commit/6278bbb89822c598fcd0637ae74174e367895c84 Signed-off-by: Sachin Ganesh

MdePkg: Use SafeIntLib to handle overflow

2025-01-26T17:15:56+00:00

Used SafeIntLib to handle the overflow check in PeCoffLoaderRelocateImage Signed-off-by: Sachin Ganesh

MdePkg: Fix overflow issue in PeCoffLoaderRelocateImageForRuntime

2025-01-26T17:15:56+00:00

RelocDir->Size is a UINT32 value, and RelocDir->VirtualAddress is also a UINT32 value. The current code in PeCoffLoaderRelocateImageForRuntime does not check for overflow when adding RelocDir->Size to RelocDir->VirtualAddress. This patch uses SafeIntLib to ensure that the addition does not overflow. Signed-off-by: Sachin Ganesh

MdePkg: Allows loading X64 and ARM64 OPROM images on LoongArch64

2024-12-12T04:57:03+00:00

Enable foreign images loading on LoongArch64 if the EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL is present. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li Co-Authored-by: Dongyan Qian

MdePkg: CodeQL Fixes.

2024-11-01T04:30:39+00:00

Includes changes across the repo for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com> Signed-off-by: Aaron Pop

MdePkg: Improving readability of CVE patch for PeCoffLoaderRelocateImage

2024-10-02T19:45:12+00:00

This change adds parantheses to the if condition detecting overflow in the PeCoffLoaderRelocateImage function to improve readability. Follow on change for: REF!: https://github.com/tianocore/edk2/pull/6249 Signed-off-by: Doug Flick

MdePkg: Fix overflow issue in BasePeCoffLib

2024-09-30T18:12:30+00:00

The RelocDir->Size is a UINT32 value, and RelocDir->VirtualAddress is also a UINT32 value. The current code does not check for overflow when adding RelocDir->Size to RelocDir->VirtualAddress. This patch adds a check to ensure that the addition does not overflow. Signed-off-by: Doug Flick Authored-by: sriraamx gobichettipalayam

MdePkg/BasePeCoffLib: Deal with broken debug directories

2023-05-05T08:11:22+00:00

Older versions of GenFw put the wrong value in the debug directory size field in the PE/COFF header: instead of putting the combined size of all the entries, it puts the size of the only entry it creates, but adds the size of the NB10 payload that the entry points to. This confuses the loader now that we started using additional debug directory entries to describe DLL characteristics. GenFw was fixed in commit 60e85a39fe49071, but the binaries that were generated with it still need to be supported. So let's detect this condition, and check whether the size of the debug directory is consistent with the NB10 payload: if we should expect additional directory entries where we observe the NB10 payload, the size field is clearly wrong, and we can break from the loop. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4425 Signed-off-by: Ard Biesheuvel Reviewed-by: Liming Gao Tested-by: Liming Gao Acked-by: Michael Kubacki