Tianocore/edk2.git/MdePkg/Include/Base.h, branch dependabot/github_actions/github/codeql-action-4

MdePkg: Remove ARM32 Support from BaseLib

2025-09-25T22:04:10+00:00

edk2 is dropping support for the ARM32 architecture. This commit removes ARM32 code from BaseLib. Signed-off-by: Oliver Smith-Denny

MdePkg/Base: Don't error out on missing compiler CPP macros

2025-01-17T16:39:29+00:00

STATIC_ASSERT is #define'd to a compiler specific value, based on built-in macros exposed by those compilers. If none of those are found, an #error is raised. This breaks the DTCPP build rule, which relies on the C preprocessor for header file inclusion and value substitution, but doesn't define any of the compiler macros we look for. So drop the error case. If STATIC_ASSERT is used without a definition, an error will be raised anyway. Signed-off-by: Ard Biesheuvel

MdePkg/Include: Use _Static_assert for clang and GNUC

2025-01-16T05:33:13+00:00

The clang compiler generates the following error error: use of 'static_assert' without inclusion of This is due to the use of the MSC Extension static_assert. Use _Static_assert instead for clang and GNUC compilers. Signed-off-by: Michael D Kinney

MdePkg: Update BASE_CR macro in Base.h for a Coverity error

2025-01-07T01:28:02+00:00

Coverity is a static analysis tool. It detects the macro as an error (case to incompatible type, cert_exp39_c_violation). The update resolves the error and supports compliance with the static analysis tool. Signed-off-by: Phil Noh

MdePkg:Update Return Error Macro in Base.h

2024-09-03T18:42:10+00:00

Fixing RETURN_ERROR macro. It is causing problem in Coverity Static analysis tool as we are directly converting the UINT value to INTN Changing value from UINT to INTN might cause problem. Here we know that the values would not be in loss of data. To increase the code quality and increase the static tool analysis score we have to change it Cc: Jiangang He Cc: Neo Hsueh Signed-off-by: Parth Thakkar

MdePkg: Check if compiler has __has_builtin before trying to use it

2024-06-20T01:55:03+00:00

When building AArch64 code, cpp gets run with the `-undef` flag which on Fedora 40 with gcc version 14.1.1 20240607 (Red Hat 14.1.1-5) causes __has_builtin to be undefined. When running the check for __builtin_unreachable in Base.h it causes an error "missing binary operator before token "("". Check that we have __has_builtin before trying to use it. Signed-off-by: Rebecca Cran

MdePkg: Add missing status codes

2023-08-07T22:56:02+00:00

REF: https://uefi.org/specs/UEFI/2.10/Apx_D_Status_Codes.html Upon review it has been found that MdePkg is missing two status code definitions: 1. EFI_IP_ADDRESS_CONFLICT - Added in UEFI Spec v2.5 2. EFI_WARN_RESET_REQUIRED - Added in UEFI Spec v2.6 These missing status codes have been added. Reviewed-by: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Nate DeSimone

MdePkg/Base.h: Introduce various alignment-related macros

2023-04-01T23:11:44+00:00

ALIGNOF: Determining the alignment requirement of data types is crucial to ensure safe memory accesses when parsing untrusted data. IS_POW2: Determining whether a value is a power of two is important to verify whether untrusted values are valid alignment values. IS_ALIGNED: In combination with ALIGNOF data offsets can be verified. A more general version of the IS_ALIGNED macro previously defined by several modules. ADDRESS_IS_ALIGNED: Variant of IS_ALIGNED for pointers and addresses. Replaces module-specific definitions throughout the code base. ALIGN_VALUE_ADDEND: The addend to align up can be used to directly determine the required offset for data alignment. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Vitaly Cheptsov Signed-off-by: Marvin Häuser Signed-off-by: Gerd Hoffmann Reviewed-by: Michael D Kinney

MdePkg: Update Base.h to be compliant with C11

2023-03-17T17:55:48+00:00

With the introduction of the use of _Static_assert, edk2 requires a C11 compatible compiler. Update Include/Base.h to be compliant with C11. As of C11, the maximum type of an enum is type `int`. Since the UEFI Specification 2.3.1 Errata C allows either `int` or `unsigned int`, fix the 32-bit enum check to use a signed int. Since the UEFI 2.3 Specification only allowed signed int, update the comment to reference 2.3.1 Errata C where the change was made to allow unsigned int. Signed-off-by: Rebecca Cran Reviewed-by: Michael D Kinney

MdePkg/Include: Update Base.h to improve C++ compatibility

2022-11-11T05:46:51+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4134 * Map NULL to nullptr or __null when c++ compiler is used. * Map STATIC_ASSERT to static_assert when a c++ compiler is used. * Typecast RETURN_SUCCESS to type RETURN_STATUS to match type used by all return error/warning status codes. C++ has stricter type checking and found this inconsistency. Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Michael D Kinney Reviewed-by: Liming Gao