Tianocore/edk2.git/MdeModulePkg/Universal, branch master

MdeModulePkg/SetupBrowserDxe: Fix memory leak in GetQuestionDefault()

2026-09-25T12:42:52+00:00

StrValue is obtained from HiiGetString(), which allocates a new string buffer. The buffer is used to set DefaultValue->Buffer but is never released, causing a memory leak each time this code path is executed. Add FreePool (StrValue) after it is no longer needed. No functional change intended. Signed-off-by: Qihang Gao

MdeModulePkg: Variable: Log Reclaim() completion status

2026-09-21T07:23:22+00:00

Adds a DEBUG_INFO message when Reclaim() finishes so platform boot logs show whether reclaim ran and what status it returned. This makes it easier to distinguish reclaims impact on boot measurements. Signed-off-by: Abdul Lateef Attar

MdeModulePkg: Update UI strings to indicate case-insensitive key options

2026-09-15T03:00:02+00:00

Update the prompt strings for save/exit and confirm actions to show both uppercase and lowercase key options (e.g., 'Y(y)' and 'N(n)') to make it clear that the system accepts either case. This improves user experience by avoiding confusion about case sensitivity. Affected strings: - ARE_YOU_SURE (CustomizedDisplayLib) - CONFIRM_OPTION (DisplayEngineDxe) - RECONNECT_CHANGES_OPTIONS (DisplayEngineDxe) French translations are updated accordingly. Signed-off-by: Qihang Gao

MdeModulePkg/MonotonicCounterRuntimeDxe: Add VarPolicy to the MTC variable

2026-09-03T17:41:04+00:00

Applies a UEFI variable policy to the "MTC" variable to ensure that it is the size of a UINT32 and the variable attributes are restricted to BS, RT, and NV. A protocol dependency on the Variable Policy Protocol is not added to the driver's dependency expression to allow it to be dispatched in firmware that does not have the Variable Policy Protocol installed. Co-authored-by: Michael Kubacki Signed-off-by: Michael Kubacki

MdeModulePkg: Improved error handling in RuntimeDxe Variable drivers

2026-08-31T09:15:32+00:00

Some platforms may disable `ASSERT_DEADLOOP_ENABLED` in `PcdDebugPropertyMask`. In this case ASSERT won't hang the machine. Replaced those simple ASSERT with proper error returning handling. Signed-off-by: Paddy Deng (AMI US Holdings Inc)

MdeModulePkg: Skip deleted vars in PeiVariable index table searches

2026-08-27T13:22:19+00:00

The Variable PEIM's index table optimization search path incorrectly returns deleted variables instead of valid variables when duplicate variables exist with different states. This occurs when: - One variable has deleted state (VAR_IN_DELETED_TRANSITION & VAR_ADDED, value 0x3C) - One variable has valid state (VAR_ADDED, value 0x3F) - Both variables have the same name and GUID The function should prioritize and return the valid variable, but the index table search was returning the first match regardless of state validity. In the FindVariableEx() index table traversal, the function was not properly validating variable states before returning a match. When CompareWithValidVariable() found a matching variable name and GUID, it would return immediately without checking if the variable state was valid (0x3F) or deleted (0x3C). This issue only affects the index table optimization search path and does not impact the linear traversal search path. The Variable PEIM has two main search mechanisms: 1. Linear traversal search - Walks through the entire variable store checking each header sequentially. This path has correct state validation logic and is unaffected by this issue. 2. Index table optimization search - Uses a gEfiVariableIndexTableGuid HOB to quickly jump to variable locations. This optimization is only active when the platform produces this HOB. This is the path affected by the issue. This commit adds explicit state validation in FindVariableEx() to skip variables with deleted state (0x3C). Signed-off-by: Michael Kubacki

MdeModulePkg: Fix missing NULL tests

2026-08-05T05:09:41+00:00

https://github.com/github/codeql/blob/codeql-cli-2.7.3/cpp/ql/src/Critical/MissingNullTest.qhelp For items which allocate memory, or get a pointer from another structure, it is important to validate that the pointers are not null before they are dereferenced. Signed-off-by: Aaron Pop

MdeModulePkg/SmbiosDxe: fix table length check

2026-08-01T04:35:21+00:00

In case EntryPointStructure does not exist yet use a length of zero instead of skipping the check altogether. Fixes a heap overflow in the following code flow in case the first smbios table installed is larger than SMBIOS_TABLE_MAX_LENGTH. Signed-off-by: Gerd Hoffmann

MdeModulePkg/HiiDatabaseDxe: Fix potential intrinsic error

2026-07-31T01:16:29+00:00

In some VS22 versions, these code patterns (assiging the scalar in a loop) have been found to be converted into calls to the `memcpy` intrinsic. This change updates them to use CopyMem to avoid the potential error. Previous: - MSVC version: 14.31.31103 New: - MSVC version: 14.32.31326 Signed-off-by: Michael Kubacki

MdeModulePkg/PartitionDxe: Abort on primary GPT recovery failure

2026-07-20T21:50:57+00:00

When the primary GPT is invalid, PartitionInstallGptChildHandles() restores it from the backup and re-validates it. Both the restore write and the re-validation can fail (e.g. write-protected media, or a backup AlternateLBA pointing beyond the device), yet the existing code only logs the failure and parses partitions from a known-invalid PrimaryHeader. Abort GPT processing when either the restore or the validation fails, so partitions are only ever parsed from a validated primary GPT. The backup recovery branch is left unchanged, as the primary is already validated. A device with an unrecoverable primary GPT now installs no child handles instead of using an invalid header. This keeps the table PartitionDxe uses in sync with the one DxeTpm2MeasureBootLib measures into PCR[5]. Ref: https://seclists.org/oss-sec/2026/q2/727 Signed-off-by: Richard Lyu