Tianocore/edk2.git/MdeModulePkg/Universal, branch dependabot/github_actions/actions/github-script-9

MdePkg,MdeModulePkg: Fix Spelling Error in Udf Definitions

2026-05-08T02:15:34+00:00

Fix spelling error in definition in Udf.h. Update consumer in MdeModulePkg. A temporary backward-compatible alias is provided for the old misspelled enum name. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Oliver Smith-Denny

MdeModulePkg: Cleanup debug print readability

2026-05-06T10:43:05+00:00

All debug prints should end in a newline character. Signed-off-by: Benjamin Doron

MdeModulePkg: VariableSmmRuntimeDxe: Fix MM communicate v3 buffer sizing

2026-03-25T17:47:59+00:00

This change updates `VariableSmmRuntimeDxe` to correctly size its runtime communication buffer when `EFI_MM_COMMUNICATION3_PROTOCOL` is present. In the current flow, the runtime variable path may use MM communication v3, but the input size is first validated against the global variable `mVariableBufferPayloadSize`. The size is then validated a second time during communication buffer initialization using the v3 header size, which results in `GetVariable` calls with sufficiently large buffers consistently failing. This update makes the allocation logic v3‑aware so that the runtime variable communication buffer matches the header format actually in use, avoiding failures for larger variable transactions. Signed-off-by: Kun Qin

MdeModulePkg: : revert EndofDxeEvent TPLs to TPL_NOTIFY for FPDT

2026-03-19T03:39:15+00:00

commit aa02571 ("MdeModulePkg: Change EndofDxeEvent TPLs to TPL_CALLBACK") changed EndOfDxeEvent TPLs from TPL_NOFIY to TPL_CALLBACK. However this commit makes a boot failure on the FVP platform when FPDT ACPI table generation is enabled: [FirmwarePerformanceDxe] Error when lock variable FirmwarePerformance, Status = Write Protected ASSERT_EFI_ERROR (Status = Write Protected) ASSERT [FirmwarePerformanceDxe] FirmwarePerformanceDxe.c(405): !(((RETURN_STATUS)(Status)) >= 0x8000000000000000ULL) Currently, EVT_NOTIFY_SIGNAL events are managed in FILO order, as new events are inserted using InsertHeadList(). The sequence is as follows: 1. DxeCore initializes DxeCorePerformanceLib, whose constructor creates an EndOfDxe event (gEfiEndOfDxeEventGroupGuid) with the ReportFpdtRecordBuffer() callback. 2. MmCommunicationDxe (in ArmPkg) creates another EndOfDxe event to notify StandaloneMm. This event is inserted ahead of the one created in (1). 3. PlatformBootManagerBeforeConsole() signals EndOfDxe, which triggers the event created in (2) first. 4. When the callback from (2) runs, StandaloneMm calls LockVariablePolicy(). 5. The callback from (1) is then invoked and attempts to update FPDT via InstallFirmwarePerformanceDataTable(). During this process, it tries to register a variable policy for the FirmwarePerformance variable. However, since the Variable Policy interface was locked in (4), the operation fails with EFI_WRITE_PROTECTED. To resolve this issue, revert EndofDxeEvent TPLs to TPL_NOTIFY for FPDT. Fixes: aa02571 ("MdeModulePkg: Change EndofDxeEvent TPLs to TPL_CALLBACK") Signed-off-by: Yeoreum Yun

MdeModulePkg: Change EndofDxeEvent TPLs to TPL_CALLBACK

2026-03-17T02:38:07+00:00

Change FPDT events at EndOfDxe to TPL_CALLBACK as TPL_NOTIFY is not necessary. Signed-off-by: Sherry Fan

MdeModulePkg/TerminalDxe: Fix Backspace key for VT-UTF8 terminal type

2026-02-28T04:43:49+00:00

When QEMU is launched with -nographic, the Backspace key (DEL, 0x7f) doesn't work in the UEFI Shell because the VT-UTF8 terminal type interprets DEL as SCAN_DELETE instead of CHAR_BACKSPACE. Modern terminal emulators (xterm, gnome-terminal, etc.) send DEL (0x7f) for Backspace and are UTF-8 compatible. This patch updates TerminalTypeVtUtf8 to interpret DEL as CHAR_BACKSPACE, consistent with how TerminalTypeTtyTerm already handles it. This approach preserves VT-UTF8 as the default terminal type (which supports full Unicode), while fixing the Backspace functionality for modern terminal environments. Signed-off-by: Damien Chen

MdeModulePkg: Fix PreferMode selection for same-width text modes

2026-02-28T03:35:35+00:00

The current PreferMode selection logic requires both Columns AND Rows to be strictly greater (>) than the current maximum, which fails when a text mode has the same column count but more rows. Example failure case (1920x1200 display): - Mode 5: 240x56 - Selected as PreferMode - Mode 6: 240x63 - Rejected because 240 is not > 240 This mismatch causes ConsplitterSetConsoleOutMode to later request Mode 6, triggering an unnecessary text mode change and clearing the screen during console init. Root Cause: GraphicsConsole used: if ((Col > Max) && (Row > Max)) This fails when only rows increase while columns stay the same. Solution: Change to: if ((Col >= Max) && (Row >= Max)) This aligns with ConSplitter mode selection logic and correctly selects the mode with the highest column and row counts. After fix (1920x1200 display): - Mode 5: 240x56 - Mode 6: 240x63 - Correctly selected as PreferMode This ensures GraphicsConsole and ConSplitter match on the preferred mode preventing unnecessary screen clears during console initialization. Signed-off-by: Ashraf Ali S

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg/HiiDatabaseDxe: Fix parser issue in GetNameElement()

2026-02-10T01:31:21+00:00

This commit removes an wrong goto statement which may cause DXE_ASSERT! `ConfigRequest` example: `&NameValueVar0&NameValueVar1&NameValueVar2`. When `*Progress` is `&NameValueVar2`, code will run to `goto Done;`, then return NULL. Signed-off-by: Yang Gang

MdeModulePkg: MmVariablePei: Populate correct v3 header

2026-02-03T21:56:48+00:00

When using MM communicate v3 to fetch variable, the header calculation was incorrect, causing the variable driver on the secure environment to have random behavior. This change refactored the original routine by following the current DXE instance (mostly). Signed-off-by: Kun Qin