Tianocore/edk2.git/MdeModulePkg/Universal/Variable, branch master

MdeModulePkg: Variable: Log Reclaim() completion status

2026-09-21T07:23:22+00:00

Adds a DEBUG_INFO message when Reclaim() finishes so platform boot logs show whether reclaim ran and what status it returned. This makes it easier to distinguish reclaims impact on boot measurements. Signed-off-by: Abdul Lateef Attar

MdeModulePkg: Improved error handling in RuntimeDxe Variable drivers

2026-08-31T09:15:32+00:00

Some platforms may disable `ASSERT_DEADLOOP_ENABLED` in `PcdDebugPropertyMask`. In this case ASSERT won't hang the machine. Replaced those simple ASSERT with proper error returning handling. Signed-off-by: Paddy Deng (AMI US Holdings Inc)

MdeModulePkg: Skip deleted vars in PeiVariable index table searches

2026-08-27T13:22:19+00:00

The Variable PEIM's index table optimization search path incorrectly returns deleted variables instead of valid variables when duplicate variables exist with different states. This occurs when: - One variable has deleted state (VAR_IN_DELETED_TRANSITION & VAR_ADDED, value 0x3C) - One variable has valid state (VAR_ADDED, value 0x3F) - Both variables have the same name and GUID The function should prioritize and return the valid variable, but the index table search was returning the first match regardless of state validity. In the FindVariableEx() index table traversal, the function was not properly validating variable states before returning a match. When CompareWithValidVariable() found a matching variable name and GUID, it would return immediately without checking if the variable state was valid (0x3F) or deleted (0x3C). This issue only affects the index table optimization search path and does not impact the linear traversal search path. The Variable PEIM has two main search mechanisms: 1. Linear traversal search - Walks through the entire variable store checking each header sequentially. This path has correct state validation logic and is unaffected by this issue. 2. Index table optimization search - Uses a gEfiVariableIndexTableGuid HOB to quickly jump to variable locations. This optimization is only active when the platform produces this HOB. This is the path affected by the issue. This commit adds explicit state validation in FindVariableEx() to skip variables with deleted state (0x3C). Signed-off-by: Michael Kubacki

MdeModulePkg/Variable: Avoid double VA conversion of FVB protocol

2026-06-01T06:05:19+00:00

For historical reasons, VariableRuntimeDxe performs virtual address conversion on the FVB protocol member pointers of the protocol instance that backs the EFI variable store. However, the driver that produces the actual instance should be doing this, as it is the owner and provides the actual implementation of those methods. Unfortunately, we cannot simply remove this: existing FVB drivers may rely on the Variable driver performing the conversion on their behalf. So the Variable driver should convert the pointers only when the FVB producer has not already done so. The SetVirtualAddressMap event can be delivered in arbitrary order, so we cannot rely on whether this driver converts its pointers before or after the FVB protocol owner receives the event. Fix this by recording the converted addresses in a shadow FVB protocol rather than converting the live pointers directly. On the first runtime variable access, check whether the FVB producer has performed its own conversion; if not, swap in the shadow copy's converted pointers. Without this fix, platforms where the FVB producer performs its own SetVirtualAddressMap conversion (e.g., OP-TEE StandaloneMm-backed EepromFvb on NXP LX2160A) suffer double pointer conversion, causing runtime variable access to crash. Signed-off-by: Ard Biesheuvel Tested-by: Liz Fong-Jones Cc: Liming Gao

MdeModulePkg: VariableSmmRuntimeDxe: Fix MM communicate v3 buffer sizing

2026-03-25T17:47:59+00:00

This change updates `VariableSmmRuntimeDxe` to correctly size its runtime communication buffer when `EFI_MM_COMMUNICATION3_PROTOCOL` is present. In the current flow, the runtime variable path may use MM communication v3, but the input size is first validated against the global variable `mVariableBufferPayloadSize`. The size is then validated a second time during communication buffer initialization using the v3 header size, which results in `GetVariable` calls with sufficiently large buffers consistently failing. This update makes the allocation logic v3‑aware so that the runtime variable communication buffer matches the header format actually in use, avoiding failures for larger variable transactions. Signed-off-by: Kun Qin

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg: MmVariablePei: Populate correct v3 header

2026-02-03T21:56:48+00:00

When using MM communicate v3 to fetch variable, the header calculation was incorrect, causing the variable driver on the secure environment to have random behavior. This change refactored the original routine by following the current DXE instance (mostly). Signed-off-by: Kun Qin

MdeModulePkg: Fix unchecked return status.

2025-11-23T00:23:22+00:00

https://github.com/github/codeql/blob/codeql-cli-2.7.3/csharp/ql/src/API%20Abuse/UncheckedReturnValue.qhelp When a function has a return status, it should be checked to verify the function completed successfully. Failing to check the return status can result in null pointer dereferences or use of uninitialized variables. Signed-off-by: Aaron Pop

MdeModulePkg: fix various typos

2025-11-21T21:49:59+00:00

Signed-off-by: Philipp Schuster

MdeModulePkg: Remove ARM32 Support

2025-09-25T22:04:10+00:00

edk2 is dropping support for the ARM32 architecture. This commit removes ARM32 support from MdeModulePkg. This also drops irrelevant VALID_ARCHITECTURE comments from infs that are not arch specific. Signed-off-by: Oliver Smith-Denny