Tianocore/edk2.git/MdeModulePkg/Universal/SetupBrowserDxe, branch dependabot/github_actions/github/codeql-action-4

MdeModulePkg: Fix EFI_SUCCESS typos

2025-06-12T17:50:45+00:00

EFI_SUCESS -> EFI_SUCCESS EFI_SUCESSS -> EFI_SUCCESS Signed-off-by: Gao Qihang

MdeModulePkg/SetupBrowserDxe: EFI_BROWSER_ACTION_REQUEST_QUESTION_APPLY

2024-01-24T15:57:35+00:00

REF: UEFI_Spec_2_10_Aug29.pdf page 1695. In 35.5.4 EFI_HII_CONFIG_ACCESS_PROTOCOL.CallBack(): If the callback function returns with the ActionRequest set to _QUESTION_APPLY, then the Forms Browser will write the current modified question value on the selected form to storage. Update the SetupBrowserDxe, if callback function return EFI_BROWSER_ACTION_REQUEST_QUESTION_APPLY, then call SetQuestionValue with GetSetValueWithHiiDriver to apply the change immediately. Signed-off-by: Ming Tan Cc: Liming Gao Cc: Dandan Bi Reviewed-by: Dandan Bi Reviewed-by: Liming Gao

MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-03T12:12:27+00:00

For EfiVarStore (EFI_HII_VARSTORE_EFI_VARIABLE_BUFFER), it will call ExtractConfig-GetVariable-HiiBlockToConfig-ConfigToBlock when load storage value in LoadStorage function. It's not necessary and costs lots of time to do the conversion between config and block. So now enhance it to call GetVariable directly. Cc: Liming Gao Cc: Eric Dong Signed-off-by: Dandan Bi Reviewed-by: Liming Gao Reviewed-by: Eric Dong

MdeModulePkg/SetupBrowserDxe:Follow spec'd way to reconnect driver

2022-07-22T06:19:53+00:00

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3952 In UEFI spec, it defines reconnect timing that will be activated upon exiting of the formset or the browser. However, we did't use this kind of way to check reconnect conditioncode. Code only blocks reconnect if page is updated dynamically. That's not matched spec'd way. We should check current formset whether is exiting, then reconnect driver. Signed-off-by: Walon Li Reviewed-by: Liming Gao

MdeModulePkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the MdeModulePkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao

MdeModulePkg: Change OPTIONAL keyword usage style

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3760 Update all use of ', OPTIONAL' to ' OPTIONAL,' for function params. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael Kubacki Signed-off-by: Michael D Kinney Reviewed-by: Liming Gao

MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update

2020-06-10T04:25:47+00:00

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2701 Recording to the spec, the reconnect is activated upon exiting of the formset or the browser. Exiting is by user but form-browser internal logic. That means the reconnection is only happened when user press ESC or _EXIT action to exit form. Driver callback may update HII form dynamically so form-browser needs to refresh its internal data. It's not exiting formset for user exactly and they didn't know what happened. So use a flag to record that and do not reconnect driver if updated by callback. Signed-off-by: Walon Li Reviewed-by: Dandan Bi

MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

2020-03-12T05:20:12+00:00

From the function description of GetIfrBinaryData(), FormSetGuid can be NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes exception when FormSetGuid is NULL. Signed-off-by: Nickle Wang Reviewed-by: Dandan Bi

MdeModulePkg/Setup: Update opcode number variable type to UINTN

2020-01-15T00:48:32+00:00

Update data type of variables which save the opcode numbers to UINTN, in case some configuration module has lots of configuration items. Cc: Liming Gao Cc: Eric Dong Signed-off-by: Brian R Haug Reviewed-by: Dandan Bi Reviewed-by: Liming Gao Reviewed-by: Laszlo Ersek Reviewed-by: Eric Dong

MdeModulePkg/SetupBrowserDxe: ASSERT GetBufferForValue(&Value)

2019-11-06T05:26:21+00:00

Before called by GetBufferForValue(), Value has already been called function IsTypeInBuffer to make sure the value must be buffer type. So GetBufferForValue can not return NULL. This commit adds ASSERT to assume (GetBufferForValue (&Value) is not NULL. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang Reviewed-by: Dandan Bi