Tianocore/edk2.git/MdeModulePkg/Universal/DisplayEngineDxe, branch dependabot/github_actions/actions/github-script-9

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg/DisplayEngineDxe: fix gcc 16 warning

2026-02-01T20:30:31+00:00

MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c: In function ‘CreateSharedPopUp’: MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c:590:11: error: variable ‘Count’ set but not used [-Werror=unused-but-set-variable=] 590 | UINTN Count; | ^~~~~ Signed-off-by: Gerd Hoffmann

MdeModulePkg: Fix regressions from 11687, 11689.

2025-12-19T06:48:19+00:00

11687 introduced a null check and break on the orderedlist carriage return input handler. The carriage return is a special case that should result in exiting the menu, but the null check that prevented null pointer access changed the logic to continue in the input wait loop. Removed the break while still preventing null variable access and allow function to exit. 11689 introduced checks on the call to EfiBootManagerGetLoadOptions, but this encounterd a problem with the way that a default platform recovery option was created. The default platform recovery option was attempting to go through existing recovery options to get the next available recovery option number. The introduced null check short circuited these additional calls and resulted in the platform recovery option not being created. Modified the logic to no longer attempt to access recovery options when non exist, and still create the default platform recovery option. Signed-off-by: Aaron Pop

MdeModulePkg: Fix regressions from 11686, 11687, 11688, 11689.

2025-12-06T09:54:37+00:00

11686, 11687, 11688, 11689 included some inverted conditionals during the refactor. While the system booted, some behavior was incorrect based on the inverted conditionals. Signed-off-by: Aaron Pop

MdeModulePkg: Fix missing NULL tests.

2025-11-22T21:15:22+00:00

https://github.com/github/codeql/blob/codeql-cli-2.7.3/cpp/ql/src/Critical/MissingNullTest.qhelp For items which allocate memory, or get a pointer from another structure, it is important to validate that the pointers are not null before they are dereferenced. Signed-off-by: Aaron Pop

MdeModulePkg/Universal/DisplayEngineDxe: Fix GCCNOLTO error

2025-09-19T02:50:26+00:00

Fix potentially uninitialized local variable Index. Signed-off-by: Michael D Kinney

MdeModulePkg: Fix EFI_SUCCESS typos

2025-06-12T17:50:45+00:00

EFI_SUCESS -> EFI_SUCCESS EFI_SUCESSS -> EFI_SUCCESS Signed-off-by: Gao Qihang

MdeModulePkg: Prevent memcpy intrinsics in VS22 (17.14.2)

2025-06-08T18:07:56+00:00

The latest VS2022 update replaces some code patterns with struct assignments with `memcpy`. This change convert the code to explicitly use `CopyMem`. Signed-off-by: Michael Kubacki

DisplayEngineDxe: Fix length when displaying menu string

2025-04-25T03:31:33+00:00

Function `PrintStringAt` returns the count of Unicode character, which is not correct for computing column offset when display empty string if wide character is introduced. `GetStringWidth (String) / 2 - 1` is suitable option which is compatible with wide and narrow characters. Cc: Lichao Cc: Qian Dongyan Signed-off-by: Gao Qihang

MdeModulePkg/DisplayEngineDxe:Fix typos in comments.

2025-04-10T15:40:00+00:00

opton -> option attribut -> attribute mwnu -> menu highlith/hilight -> highlight repain -> repaint Signed-off-by: Gao Qihang