EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Fgithub%2Fcodeql-action-4 2025-10-09T08:02:51+00:00 2025-10-09T08:02:51+00:00 nick.wang nick.wang@insyde.com 2025-04-15T11:35:46+00:00 urn:sha1:0cad130cb4885961da201bb9b08424b3fd3d2249 There is a possibility to retrieve user input keystroke data stored in the queue buffer via the EFI_SIMPLE_TEXT_INPUT_PROTOCOL pointer. To prevent exposure of the password string, clear the queue buffer by filling it with zeros after reading. Signed-off-by: Nick Wang <nick.wang@insyde.com> 2025-09-23T01:02:47+00:00 Gao Qihang gaoqihang@loongson.cn 2025-08-27T06:48:24+00:00 urn:sha1:ba41bd096af6fc1c7ad61f32359014bac85540ef Adjust AnsiTestString to be compatible with wide/narrow string in TerminalDxe driver. If WIDE_CHAR or NARROW_CHAR is hit, the string is still valid since OutputString function will correctly handle it. Signed-off-by: Gao Qihang <gaoqihang@loongson.cn> 2025-09-23T01:02:47+00:00 Gao Qihang gaoqihang@loongson.cn 2025-07-21T03:12:04+00:00 urn:sha1:0053bbf833bb1612813a4af2ee653cd8b0ba4e19 Add four newly added terminal types in TerminalConOutTestString, although this function is rarely used. This patch is a supplement to previous patch https://github.com/tianocore/edk2/commit/8a53ea9d9f40aad5504dc6080978a30b1b89ff3e. Signed-off-by: Gao Qihang <gaoqihang@loongson.cn> 2025-09-01T05:53:59+00:00 Jack Little jack.tay.little@hpe.com 2025-07-14T20:42:49+00:00 urn:sha1:aeea04341cd12d237fe90e7ed9ebd1cfe7764dab Commit 9224a2b91764ab17b2c1dbc9fdcb012eaed62da6 adds support for larger terminal dimensions; however, the ANSI control sequences to manipulate the terminal cursor are not built to accomodate terminal dimensions that are three digits long. For example, suppose we want to move the cursor 163 columns to the right. The required control sequence would be `^[[163C`; however, the existing code will create a control sequence of `^[[@3C` due to trying to add 16 to the character '0' instead of either 1 or 6. This fix adds a third digit to the sequence templates for moving the cursor forward, moving it backwards, and setting the cursor position. Signed-off-by: Jack Little <jack.tay.little@hpe.com> 2025-08-22T10:32:40+00:00 Gao Qihang gaoqihang@loongson.cn 2025-08-01T08:26:19+00:00 urn:sha1:0e1e079f4c5081da6b3b43f9dfc45932299ebb91 Fix TestString() to be compatible with wide/narrow string in GraphicsConsole driver. If WIDE_CHAR or NARROW_CHAR is hit in TestString function, ignore it since OutputString function will correctly handle it. Fix OutputString() to skip wide/narrow char in TerminalDxe. Because they are not displayable in terminal emulation tool, ingore to output if they are hit in OutputString function. Signed-off-by: Gao Qihang <gaoqihang@loongson.cn> 2025-07-17T17:45:48+00:00 Michael Kubacki michael.kubacki@microsoft.com 2025-05-12T17:55:53+00:00 urn:sha1:8be9a344d35316fb0ee70a33779a7a931fcb8a1d Running Codeql on MdeModulePkg/Universal/Console drivers results in codeql errors stemming for the following checks. - cpp/comparison-with-wider-type - cpp/missing-null-test Signed-off-by: Aaron Pop <aaronpop@microsoft.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Co-authored-by: Taylor Beebe <tabeebe@microsoft.com> Co-authored-by: pohanch <125842322+pohanch@users.noreply.github.com> Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com> Co-authored-by: Oliver Smith-Denny <osde@linux.microsoft.com> Co-authored-by: Sean Brogan <sean.brogan@microsoft.com> Co-authored-by: Aaron <aaronpop@microsoft> 2025-07-08T15:42:03+00:00 GuoMinJ newexplorerj@gmail.com 2025-06-16T08:39:47+00:00 urn:sha1:4315b1922e386b507ff525a39d97ca4f12d070fc The Universal Graphics Adapter (UGA) is a graphic abstraction. The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was introduced. Cf. the UEFI spec v2.9: "Appendix L - EFI 1.10 Protocol Changes and Deprecation List" section L.2 "Deprecated Protocols" Remove the UGA support. Signed-off-by: GuoMinJ <newexplorerj@gmail.com> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-07-08T15:42:03+00:00 GuoMinJ newexplorerj@gmail.com 2025-06-16T08:50:47+00:00 urn:sha1:ecaca1652d955ba8aad2f0d9cece47196bcc11b8 The Universal Graphics Adapter (UGA) is a graphic abstraction. The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was introduced. Cf. the UEFI spec v2.9: "Appendix L - EFI 1.10 Protocol Changes and Deprecation List" section L.2 "Deprecated Protocols" Remove the UGA support. Signed-off-by: GuoMinJ <newexplorerj@gmail.com> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> 2025-03-03T01:45:48+00:00 Phil Noh Phil.Noh@amd.com 2025-02-18T20:40:18+00:00 urn:sha1:9224a2b91764ab17b2c1dbc9fdcb012eaed62da6 When the terminal driver is active, currently terminals available through SetMode function are limited to mode 0 (80x25) despite multiple modes are configured as MaxMode value (e.g. 3 modes in mTerminalConsoleModeData list). Improve the function to support multiple modes based on the value. Additionally add more modes that match with the GraphicsConsoleDxe driver. This update is expected to help the symptom that the Setup or Shell screen becomes smaller due to the text mode. Signed-off-by: Phil Noh <Phil.Noh@amd.com> 2024-10-28T04:18:53+00:00 Hua Ma hua.ma@intel.com 2024-10-22T02:57:06+00:00 urn:sha1:1a3d4b33b6f1ff9a1d66e4bdf110f751ec5f9318 Some serial device may not support SetControl. Ignore the error from SetControl if EFI_UNSUPPORTED is return. Signed-off-by: Hua Ma <hua.ma@intel.com>