Tianocore/edk2.git/MdeModulePkg/Universal/Console, branch dependabot/github_actions/actions/github-script-9

MdeModulePkg/TerminalDxe: Fix Backspace key for VT-UTF8 terminal type

2026-02-28T04:43:49+00:00

When QEMU is launched with -nographic, the Backspace key (DEL, 0x7f) doesn't work in the UEFI Shell because the VT-UTF8 terminal type interprets DEL as SCAN_DELETE instead of CHAR_BACKSPACE. Modern terminal emulators (xterm, gnome-terminal, etc.) send DEL (0x7f) for Backspace and are UTF-8 compatible. This patch updates TerminalTypeVtUtf8 to interpret DEL as CHAR_BACKSPACE, consistent with how TerminalTypeTtyTerm already handles it. This approach preserves VT-UTF8 as the default terminal type (which supports full Unicode), while fixing the Backspace functionality for modern terminal environments. Signed-off-by: Damien Chen

MdeModulePkg: Fix PreferMode selection for same-width text modes

2026-02-28T03:35:35+00:00

The current PreferMode selection logic requires both Columns AND Rows to be strictly greater (>) than the current maximum, which fails when a text mode has the same column count but more rows. Example failure case (1920x1200 display): - Mode 5: 240x56 - Selected as PreferMode - Mode 6: 240x63 - Rejected because 240 is not > 240 This mismatch causes ConsplitterSetConsoleOutMode to later request Mode 6, triggering an unnecessary text mode change and clearing the screen during console init. Root Cause: GraphicsConsole used: if ((Col > Max) && (Row > Max)) This fails when only rows increase while columns stay the same. Solution: Change to: if ((Col >= Max) && (Row >= Max)) This aligns with ConSplitter mode selection logic and correctly selects the mode with the highest column and row counts. After fix (1920x1200 display): - Mode 5: 240x56 - Mode 6: 240x63 - Correctly selected as PreferMode This ensures GraphicsConsole and ConSplitter match on the preferred mode preventing unnecessary screen clears during console initialization. Signed-off-by: Ashraf Ali S

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg: Remove extraneous parentheses

2025-11-22T01:43:26+00:00

XCODE5 toolchain finds these, with errors such as: PxeFunction.c:763:27: error: equality comparison with extraneous parentheses Signed-off-by: Mike Beaton

MdeModulePkg : Clear keyboard queue buffer after reading

2025-10-09T08:02:51+00:00

There is a possibility to retrieve user input keystroke data stored in the queue buffer via the EFI_SIMPLE_TEXT_INPUT_PROTOCOL pointer. To prevent exposure of the password string, clear the queue buffer by filling it with zeros after reading. Signed-off-by: Nick Wang

MdeModulePkg/TerminalDxe: Improve the implementation of AnsiTestString

2025-09-23T01:02:47+00:00

Adjust AnsiTestString to be compatible with wide/narrow string in TerminalDxe driver. If WIDE_CHAR or NARROW_CHAR is hit, the string is still valid since OutputString function will correctly handle it. Signed-off-by: Gao Qihang

MdeModulePkg/TerminalDxe: Add missing types for TestString function

2025-09-23T01:02:47+00:00

Add four newly added terminal types in TerminalConOutTestString, although this function is rarely used. This patch is a supplement to previous patch https://github.com/tianocore/edk2/commit/8a53ea9d9f40aad5504dc6080978a30b1b89ff3e. Signed-off-by: Gao Qihang

MdeModulePkg: Fix malformed terminal control sequences

2025-09-01T05:53:59+00:00

Commit 9224a2b91764ab17b2c1dbc9fdcb012eaed62da6 adds support for larger terminal dimensions; however, the ANSI control sequences to manipulate the terminal cursor are not built to accomodate terminal dimensions that are three digits long. For example, suppose we want to move the cursor 163 columns to the right. The required control sequence would be `^[[163C`; however, the existing code will create a control sequence of `^[[@3C` due to trying to add 16 to the character '0' instead of either 1 or 6. This fix adds a third digit to the sequence templates for moving the cursor forward, moving it backwards, and setting the cursor position. Signed-off-by: Jack Little

MdeModulePkg: Improve the implementation of EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL

2025-08-22T10:32:40+00:00

Fix TestString() to be compatible with wide/narrow string in GraphicsConsole driver. If WIDE_CHAR or NARROW_CHAR is hit in TestString function, ignore it since OutputString function will correctly handle it. Fix OutputString() to skip wide/narrow char in TerminalDxe. Because they are not displayable in terminal emulation tool, ingore to output if they are hit in OutputString function. Signed-off-by: Gao Qihang

MdeModulePkg: Console cumulative codeql issues.

2025-07-17T17:45:48+00:00

Running Codeql on MdeModulePkg/Universal/Console drivers results in codeql errors stemming for the following checks. - cpp/comparison-with-wider-type - cpp/missing-null-test Signed-off-by: Aaron Pop Co-authored-by: Michael Kubacki Co-authored-by: Taylor Beebe Co-authored-by: pohanch <125842322+pohanch@users.noreply.github.com> Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com> Co-authored-by: Oliver Smith-Denny Co-authored-by: Sean Brogan Co-authored-by: Aaron