Tianocore/edk2.git/MdeModulePkg/Universal/Acpi, branch dependabot/github_actions/actions/github-script-9

MdeModulePkg: : revert EndofDxeEvent TPLs to TPL_NOTIFY for FPDT

2026-03-19T03:39:15+00:00

commit aa02571 ("MdeModulePkg: Change EndofDxeEvent TPLs to TPL_CALLBACK") changed EndOfDxeEvent TPLs from TPL_NOFIY to TPL_CALLBACK. However this commit makes a boot failure on the FVP platform when FPDT ACPI table generation is enabled: [FirmwarePerformanceDxe] Error when lock variable FirmwarePerformance, Status = Write Protected ASSERT_EFI_ERROR (Status = Write Protected) ASSERT [FirmwarePerformanceDxe] FirmwarePerformanceDxe.c(405): !(((RETURN_STATUS)(Status)) >= 0x8000000000000000ULL) Currently, EVT_NOTIFY_SIGNAL events are managed in FILO order, as new events are inserted using InsertHeadList(). The sequence is as follows: 1. DxeCore initializes DxeCorePerformanceLib, whose constructor creates an EndOfDxe event (gEfiEndOfDxeEventGroupGuid) with the ReportFpdtRecordBuffer() callback. 2. MmCommunicationDxe (in ArmPkg) creates another EndOfDxe event to notify StandaloneMm. This event is inserted ahead of the one created in (1). 3. PlatformBootManagerBeforeConsole() signals EndOfDxe, which triggers the event created in (2) first. 4. When the callback from (2) runs, StandaloneMm calls LockVariablePolicy(). 5. The callback from (1) is then invoked and attempts to update FPDT via InstallFirmwarePerformanceDataTable(). During this process, it tries to register a variable policy for the FirmwarePerformance variable. However, since the Variable Policy interface was locked in (4), the operation fails with EFI_WRITE_PROTECTED. To resolve this issue, revert EndofDxeEvent TPLs to TPL_NOTIFY for FPDT. Fixes: aa02571 ("MdeModulePkg: Change EndofDxeEvent TPLs to TPL_CALLBACK") Signed-off-by: Yeoreum Yun

MdeModulePkg: Change EndofDxeEvent TPLs to TPL_CALLBACK

2026-03-17T02:38:07+00:00

Change FPDT events at EndOfDxe to TPL_CALLBACK as TPL_NOTIFY is not necessary. Signed-off-by: Sherry Fan

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg/AcpiTableDxe:Created EfiACPIReclaimMemory for ACPIHOB RSDP

2026-01-19T09:55:23+00:00

The RSDP table come from ACPI HOB which may no store in the EfiACPIReclaimMemory-type memory. Therefore need to reserve an EfiACPIReclaimMemory-type memory for it. Signed-off-by: George Liao

MdeModulePkg: Acpi cumulative codeql issues.

2025-11-24T00:41:30+00:00

Running Codeql on MdeModulePkg/Universal/Acpi drivers results in codeql errors stemming from missing null tests. Signed-off-by: Aaron Pop Co-authored-by: Michael Kubacki Co-authored-by: Taylor Beebe Co-authored-by: pohanch <125842322+pohanch@users.noreply.github.com> Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com> Co-authored-by: Oliver Smith-Denny Co-authored-by: Sean Brogan Co-authored-by: Aaron

MdeModulePkg/AcpiTableDxe: Fixed exception when enable SpecialPool

2025-11-23T11:40:49+00:00

In some corner cases the NeedToInstallTable not been initialized well in the InstallAcpiTableFromAcpiSiliconHob, which caused exception when enable special pool function. This patch fixed exception by initialize NeedToInstallTable well. Signed-off-by: George Liao

MdeModulePkg/AcpiTableDxe:Improving InitializeAcpiTableDxe behavior.

2025-10-21T11:46:17+00:00

Improving InitializeAcpiTableDxe() behavior. Signed-off-by: George Liao

MdeModulePkg:Completed InstallAcpiTableFromAcpiSiliconHob AddTableList

2025-10-21T11:46:17+00:00

Added "PublishTables()" and "SdtNotifyAcpiList()" for completing AddTableToList behavior in the InstallAcpiTableFromAcpiSiliconHob(). Signed-off-by: George Liao

MdeModulePkg/AcpiTableDxe:Fixed memory corruption issue

2025-10-21T11:46:17+00:00

Clearing wrong memory content after allocated memory for XSDT, which caused AcpiSdtProtocol cannot be installed and unexpected behavior. According to the UEFI spec and commit message of "PCD switch to avoid using ACPI reclaim memory", so need to add this support in the InstallAcpiTableFromAcpiSiliconHob(). 1. Fixed memory corruption issue in the InstallAcpiTableFromAcpiSiliconHob(). 2. Added "PCD switch to avoid using ACPI reclaim memory" support in the InstallAcpiTableFromAcpiSiliconHob(). Signed-off-by: George Liao

MdeModulePkg/AcpiTableDxe: Add function for extract ACPI table from HOB.

2025-05-02T09:35:02+00:00

1. Got RSDP table which installed during the FSP phase from Hob, then pass it to the DXE AcpiTableInstance. 2. Got XSDT from RSDP and extract necessary data from XSDT, according to the old XSDT to Initialize a new XSDT. 3. Re-install ACPI table from old XSDT to the new XSDT. a. If Hob has DSDT table then re-install DSDT table in the new XSDT. If not, then skip it. b. If Hob has FACS table then re-install FACS table in the new XSDT. If not, then skip it. Signed-off-by: George Liao