Tianocore/edk2.git/MdeModulePkg/Library, branch trunk

Renormalized end-of-lines from master@27b044605cd5f6b33a3d231576003850b3fe305b

2024-06-04T03:43:08+00:00

MdeModulePkg:BaseSpiHcPlatformLib: Adding NULL lib instance

2024-05-08T04:43:58+00:00

Adding NULL SpiHcPlatformLib instance. This library is responsible for handling the low level details of the SPI host controller. Since this is platform specific this library will be dependent on OEM SPI implementation. The SPI host controller layer will utilize this library for SPI bus transactions. Bugzilla #4753 Cc: Liming Gao Cc: Ray Ni Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley Acked-by: Abner Chang Reviewed-by: Liming Gao

MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage

2024-03-29T23:56:16+00:00

Currently, there are multiple instances of code create image records. ImagePropertiesRecordLib was created to only have this code in one place. Update the lib to use additional logic from the copy in MemoryProtection.c before converging that code to use the lib. Cc: Liming Gao Cc: Taylor Beebe Acked-by: Michael D Kinney Reviewed-by: Ard Biesheuvel Signed-off-by: Oliver Smith-Denny

MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-29T23:56:16+00:00

When an ImageRecord is stored by ImagePropertiesRecordLib, it reports the CodeSegmentSize as the SizeOfRawData from the image. However, the image as loaded into memory is aligned to the SectionAlignment, so SizeOfRawData is under the actual size in memory. This is important, because the memory attributes table uses these image records to create its entries and it will report that the alignment of an image is incorrect, even though the actual image is correct. This was discovered on ARM64, which has a 64k runtime page granularity alignment, which is backed by a 64k section alignment for DXE_RUNTIME_DRIVERs. The runtime code and data was correctly being loaded into memory, however the memory attribute table was incorrectly reporting misaligned ranges to the OS, causing attributes to be ignored for these sections for OSes using greater than 4k pages. This patch correctly aligns the CodeSegmentSize to the SectionAlignment and the corresponding memory attribute table entries are now correctly aligned and pointing to the right places in memory. Cc: Liming Gao Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Taylor Beebe Acked-by: Michael D Kinney Reviewed-by: Ard Biesheuvel Reviewed-by: Marvin H?user Signed-off-by: Oliver Smith-Denny

MdeModulePkg/TraceHubDebugSysTLib: Use wider type for loop comparisons

2024-02-26T23:13:08+00:00

Resolves a new CodeQL error due to the value being incremented in the loop being a narrower type than the variable it is being compared against. The variable is changed to a UINT32 type so it has the same width as the type it is being compared against. Issue explanation: In a loop condition, comparison of a value of a narrow type with a value of a wide type may result in unexpected behavior if the wider value is sufficiently large (or small). This is because the narrower value may overflow. This can lead to an infinite loop. Cc: Liming Gao Cc: Gua Guo Cc: Prakashan Krishnadas Veliyathuparambil Cc: K N Karthik Signed-off-by: Michael Kubacki Reviewed-by: Gua Guo

MdeModulePkg/DebugAgentLibNull: Indicate SMM Debug Agent support or not

2023-12-26T07:18:26+00:00

This patch is to use the Context to indicate SMM Debug Agent support or not if InitFlag is DEBUG_AGENT_INIT_SMM. Context must point to a BOOLEAN if it's not NULL. Cc: Ray Ni Cc: Liming Gao Signed-off-by: Jiaxin Wu Reviewed-by: Ray Ni

MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-12-19T13:56:58+00:00

Currently, the ReadyToBoot event is only signaled when a formal Boot Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). However, the introduction of Platform Recovery in UEFI 2.5 makes it necessary to signal ReadyToBoot when a Platform Recovery boot loader runs because otherwise it may lead to the execution of a boot loader that has similar requirements to a regular one that is not launched as a Boot Manager option. This is especially critical to ensuring that the graphical console is actually usable during platform recovery, as some platforms do rely on the ConsolePrefDxe driver, which only performs console initialization after ReadyToBoot is triggered. This patch fixes that behavior by calling EfiSignalEventReadyToBoot () in EfiBootManagerProcessLoadOption () when invoking platform recovery, which is the function that sets up the platform recovery boot process. The expected behavior has been clarified in the UEFI 2.10 specification to explicitly indicate this behavior is required for correct operation. This is a rebased version of the patch originally written by Pete Batard. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2831 Co-authored-by: Pete Batard Signed-off-by: Neal Gompa Reviewed-by: Jeremy Linton Reviewed-by: Laszlo Ersek Reviewed-by: Leif Lindholm Reviewed-by: Liming Gao

MdeModulePkg/DxeCapsuleLibFmp: Fix crash with VirtualAddressMap omitted

2023-11-28T19:10:19+00:00

If the SetVirtualAddressMap() is not called, mIsVirtualAddrConverted is FALSE and the kernel crash occurs in IsNestedFmpCapsule() when executing gBS->LocateProtocol () in the else case. To serve the omitted SetVirtualAddressMap() call, we could just check mEsrtTable presence instead of relying on mIsVirtualAddrConverted. Signed-off-by: Nhi Pham Reviewed-by: Ard Biesheuvel Reviewed-by: Liming Gao

MdeModulePkg: Update DumpImageRecord() in ImagePropertiesRecordLib

2023-11-27T18:55:18+00:00

Update DumpImageRecord() to be DumpImageRecords(), and improve the debug output. The function will output at DEBUG_INFO instead, and the function will be run in DXE and SMM MAT logic when the MAT is installed at EndOfDxe on DEBUG builds. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Jiaxin Wu Cc: Ray Ni Signed-off-by: Taylor Beebe Reviewed-by: Liming Gao

MdeModulePkg: Add Logic to Create/Delete Image Properties Records

2023-11-27T18:55:18+00:00

Add logic to create and delete image properties records. Where applicable, redirect existing code to use the new library. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Jiaxin Wu Cc: Ray Ni Signed-off-by: Taylor Beebe Reviewed-by: Liming Gao