Tianocore/edk2.git/MdeModulePkg/Library, branch master

MdeModulePkg/UefiHiiLib: Fix memory leaks in ValidateQuestionFromVfr

2026-09-25T12:42:52+00:00

QuestionName is allocated by HiiGetString() but is not released in several code path. This causes memory leaks whenever these paths are taken. Add FreePool (QuestionName) after it is no longer needed. No functional change intended. Signed-off-by: Qihang Gao

MdeModulePkg: Add EFIAPI to GptLib functions

2026-09-18T17:02:19+00:00

EFIAPI is required on library interface functions to ensure that the correct calling convention is used. Signed-off-by: Michael Kubacki

MdeModulePkg: Update UI strings to indicate case-insensitive key options

2026-09-15T03:00:02+00:00

Update the prompt strings for save/exit and confirm actions to show both uppercase and lowercase key options (e.g., 'Y(y)' and 'N(n)') to make it clear that the system accepts either case. This improves user experience by avoiding confusion about case sensitivity. Affected strings: - ARE_YOU_SURE (CustomizedDisplayLib) - CONFIRM_OPTION (DisplayEngineDxe) - RECONNECT_CHANGES_OPTIONS (DisplayEngineDxe) French translations are updated accordingly. Signed-off-by: Qihang Gao

MdeModulePkg: Report EFI_SW_DXE_BS_PC_BOOT_OPTION_COMPLETE

2026-09-07T07:37:40+00:00

Previously EfiBootManagerBoot reported EFI_SW_DXE_BS_EC_BOOT_OPTION_FAILED when a boot option returned an error, but reported nothing on success. Report the PI 1.10 status code EFI_SW_DXE_BS_PC_BOOT_OPTION_COMPLETE when a boot option loads, executes, and returns success, so status code listeners can tell that a boot option was attempted and that control returned to firmware. Signed-off-by: Sachin Ganesh

MdeModulePkg/ImagePropertiesRecordLib: Fix incorrect use of sizeof

2026-08-28T04:43:10+00:00

In GetFilename(), the post-loop fallback termination used sizeof (EfiFileName), which is the size of the CHAR8 * pointer parameter (8 bytes on X64), not the buffer size. Use EfiFileNameSize - 4 to match the bound of the copy loop above so the string is terminated at the true end of the buffer. Tested on OvmfPkgIa32X64, DEBUG, GCC: DumpImageRecords() prints all runtime image names correctly and NUL-terminated, with no ASSERTs. Signed-off-by: Mingjie Shen

MdeModulePkg/BootMaintenanceManagerUiLib: Change numeric step to 1

2026-08-28T03:22:53+00:00

Set the numeric step to 1 to allow +/- key adjustment. Signed-off-by: Qihang Gao

MdeModulePkg/UefiBootManagerLib: Add constructor to INF file

2026-08-26T22:17:56+00:00

UefiBootManagerLibConstructor() is a constructor function in BmBoot.c that is missing as the constructor in the INF file. Signed-off-by: Michael Kubacki

MdeModulePkg/UefiHiiLib: Fix regression from 12828

2026-08-11T01:22:08+00:00

12828 introduced an ASSERT in HiiGetBrowserData() that fires when InternalHiiBrowserCallback() returns NULL. This is a valid return value indicating the browser has no data for the requested variable, and callers already handle this by checking the FALSE return value. The ASSERT is incorrect because it triggers on a non-error path, causing a crash when the browser callback legitimately returns no data. Remove the unnecessary ASSERT while keeping the existing FALSE return so callers continue to handle this case gracefully. Cc: Qihang Gao Signed-off-by: Aaron Pop

MdeModulePkg: Fix unchecked return status

2026-08-05T11:34:09+00:00

https://github.com/github/codeql/blob/codeql-cli-2.7.3/csharp/ql/src/API%20Abuse/UncheckedReturnValue.qhelp When a function has a return status, it should be checked to verify the function completed successfully. Failing to check the return status can result in null pointer dereferences or use of uninitialized variables. Signed-off-by: Aaron Pop

MdeModulePkg: Fix missing NULL tests

2026-08-05T11:34:09+00:00

https://github.com/github/codeql/blob/codeql-cli-2.7.3/cpp/ql/src/Critical/MissingNullTest.qhelp For items which allocate memory, or get a pointer from another structure, it is important to validate that the pointers are not null before they are dereferenced. Signed-off-by: Aaron Pop