Tianocore/edk2.git/MdeModulePkg/Library/CustomizedDisplayLib, branch master

MdeModulePkg: Update UI strings to indicate case-insensitive key options

2026-09-15T03:00:02+00:00

Update the prompt strings for save/exit and confirm actions to show both uppercase and lowercase key options (e.g., 'Y(y)' and 'N(n)') to make it clear that the system accepts either case. This improves user experience by avoiding confusion about case sensitivity. Affected strings: - ARE_YOU_SURE (CustomizedDisplayLib) - CONFIRM_OPTION (DisplayEngineDxe) - RECONNECT_CHANGES_OPTIONS (DisplayEngineDxe) French translations are updated accordingly. Signed-off-by: Qihang Gao

MdeModulePkg: Fix comparison with wider widths

2026-07-30T19:10:07+00:00

https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type If the narrow type (smaller range) is compared against a wide type (larger range), the narrow value may overflow before reaching the wide value. This can cause unexpected behavior, such as: Infinite loops (loop condition never becomes false). Incorrect logic (comparison results are misleading). Signed-off-by: Aaron Pop

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg/CustomizedDisplayLib: fix gcc 16 warning

2026-02-01T20:30:31+00:00

MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.c: In function ‘CreateDialog’: MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.c:435:18: error: variable ‘Count’ set but not used [-Werror=unused-but-set-variable=] 435 | UINTN Count; | ^~~~~ Signed-off-by: Gerd Hoffmann

MdeModulePkg: fix various typos

2025-11-21T21:49:59+00:00

Signed-off-by: Philipp Schuster

MdeModulePkg: Simplify PrintInternal function to fit wide character

2025-08-22T10:32:40+00:00

According to UEFI Spec, only Bit0...6 is valid in mode attribute, other bits are undefined and must be 0. So attribute with EFI_WIDE_ATTRIBUTE is unacceptable as EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.SetAttribute() input parameter. In current PrintInternal function, wide character removed WIDE_CHAR, and is used as EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.OutputString() input parameter. So, wide character is mistakenly be treated as narrow character. Because EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.OutputString() can handle unicode string with NARROW_CHAR and WIDE_CHAR, we can directly invoke OutputString() with whole unicode string in PrintInternal function instead of separated wide/narrow string. And then, the logic of computing unicode string width is also simplified. Signed-off-by: Gao Qihang

MdeModulePkg: Fix typos in CustomizedDisplayLib

2025-05-26T01:04:17+00:00

`diemenstion/diemension`->`dimension` Signed-off-by: Gao Qihang

MdeModulePkg/CustomizedDisplayLib:Fix wrong ColumnIndexWidth special case.

2025-04-02T19:10:04+00:00

If the column width of screen cannot be divisible by three, one or two rows will be superfluous in the 3rd column. so, Optimize calculation method of 3rd cloumn to fill entire row. Signed-off-by: Gao Qihang

MdeModulePkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the MdeModulePkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao

MdeModulePkg: Change OPTIONAL keyword usage style

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3760 Update all use of ', OPTIONAL' to ' OPTIONAL,' for function params. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael Kubacki Signed-off-by: Michael D Kinney Reviewed-by: Liming Gao