Tianocore/edk2.git/MdeModulePkg/Core/PiSmmCore/Smi.c, branch master

MdeModulePkg/Core: Move SMI depth tracker below SMI presence check

2026-02-27T06:09:41+00:00

Fixes: #11764 Currently, mSmiManageCallingDepth is incremented always whether SMI handler is present or not. However get decremented only when SMI handler is found. This causes mSmiManageCallingDepth to grow infinitely as long as SMI handler isn't present. Increment mSmiManageCallingDepth only when SMI handler presence is confirmed. Signed-off-by: Khalid Ali

MdeModulePkg/SMM: Initialize 'WillReturn' variable

2024-05-30T01:57:35+00:00

The local variable 'WillReturn' was being used without prior initialization in some code paths. This patch ensures that 'WillReturn' is properly initialized to prevent undefined behavior. Signed-off-by: Zhiguang Liu

MdeModulePkg/SMM: Support to unregister SMI handler in SMI handlers

2024-04-16T04:41:27+00:00

This patch fix a use-after-free issue where unregistering an SMI handler could lead to the deletion of the SMI_HANDLER while it is still in use by SmiManage(). The fix involves modifying SmiHandlerUnRegister() to detect whether it is being called from within the SmiManage() stack. If so, the removal of the SMI_HANDLER is deferred until SmiManage() has finished executing. Additionally, due to the possibility of recursive SmiManage() calls, the unregistration and subsequent removal of the SMI_HANDLER are ensured to occur only after the outermost SmiManage() invocation has completed. Cc: Liming Gao Cc: Jiaxin Wu Reviewed-by: Ray Ni Cc: Laszlo Ersek Signed-off-by: Zhiguang Liu

Revert ae1079b386a597108a8070652bf7cdaa4ec3dda3

2024-04-16T04:41:27+00:00

This reverts "MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler" for better design later. Cc: Liming Gao Cc: Jiaxin Wu Cc: Ray Ni Cc: Laszlo Ersek Reviewed-by: Ray Ni Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Zhiguang Liu

Revert 17b28722008eab745ce186b72cd325944cbe6bf0

2024-04-16T04:41:27+00:00

This reverts commit "MdeModulePkg/SMM: Disallow unregister SMI handler in other SMI handler" for better design later. Cc: Liming Gao Cc: Jiaxin Wu Cc: Ray Ni Cc: Laszlo Ersek Reviewed-by: Ray Ni Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Zhiguang Liu

MdeModulePkg/SMM: Disallow unregister SMI handler in other SMI handler

2024-03-01T18:47:27+00:00

In last patch, we add code support to unregister SMI handler inside itself. However, the code doesn't support unregister SMI handler insider other SMI handler. While this is not a must-have usage. So add check to disallow unregister SMI handler in other SMI handler. Cc: Liming Gao Cc: Jiaxin Wu Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Zhiguang Liu Message-Id: <20240301030133.628-3-zhiguang.liu@intel.com> Reviewed-by: Ray Ni Reviewed-by: Laszlo Ersek

MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler

2024-03-01T18:47:27+00:00

To support unregister SMI handler inside SMI handler itself, get next node before SMI handler is executed, since LIST_ENTRY that Link points to may be freed if unregister SMI handler in SMI handler itself. Cc: Liming Gao Cc: Jiaxin Wu Reviewed-by: Ray Ni Reviewed-by: Laszlo Ersek Signed-off-by: Zhiguang Liu Message-Id: <20240301030133.628-2-zhiguang.liu@intel.com>

MdeModulePkg/SmmCore: Add perf-logging for time-consuming procedures

2023-06-21T04:37:17+00:00

Following procedures are perf-logged: * SmmReadyToBootHandler * SmmReadyToLockHandler * SmmEndOfDxeHandler * SmmEntryPoint (It's the main routine run in BSP when SMI happens.) * SmiManage Signed-off-by: Ray Ni Cc: Jian J Wang Cc: Liming Gao Cc: Jiaxin Wu Reviewed-by: Jiaxin Wu Reviewed-by: Eric Dong Reviewed-by: Jian J Wang

MdeModulePkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the MdeModulePkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao

MdeModulePkg/Core/PiSmmCore: Fix various typos

2020-02-10T22:30:07+00:00

Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Hao A Wu Signed-off-by: Philippe Mathieu-Daude Message-Id: <20200207010831.9046-18-philmd@redhat.com>