Tianocore/edk2.git/MdeModulePkg/Bus, branch dependabot/github_actions/github/codeql-action-4.39.1

MdePkg,MdeModulePkg: Introduce Enter4Byte/Exit4Byte In SpiNorFlashJedecSfdp

2026-10-23T18:55:11+00:00

Follow JESD216H 6.4.19, DWORD 16 Introduce Enter4Byte/Exit4Byte In SpiNorFlashJedecSfdp And SpiNorFlash Fixes: #13171 Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Vincent Ke

MdeModulePkg: Use DUMP_HEX Macro

2026-10-23T03:44:49+00:00

Several places in MdeModulePkg were implementing their own versions of hex dumping logic; use the DebugLib.h macro instead. Prints change slightly, they are now standardized with uppercase hex, prefixes on every row instead of in the header only, and VarCheckHiiLib no longer indents rows with *ASCII*. Signed-off-by: Oliver Smith-Denny

MdeModulePkg/UsbBusDxe: Free BOS buffer on read failure

2026-10-21T21:53:42+00:00

UsbGetDevBosDesc() allocates a buffer for the initial BOS descriptor request. If that request fails, the success-only cleanup is skipped and the function returns without freeing the buffer. Repeated enumeration attempts can leak one allocation per failure. Free the initial buffer before returning the transfer error. The leaking retrieval helper was introduced by PR #12714: https://github.com/tianocore/edk2/pull/12714 Signed-off-by: Michael D Kinney

MdeModulePkg/UsbBusDxe: Bound BOS capability parsing

2026-10-21T21:53:42+00:00

UsbIsSSDevice() trusts device-reported NumDeviceCaps and capability Length fields without bounding reads to the BOS buffer. Malformed values can cause out-of-bounds reads and an exception during device enumeration. Validate the BOS header and total length. Before reading each capability, check that its header and declared length fit in the remaining bytes. Reject malformed or truncated descriptors and recognize SuperSpeed only after validating the complete capability list. The unbounded parser was introduced by PR #12714: https://github.com/tianocore/edk2/pull/12714 Signed-off-by: Michael D Kinney

MdeModulePkg/UsbBusDxe: Guard descriptor on SS retry

2026-10-21T21:53:42+00:00

UsbEnumerateNewDev() frees DevDesc before resetting the port for an enumeration retry. UsbRootHubResetPort() scans that device during the reset and previously dereferenced DevDesc without checking it. For a SuperSpeed-capable device running below SuperSpeed, IsSSDev and Speed still satisfy the scan's preceding conditions after DevDesc is cleared. The DeviceClass access can therefore cause a null-pointer exception. Add descriptor checks before those dereferences and clear IsSSDev when freeing the descriptor. The unsafe reset dereference was introduced by PR #12714: https://github.com/tianocore/edk2/pull/12714 Signed-off-by: Michael D Kinney

MdeModulePkg/UsbBusDxe: Add GoogleTest coverage

2026-10-21T21:53:42+00:00

Test valid SuperSpeed recognition and reject capabilities extending beyond the BOS total length or supplied buffer. Verify failed initial BOS reads free their buffers and root-hub reset succeeds after descriptor cleanup. Signed-off-by: Michael D Kinney

MdeModulePkg/UsbMassStorageDxe: Report blank optical media as media absent

2026-10-21T04:58:42+00:00

A blank (unwritten) optical disc reports a zero capacity through READ CAPACITY (LastBlock == 0). The driver currently exposes such a device with BlockSize 2048 and LastBlock 0, so upper layers such as PartitionDxe and the BDS removable-media boot probe keep reading LBA 0. The drive rejects the read with "Illegal Request / LBA out of range" (sense 5/21/0) and UsbMassReadBlocks enters its reset recovery loop. So each failed probe can block for tens of seconds and boot appears to hang. Treat an optical device with zero capacity as media absent so that the media is skipped instead of being probed. Signed-off-by: Haword

MdeModulePkg:NvmExpressDxe fix memory leak

2026-10-19T17:25:48+00:00

Memory leak anytime the FormatNvm function is called. Signed-off-by: Sean Brogan

MdeModulePkg:NvmExpressDxe/UnitTest set LastBlock correctly

2026-10-19T17:25:48+00:00

LastBlock field is inclusive. To lower confusion it should be initialized to the intended value which was to create metadata for an 8mb disk. Signed-off-by: Sean Brogan

MdeModulePkg:NvmExpressDxe/UnitTest remove useless code

2026-10-19T17:25:48+00:00

NamespaceData was allocated, zeroed, and never modifed. Then it was copied over another buffer that was already zero. Then it was leaked. Remove local variable NamespaceData and the associated code. Signed-off-by: Sean Brogan