EDK II (mirror) https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Fgithub%2Fcodeql-action-4 2025-10-09T08:02:51+00:00 2025-10-09T08:02:51+00:00 nick.wang nick.wang@insyde.com 2025-04-15T11:35:46+00:00 urn:sha1:0cad130cb4885961da201bb9b08424b3fd3d2249 There is a possibility to retrieve user input keystroke data stored in the queue buffer via the EFI_SIMPLE_TEXT_INPUT_PROTOCOL pointer. To prevent exposure of the password string, clear the queue buffer by filling it with zeros after reading. Signed-off-by: Nick Wang <nick.wang@insyde.com> 2025-09-29T01:10:22+00:00 Yang Gang yanggang@byosoft.com.cn 2025-07-04T09:32:46+00:00 urn:sha1:7b971810b0ef964276eff4541784ea2f520e66a9 If `AbsoluteMaxZ`/`ResolutionZ` is 0, it means z-axis is not supported. When getting AbsolutePointer/SimplePointer Protocol Interface and mouse state from `gST->ConsoleInHandle`, `AbsoluteMaxZ`/`ResolutionZ` is checked, so AbsState.CurrentZ/SimpleState.RelativeMovementZ is always 0. Assign a valid value to `AbsoluteMaxZ`/`ResolutionZ` to indicate z-axis support. Signed-off-by: Yang Gang <yanggang@byosoft.com.cn> 2025-09-25T22:04:10+00:00 Oliver Smith-Denny osde@microsoft.com 2025-09-15T16:26:04+00:00 urn:sha1:ef79d5842734e0504f58aef86142079ed26b7238 edk2 is dropping support for the ARM32 architecture. This commit removes ARM32 support from MdeModulePkg. This also drops irrelevant VALID_ARCHITECTURE comments from infs that are not arch specific. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com> 2025-09-02T02:55:44+00:00 Yang Gang yanggang@byosoft.com.cn 2025-07-02T06:19:31+00:00 urn:sha1:fa92e9bd05816aace0f087d58413d69ddf540e2d Signed-off-by: Yang Gang <yanggang@byosoft.com.cn> 2025-08-07T10:49:22+00:00 Ard Biesheuvel ardb@kernel.org 2025-02-26T12:27:14+00:00 urn:sha1:44d88d5d0c082f618be62ce7ef92cf4a8969e092 This PPI is no longer used - the EHCI and XHCI host controller PEIMs expose PEI_USB2_HOST_CONTROLLER_PPI instead. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> 2025-08-07T10:49:22+00:00 Ard Biesheuvel ardb@kernel.org 2025-02-26T12:22:07+00:00 urn:sha1:834586f3160d2ae696097f6f94c59ecb71978428 There are two versions of the USB host controller PPI, and only the newer one, called PEI_USB2_HOST_CONTROLLER_PPI, is actually produced by the EHCI and XHCI host controller PEIMs in EDK2. (The other PPI was only produced by UhciPei which has been removed) So remove all the conditionally executed code based on the distinction between the two PPIs, and only support the newer one. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> 2025-08-07T09:10:24+00:00 Michael Kubacki michael.kubacki@microsoft.com 2025-05-08T00:43:39+00:00 urn:sha1:9688712f1d15ddfb8fc53ad728823f5a987bd705 Running Codeql on the MdeModulePkg\Bus\Usb drivers results in codeql errors stemming for the following two checks. - cpp/comparison-with-wider-type - cpp/overflow-buffer Signed-off-by: Aaron Pop <aaronpop@microsoft.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Co-authored-by: Taylor Beebe <tabeebe@microsoft.com> Co-authored-by: pohanch <125842322+pohanch@users.noreply.github.com> Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com> Co-authored-by: Oliver Smith-Denny <osde@linux.microsoft.com> Co-authored-by: Sean Brogan <sean.brogan@microsoft.com> Co-authored-by: Aaron <aaronpop@microsoft> 2025-07-10T01:06:35+00:00 Alok Kulkarni 18198210+akulkar4@users.noreply.github.com 2022-03-01T20:37:38+00:00 urn:sha1:a00ad45ea45203052491fe2b25c9393a59c75c53 During USB device enumeration, issuing a hot reset on a port is skipped if there is a reset change status already detected on the port. This can happen when enumerating devices after a host controller soft reset (which drives a hot reset down the ports). However, in certain cases an attached device may not be responsive even if the reset change and connection status bits are set. For e.g., according to xHCI spec section 4.19.5.1 the port reset change bits can be set when a hot reset driven on the port transitions to a warm reset and completes with errors. For such instances it is worthwhile to force a hot reset during enumeration to try and recover unresponsive devices. During enumeration check whether querying port status returns EFI_DEVICE_ERROR and try a port reset if there is a device attached to the port. Signed-off-by: Aaron Pop <aaronpop@microsoft.com> 2025-05-09T08:01:42+00:00 Bret Barkelew brbarkel@microsoft.com 2024-07-01T18:09:55+00:00 urn:sha1:b2db39cefe1318d13d30040d31a6954e6b7219ce https://www.usb.org/sites/default/files/hid1_11.pdf Appendix B, B.2 Protocol 2 (Mouse) details the information returned by a usb mouse HID. bytes 3..n are specific to the device, but are used by absolute pointer devices to return a z axis. Prior to this change, the existing code was reusing the X value for the Z axis, which was incorrect. For usb devices which do not return enough data for a z axis, this change will be a no-op. Signed-off-by: Aaron Pop <aaronpop@microsoft.com> 2025-04-16T01:27:39+00:00 Pohan Wu pohanw@qti.qualcomm.com 2025-03-20T17:52:55+00:00 urn:sha1:948d4ba0be6352d41e8b25895a10f51b5ee7b928 When a USB mass storage device is not ready (e.g., still powering up or the hard disk has not reached the desired RPM), the ExecCommand function fails.This failure is not a true error. Logging it as DEBUG_ERROR will generate logs for properly functioning devices as well, potentially flooding logs for older devices. As mentioned in the command, proper error information retrieval should occur in the sense request. The solution is to downgrade the log level from DEBUG_ERROR to DEBUG_INFO. Signed-off-by: Jack Pham <jackp@qti.qualcomm.com>