Tianocore/edk2.git/MdeModulePkg/Bus/Usb/UsbNetwork, branch master

MdeModulePkg: UsbNetwork: Fix uninitialized variable warnings

2026-06-24T14:49:50+00:00

In NetworkCommonDriverStart(), if gPxe is not NULL, TmpPxePointer should be initialized as it is referenced later in the clean up code. Signed-off-by: Tuan Phan

MdeModulePkg: Remove Depex section in UEFI_DRIVER and UEFI_APPLICATION

2026-06-09T05:51:07+00:00

According to INF specification, UEFI_DRIVER and UEFI_APPLICATION cannot have Depex section. So remove it. Signed-off-by: Qihang Gao

MdeModulePkg/NetworkCommon: Add PCD for USB network periodic timer

2026-04-21T13:29:12+00:00

Replace the hardcoded NETWORK_COMMON_POLLING_INTERVAL (0x10 = 16ms) with a new PCD PcdUsbNetworkPeriodicalTimer, allowing platforms to configure the asynchronous transfer interval for USB network devices. The default value of 16ms preserves existing behaviour. EFI_USB_IO_PROTOCOL.UsbAsyncInterruptTransfer(), the PollingInterval parameter must be between 1 and 255 milliseconds; a value of 0 returns EFI_INVALID_PARAMETER. The PCD is declared with a @ValidRange of 1-255 and an ASSERT guards against a zero value at runtime. Co-authored-by: Abner Chang Signed-off-by: Abdul Lateef Attar

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg: Remove extraneous parentheses

2025-11-22T01:43:26+00:00

XCODE5 toolchain finds these, with errors such as: PxeFunction.c:763:27: error: equality comparison with extraneous parentheses Signed-off-by: Mike Beaton

MdeModulePkg UsbNetwork: Use USB class definition from MdePkg

2024-10-22T05:40:04+00:00

- Class specific types for interface and endpoint are generic - Definitions are in IndustryStandard/Usb.h - Remove type redefinitions - Update references to the descriptor types Signed-off-by: Oleg Ilyasov

MdeModulePkg/Bus/Usb/UsbNetwork: Check array index range before access

2024-02-26T20:46:12+00:00

Checks that an offset used to access array elements is within the expected range before accessing the array item. Cc: Liming Gao Cc: Ray Ni Cc: Rebecca Cran Cc: Richard Ho Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao

MdeModulePkg: UsbRndis: get rid of magic values

2023-10-16T22:49:33+00:00

Replace magic values used for checking Base Class, SubClass and Protocol fields of USB Interface Descriptor. Add definitions for Base Class EFh (Miscellaneous) and RNDIS subclass. These definitions were taken from https://www.usb.org/defined-class-codes Cc: Richard Ho Cc: Rebecca Cran Signed-off-by: Mike Maslenkin

MdeModulePkg: UsbNetwork: fix Ethernet functional descriptor processing

2023-10-16T22:49:33+00:00

This patch fixes wrong condition because of UINT16 value to integer promotion. NumberMcFilters is UINT16 value, so when bitwise shift operator applied to small integer type, the operation is preceded by integral promotion. This is described in MISRA-C:2004 guideline as Rule 10.5: "If the bitwise operators ~ and << are applied to an operand of underlying type unsigned char or unsigned short, the result shall be immediately cast to the underlying type of the operand." A simple fix for this issue would be the following: if ((UINT16)(UsbEthFunDescriptor.NumberMcFilters << 1) == 0) But this patch proposes to use bitwise AND operation with a proper bit mask rather than shifting to prevent similar mistakes in future. Cc: Richard Ho Cc: Rebecca Cran Signed-off-by: Mike Maslenkin

MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm: Add USB Cdc NCM devices support

2023-07-13T17:18:40+00:00

This driver provides UEFI driver for USB CDC NCM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Hao A Wu Cc: Ray Ni Tested-by: Tinh Nguyen Acked-by: Hao A Wu Reviewed-by: Rebecca Cran Reviewed-by: Tony Lo