Tianocore/edk2.git/MdeModulePkg/Bus/Ufs, branch master

MdeModulePkg: Print unknown error code instead of asserting

2026-09-02T17:34:24+00:00

DumpUicCmdExecResult & DumpQueryResponseResult are called to dump the result of UIC commands after a failure. Depending on the nature of the failure, not all information may have been properly initialized. This is already handled in callers with existing retry logic, but the assert in the dump command can cause a crash in debug builds for due to hardware race conditions on first attempt. Signed-off-by: Chris Fernald

MdeModulePkg: Fix comparison with wider widths

2026-08-05T02:13:24+00:00

https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type If the narrow type (smaller range) is compared against a wide type (larger range), the narrow value may overflow before reaching the wide value. This can cause unexpected behavior, such as: Infinite loops (loop condition never becomes false). Incorrect logic (comparison results are misleading). Signed-off-by: Aaron Pop

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg/UfsPassThruDxe:Fix Ufs DM Command issue

2025-12-24T06:41:24+00:00

After Execute UFS SCSI Commands, the Trd->PRDTL is dirty. It will cause issue when next UFS DM Command is executed. According to UFSHCI Spec, for UFS DeviceManagement function Trd->PRDTL must be set to Zero. Signed-off-by: Black.Li

MdeModulePkg: Support conditional UFS initialization

2025-08-08T01:06:56+00:00

Add SkipHceReenable and SkipLinkStartup flags to the EDKII_UFS_HC_PLATFORM_PROTOCOL to support using a UFS controller that has already been initialized. Signed-off-by: Bob Morgan

MdeModulePkg/UfsPassThruDxe: Correct size in UfsHc->FreeBuffer call

2025-06-25T06:48:08+00:00

UfsHc->FreeBuffer accepts page numbers rather than bytes as its size argument. Fix two positions where wrong size were passed. Signed-off-by: Ryan Wong

MdeModulePkg/Bus/Ufs: Use IndustryStandard headers

2024-12-16T07:39:35+00:00

Remove duplicate private header files and reference UFS spec definitions from the IndustryStandard folder. Signed-off-by: Christopher Zurcher

MdeModulePkg: Added PPI support in UFS PEI driver.

2024-10-28T05:39:52+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4490 Added PPI support in UFS PEI driver to link the platform specific code as same as UFS DXE driver. Signed-off-by: Kanagavel S

MdeModulePkg/UfsPassThruDxe: Migrate UFS Initial Completion Timeout to PCD

2024-07-30T20:55:09+00:00

- Remove the hardcoded definition (UFS_INIT_COMPLETION_TIMEOUT) - Migrate the UFS initial completion timeout into PCD value Signed-off-by: Jason1 Lin

MdeModulePkg/UfsBlockIoPei: Migrate UFS Initial Completion Timeout to PCD

2024-07-30T20:55:09+00:00

- Remove the hardcoded definition (UFS_INIT_COMPLETION_TIMEOUT) - Migrate the UFS initial completion timeout into PCD value Signed-off-by: Jason1 Lin