Tianocore/edk2.git/MdeModulePkg/Bus/Spi, branch dependabot/github_actions/actions/github-script-9

MdeModulePkg/SpiNorFlashJedecSfdp: Limit debug output

2026-03-23T16:30:18+00:00

Change debug print level from DEBUG_INFO to DEBUG_VERBOSE to limit excessive output. Since Spinor Sfdp operations can generate a large number of debug messages due to frequent read/write/erase actions, this change reduces log verbosity at the INFO level. Signed-off-by: Abdul Lateef Attar

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg: SpiNorFlash update FillWriteBuffer headers.

2025-11-24T09:07:21+00:00

The function headers for FillWriteBuffer have become out of date with the implementation. Update the function headers to more clearly define the interface for recent changes. Signed-off-by: Aaron Pop

MdeModulePkg/SpiNorFlashJedecSfdp: Initialize AddressSize

2025-06-13T15:47:59+00:00

Signed-off-by: Michael D Kinney

MdeModulePkg/SpiBus: Free handle buffers after LocateHandleBuffer

2025-06-12T14:09:13+00:00

Fix memory leaks by adding missing FreePool calls: release SpiHcHandles in SpiBusEntry exit path. REF: https://uefi.org/sites/default/files/resources/UEFI_Spec_Final_2.11.pdf Chapter 7.3.15: "Services - Boot Services.LocateHandleBuffer": It is the caller's responsibility to call the Boot Service.FreePool when the caller no longer requires the contents of Buffer. Signed-off-by: Dongyan Qian

MdeModulePkg/Spi: Allow NULL WriteBuffer in FillWriteBuffer()

2025-05-26T05:45:37+00:00

Fix false positive assert added in #10924 Functon `FillWriteBuffer()` should able to accept NULL WriteBuffer when WriteBytes equals 0. Use case: ``` // Read Status register TransactionBufferLength = FillWriteBuffer ( Instance, SPI_FLASH_RDSR, SPI_FLASH_RDSR_DUMMY, SPI_FLASH_RDSR_ADDR_BYTES, FALSE, 0, 0, // WriteBytes = 0 NULL // WriteBuffer can be NULL ); ``` Signed-off-by: Paddy Deng

MdeModulePkg/Spi: Solving potential null ptr deref. in SpiNorFlashJedecSfdp

2025-05-05T06:26:16+00:00

The pointer `Instance->SfdpBasicFlash` can be used before initializing. Example code flow: - CreateSpiNorFlashSfdpInstance: Allocate pool for `Instance` - InitialSpiNorFlashSfdpInstance - ReadSfdp - ReadSfdpHeader - FillWriteBuffer: Dereferencing `Instance->SfdpBasicFlash` - ReadSfdpBasicParameterTable: Allocate pool for `Instance->SfdpBasicFlash` Check both `Instance` and `Instance->SfdpBasicFlash` should have a non null value before dereferencing it. Otherwise use the defaut value 0. Also terminate the function if `Instance` or `WriteBuffer` is NULL. Signed-off-by: Paddy Deng

MdeModulePkg SpiBus: Use correct GUID

2025-04-30T06:55:42+00:00

Fix incorrect guid in SpiBusDxe and add null checking for AllocateZeroPool in the SpiBus driver. Signed-off-by: Jack Hsieh

MdeModulePkg: SpiHc: SpiHc Drivers

2024-05-08T04:43:58+00:00

Added SpiHc DXE and SMM drivers. This code receives bus transactions from the SpiBus layer and passes them onto the SpiHcPlatformLib Platform Initialization Spec 1.7 volume 5 section 18.1.7 Bugzilla #4753 Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley Reviewed-by: Abner Chang

MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers

2024-05-08T04:43:58+00:00

Added SpiBus DXE and SMM drivers. This code translates SPI requests from the application layer into SPI Bus transactions on the SPI host controller. The code is responsible for checking if the transaction is valid, then setting up the SPI clock and chip select properly before passing the bus transaction to the host controller. Platform Initialization Spec 1.7 volume 5 section 18.1.6 Bugzilla #4753 Cc: Abner Chang Cc: Abdul Lateef Attar Signed-off-by: Brit Chesley Reviewed-by: Abner Chang