Tianocore/edk2.git/MdeModulePkg/Bus/Sd, branch master

MdeModulePkg/EmmcBlockIoPei: Use UINTN for ADMA descriptor table indexing

2026-09-29T01:36:19+00:00

In BuildAdmaDescTable(), Index and Entries were UINT64. Using a 64-bit Index for array subscripting `Trb->AdmaDesc[Index]` generates 64-bit multiplication on 32-bit architectures (IA32). Change Index and Entries to UINTN so array indexing uses native integer math, and add BaseLib to the module INF. Signed-off-by: Michael D Kinney

MdeModulePkg: Fix comparison with wider widths

2026-08-05T02:13:24+00:00

https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type If the narrow type (smaller range) is compared against a wide type (larger range), the narrow value may overflow before reaching the wide value. This can cause unexpected behavior, such as: Infinite loops (loop condition never becomes false). Incorrect logic (comparison results are misleading). Signed-off-by: Aaron Pop

MdeModulePkg: SdBlockIoPei: Fix uninitialized variable warnings

2026-06-24T14:49:50+00:00

In SdPeimIdentification(), the compiler may inline SdPeimHcRwMmio() because it only performs simple MMIO reads and writes. When inlined, the fourth argument can appear to follow multiple control-flow paths (MMIO read versus MMIO write), which may cause the compiler to report a potential uninitialized variable warning when the value is used later if it was not initialized up front. Add an explicit Status check, consistent with other code in this file, to make the control flow explicit and eliminate the compiler warning. Signed-off-by: Tuan Phan

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg: Update ReceiveData and SendData function description

2024-03-13T02:48:38+00:00

AtaBusDxe, NvmExpressDxe, ScsiDiskDxe and EmmcDxe is used to back the EFI_STORAGE_SECURITY_COMMAND_PROTOCOL, update the parameter 'MediaId' description for the protocol function ReceiveData and SendData as described in UEFI Spec 2.10 section 13.14. Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Qingyu Shang Reviewed-by: Liming Gao

MdeModulePkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the MdeModulePkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Liming Gao

MdeModulePkg: Change use of EFI_D_* to DEBUG_*

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3739 Update all use of EFI_D_* defines in DEBUG() macros to DEBUG_* defines. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael Kubacki Signed-off-by: Michael D Kinney Reviewed-by: Liming Gao

MdeModulePkg/Sd: Corrections for Extra.uni files

2021-10-14T00:13:17+00:00

Add correct content to the 'SdDxeExtra.uni' file. Include 'EmmcDxeExtra.uni' and 'SdDxeExtra.uni' files to their appropriate INF files. Signed-off-by: Konstantin Aladyshev Reviewed-by: Hao A Wu

MdeModulePkg/SdDxe: Check the Token to avoid null pointer

2020-03-27T01:04:25+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2286 Token pointer may be NULL, it should be checked before use it. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Guomin Jiang Reviewed-by: Hao A Wu

MdeModulePkg/Bus/Sd: Fix various typos

2020-02-10T22:30:07+00:00

Fix various typos in comments and documentation. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Acked-by: Liming Gao Signed-off-by: Philippe Mathieu-Daude Message-Id: <20200207010831.9046-16-philmd@redhat.com>