Tianocore/edk2.git/MdeModulePkg/Application, branch master

MdeModulePkg: Fix missing NULL tests

2026-08-05T03:07:16+00:00

https://github.com/github/codeql/blob/codeql-cli-2.7.3/cpp/ql/src/Critical/MissingNullTest.qhelp For items which allocate memory, or get a pointer from another structure, it is important to validate that the pointers are not null before they are dereferenced. Signed-off-by: Aaron Pop

MdeModulePkg: Fix unchecked return status

2026-08-05T03:07:16+00:00

https://github.com/github/codeql/blob/codeql-cli-2.7.3/csharp/ql/src/API%20Abuse/UncheckedReturnValue.qhelp When a function has a return status, it should be checked to verify the function completed successfully. Failing to check the return status can result in null pointer dereferences or use of uninitialized variables. Signed-off-by: Aaron Pop

MdeModulePkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

MdeModulePkg/UiApp: Remove unused variable

2025-09-04T01:43:03+00:00

Since the variable mLanguageString is not used at all, remove it to make code clean. Signed-off-by: Qihang Gao

MdeModulePkg: Add help for Reset menu item, and fix French strings

2025-06-16T23:03:46+00:00

Fix the help string for the Reset menu item, and add it to the UI instead of just repeating the main text. Fix the French translations. Signed-off-by: Rebecca Cran

CapsuleApp: Fix proper return after capsule update

2025-03-13T02:36:57+00:00

After a failed capsule updated it returns 0 and not Status failure. Tested-by: Ilias Apalodimas Signed-off-by: Javier Tia

MdeModulePkg/UiApp: fix HiiOpCodeHandle leak

2024-12-06T17:13:17+00:00

Signed-off-by: Mike Maslenkin

MdeModulePkg/SmiHandlerProfileInfo: Declare correct XML encoding

2024-07-17T01:06:00+00:00

The code prints wide strings, so the content should be "utf-16" rather than "utf-8". Signed-off-by: Michael Kubacki

MdeModulePkg/CapsuleApp: Add EFIAPI to CompareFileNameInAlphabet()

2023-05-06T17:48:49+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4446 CompareFileNameInAlphabet() is passed as a function pointer parameter and typecast to type SORT_COMPARE that is declared with EFIAPI. Add EFIAPI to CompareFileNameInAlphabet() to match SORT_COMPARE type. Cc: Jian J Wang Cc: Liming Gao Cc: Guomin Jiang Signed-off-by: Michael D Kinney Reviewed-by: Liming Gao

MdeModulePkg/DumpDynPcd: Remove unsupported format specifiers

2022-08-17T07:45:58+00:00

Some print statements use format specifiers like %N/%H/%E/%B that are only supported in the shell print functions. In the ordinary 'Print' function they are just displayed as letters N/H/E/B. Remove these unsupported format specifiers from the 'Print' statements to fix the issue. Signed-off-by: Konstantin Aladyshev Reviewed-by: Liming Gao