Tianocore/edk2.git/ManageabilityPkg, branch dependabot/github_actions/actions/setup-python-7

ManageabilityPkg: Follow pragma once coding convention

2026-06-25T19:40:31+00:00

Update recent changes in ManageabilityPkg to follow the latest EDK II C Coding Standards Specification (5.3) to use '#pragma once' instead of traditional macro-based include guards in header files. https://tianocore-docs.github.io/edk2-CCodingStandardsSpecification/draft/5_source_files/53_include_files.html#53-include-files Signed-off-by: Michael Kubacki

ManageabilityPkg: Fix IPMI vulnerabilities and memory leak

2026-06-25T03:33:25+00:00

Fix vulnerabilities and a memory leak in the IPMI Blob Transfer driver: - Prevent integer underflow and OOB read by validating response size before accessing CompletionCode, OEN, and CRC. - Prevent buffer overflow by ensuring BMC response size does not exceed the caller's buffer capacity, avoiding potential memory overwriting. - Fix memory leak by freeing IpmiResponseData and IpmiSendData. Additionally, fix unit test failures caused by the changes and pre-existing bugs: - Allocate a safe fixed size (70 bytes) for IpmiResponseData in IpmiBlobTransferSendIpmi to prevent heap overflow if the BMC returns more data than expected. Add validation to check if returned size exceeds this allocation. - Modify IpmiBlobTransferStat and IpmiBlobTransferSessionStat to only copy MetaDataLen bytes of metadata instead of always copying the max size (64 bytes), preventing buffer overflow when caller allocates a smaller buffer. - Add missing ASSERT(FALSE) in IpmiBlobTransferStat parameter validation. - Fix IpmiBlobTransferWriteMeta parameter validation to allow 0-length writes (Data can be NULL when WriteLength is 0), which was causing test failure. - Fix syntax errors in unit tests where arrays were assigned values after declaration using brace-enclosed lists. - Fix sizeof misuse on macros representing size values in unit tests, which caused too small allocations and buffer overflows in mock setups. - Fix queue order in OpenValidResponse test to match the actual call order (GetCount, Enumerate, Open) and free all mock buffers. - Remove unnecessary MockIpmiSubmitCommand calls from invalid buffer tests to prevent mock queue leaks to subsequent tests. - Fix memory leaks of ExpectedMetadata in unit tests by changing them to static arrays. Signed-off-by: Phineas Su

ManageabilityPkg: TransportHelperLib: Fix uninitialized variable warning

2026-06-24T14:49:50+00:00

In HelperManageabilityPayLoadDebugPrint(), Page256 is only assigned inside an if block within the while loop but is accessed outside of it, causing an uninitialized variable warning. Initialize Page256 to zero before the while loop to fix this. Signed-off-by: Tuan Phan

ManageabilityPkg: TransportSsifLib: Fix uninitialized variable warning

2026-06-24T14:49:50+00:00

In SsifWriteRequest(), MiddleCount is only assigned inside an if block but is accessed in a subsequent loop, causing an uninitialized variable warning. Initialize MiddleCount to zero at declaration to fix this. Signed-off-by: Tuan Phan

ManageabilityPkg: Fix build failure issue on CLANGDWARF X64

2026-06-19T17:30:22+00:00

When building ManageabilityPkg with `-a X64 -t CLANGDWARF`, error message is throwed: BaseManageabilityTransportHelper.c:462:3: error: '__builtin_ms_va_start' used in System V ABI function 462 | VA_START (Marker, Format); | ^ Functions that call VA_START()/VA_END() must be declared with EFIAPI. The function HelperManageabilityDebugPrint() should also be declared with EFIAPI to ensure compliance with Microsoft X64 calling convention for CLANG. Signed-off-by: Qihang Gao

ManageabilityPkg: add configurable KCS status-check timeout PCD

2026-05-06T13:32:00+00:00

Replace the hardcoded IPMI_KCS_TIMEOUT_5_SEC macro in WaitStatusSet() and WaitStatusClear() with PcdKcsStatusCheckTimeout so platform firmware can tune the KCS timeout without recompiling the library. - ManageabilityPkg.dec: declare PcdKcsStatusCheckTimeout (UINT64, 5000000 us) - KcsCommon.c: use PcdGet64(PcdKcsStatusCheckTimeout); add DEBUG on timeout - ManageabilityTransportKcs.h: remove now-unused IPMI_KCS_TIMEOUT_5_SEC macro - BaseManageabilityTransportKcs.inf, Dxe/DxeManageabilityTransportKcs.inf: add PcdKcsStatusCheckTimeout to [FixedPcd] Co-authored-by: Abner Chang Signed-off-by: Abdul Lateef Attar

ManageabilityPkg: Add ManageabilityPkg CI yaml

2026-04-27T13:15:26+00:00

Adding edk2 CI yaml for ManageabilityPkg. Signed-off-by: Abner Chang

ManageabilityPkg: Initial version of ManageabilityPkg

2026-04-27T13:15:26+00:00

ManageabilityPkg is migrated from edk2-platform repository. The last commit ID of ManageabilityPkg on edk2-platform is <4538a1b94c0e55d58e3841b2d640df7da0a3b149>. Signed-off-by: Abner Chang