Tianocore/edk2.git/ManageabilityPkg/Library, branch master

ManageabilityPkg/PrivateInclude: Add EFIAPI to C header file

2026-09-01T15:24:24+00:00

Add EFIAPI to the functions published in the C header files. Signed-off-by: Abner Chang

ManageabilityPkg: SsifWriteRequest post-refactor cleanup

2026-07-31T05:45:58+00:00

Now the logic of the function is less convoluted, drop some redundant casts, variable initialisations and move the MiddleCount definition into the only block where it's used. Signed-off-by: Leif Lindholm

ManageabilityPkg: SsifWriteRequest loop refactoring

2026-07-31T05:45:58+00:00

A multi-part request can consist of a Start, zero-to-several Middle, and an End packet. For what I can only assume was an attempt to confuse the enemy, SsifWriteRequest () handled this by setting up three separate loops. Rewrite this as a single loop in order to reduce confusion for revewers and compilers. Signed-off-by: Leif Lindholm

ManageabilityPkg: fix/cleanup request size check in SsifWriteRequest

2026-07-31T05:45:58+00:00

From the IPMI v2.0 (April 21, 2015 E7 Markup) specification, Table 22-12, Get System Interface Capabilities Command: "Input message size in bytes. (1 based.)" ... "A BMC that supports multi-part Start and End would return a value from 33 to 64. A BMC that supports multi-part with Middle transactions would return a value from 65 to 255." Yet the comment in the existing code describes this as being a counter of the number of middle packets, with Start and End packets counting outside of that. This seems very incorrect to me. Address this, and simplify the code, by using the already existing global variable mMaxRequestSize. Update the debug error message text to reflect the functional change. Signed-off-by: Leif Lindholm

ManageabilityPkg: refactor SsifWriteRequest #1

2026-07-31T05:45:58+00:00

Separate input validation from argument marshalling. Signed-off-by: Leif Lindholm

ManageabilityPkg: reorganise ManageabilityTransportSsifLib

2026-07-31T05:45:58+00:00

For some reason this module was created "backwards", with .inf files in subdirectories, as well as identical apart from failes to keep in sync source files for Dxe and Pei drivers. Flip the thing the right way around and delete the duplicated files. Signed-off-by: Leif Lindholm

ManageabilityPkg: simplify HelperManageabilityPayLoadDebugPrint ()

2026-07-31T05:45:58+00:00

While reviewing PR #12035, I found this function a bit overcomplicated, with a bunch of live-coded integers, so I reworked it for improved human and compiler readability. Signed-off-by: Leif Lindholm

ManageabilityPkg: Follow pragma once coding convention

2026-06-25T19:40:31+00:00

Update recent changes in ManageabilityPkg to follow the latest EDK II C Coding Standards Specification (5.3) to use '#pragma once' instead of traditional macro-based include guards in header files. https://tianocore-docs.github.io/edk2-CCodingStandardsSpecification/draft/5_source_files/53_include_files.html#53-include-files Signed-off-by: Michael Kubacki

ManageabilityPkg: TransportHelperLib: Fix uninitialized variable warning

2026-06-24T14:49:50+00:00

In HelperManageabilityPayLoadDebugPrint(), Page256 is only assigned inside an if block within the while loop but is accessed outside of it, causing an uninitialized variable warning. Initialize Page256 to zero before the while loop to fix this. Signed-off-by: Tuan Phan

ManageabilityPkg: TransportSsifLib: Fix uninitialized variable warning

2026-06-24T14:49:50+00:00

In SsifWriteRequest(), MiddleCount is only assigned inside an if block but is accessed in a subsequent loop, causing an uninitialized variable warning. Initialize MiddleCount to zero at declaration to fix this. Signed-off-by: Tuan Phan