Tianocore/edk2.git/IntelFsp2Pkg/Library, branch dependabot/github_actions/actions/setup-python-7

IntelFsp2Pkg: Save/restore FSBASE/GSBASE in entry and exit

2026-03-09T16:21:26+00:00

FSP may store something in FSBASE/GSBASE while bootloader may do so as well. Add the FSBASE/GSBASE save/restore logic in the FSP entry and exit to avoid the contents in FSBASE/GSBASE are corrupted by the other party. The change assumes there is no very old CPU that does not support rdfsbase/wrfsbase/rdgsbase/wrgsbase instructions. Signed-off-by: Ray Ni

IntelFsp2Pkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

IntelFsp2Pkg: Correct ApiIdx type

2025-11-23T01:55:17+00:00

For function FspMultiPhasePlatformGetNumberOfPhases, the type of ApiIdx is not aligned in header file and c function, correct and make it align. Signed-off-by: Hongbin1 Zhang Cc: Ray Ni Cc: Star Zeng Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ted Kuo Cc: Ashraf Ali S

IntelFsp2Pkg: Preserve GDTR and CS/DS/ES/FS/GS/SS

2025-07-18T06:21:48+00:00

Bootloader does not expect FSP modifies GDTR and segment selectors, update FSP entry/exit code to preserve these registers. Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S

IntelFsp2Pkg/FspMultiPhaseLib: Remove EFIAPI for local function

2025-07-16T06:47:27+00:00

FspMultiPhaseWorker() is a local function that's called from FspMultiPhaseMemInitApiHandler() and FspMultiPhaseSiInitApiHandlerV2(). Remove "EFIAPI" from its function header. Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S

IntelFsp2Pkg/FspCommonLib: Remove unused API SetFspCoreStackPointer()

2025-07-16T06:47:27+00:00

Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S

IntelFsp2Pkg/CacheLib: Make integer width consistent in loop condition

2025-05-24T01:06:53+00:00

Explicitly casts `mFixedMtrrTable[MsrNum].Length` to resolve a `comparison-with-wider-type` CodeQL error. https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type/ Signed-off-by: Michael Kubacki

IntelFsp2Pkg : Refactor BaseFspCommonLib to reduce binary size

2024-09-30T08:15:35+00:00

Moved FspApiReturnStatusReset API to a separate file to eliminate unnecessary inclusion of FspApiReturnStatusReset APIs in driver binary. When the compiler linking the Object files it may not remove all the unused from NASM OBJs. This change is to reorganize the C files to minimize the impact of the NASM behavior resulting is code size reduction. Signed-off-by: Ashraf Ali

IntelFsp2Pkg: Support FSP API to save and restore page table

2024-09-11T05:45:54+00:00

A potential issue may happen when FSP creates/changes page table while bootloader doesn't expect page table being changed in FSP. Current, FSP API support to save/restore stack, IDT and general purpose registers. Following the same pattern, add save/restore page table support to solve this issue. Note that this feature only impacts FSP API mode, and is controlled by PCD PcdFspSaveRestorePageTableEnable. For compatibility, the PCD default value is set as FALSE. Signed-off-by: Zhiguang Liu

IntelFsp2Pkg: Align FSP global data pointer for X64 build

2024-08-28T13:40:56+00:00

When it used 32 bits for set FSP global data pointer under X64 build, it should get FSP global data pointer with 32 bits data under X64 build. Signed-off-by: Hongbin1 Zhang Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S