Tianocore/edk2.git/IntelFsp2Pkg/Library/BaseFspSwitchStackLib, branch dependabot/github_actions/actions/setup-python-7

IntelFsp2Pkg: Save/restore FSBASE/GSBASE in entry and exit

2026-03-09T16:21:26+00:00

FSP may store something in FSBASE/GSBASE while bootloader may do so as well. Add the FSBASE/GSBASE save/restore logic in the FSP entry and exit to avoid the contents in FSBASE/GSBASE are corrupted by the other party. The change assumes there is no very old CPU that does not support rdfsbase/wrfsbase/rdgsbase/wrgsbase instructions. Signed-off-by: Ray Ni

IntelFsp2Pkg: Preserve GDTR and CS/DS/ES/FS/GS/SS

2025-07-18T06:21:48+00:00

Bootloader does not expect FSP modifies GDTR and segment selectors, update FSP entry/exit code to preserve these registers. Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S

IntelFsp2Pkg: Support FSP API to save and restore page table

2024-09-11T05:45:54+00:00

A potential issue may happen when FSP creates/changes page table while bootloader doesn't expect page table being changed in FSP. Current, FSP API support to save/restore stack, IDT and general purpose registers. Following the same pattern, add save/restore page table support to solve this issue. Note that this feature only impacts FSP API mode, and is controlled by PCD PcdFspSaveRestorePageTableEnable. For compatibility, the PCD default value is set as FALSE. Signed-off-by: Zhiguang Liu

IntelFsp2Pkg/SwitchStack: Reserve 32B when calling C function in 64bit

2023-11-03T19:41:25+00:00

When FSP runs in API mode, it saves the IDTR in its own stack then switches to bootloader's stack before it returns from FspMemoryInit. Next time when the bootloader calls TempRamExit, FSP switches to its own stack and restores IDTR from its stack saved earlier. However, due to a bug in BaseFspSwitchStackLib, the IDTR saved on FSP's stack might be corrupted that results the following TempRamExit call fails inside FSP due to PeiServices pointer cannot be retrieved from IDT.base - 8. The bug is the assembly code doesn't reserve 32 bytes before calling the C routine in 64bit. According to the x86-64 calling convention, caller is responsible for allocating 32 bytes of "shadow space" on the stack right before calling the function (regardless of the actual number of parameters used). When FSP is built in optimization-off mode, the C routine makes use of the 32-byte "shadow space" which is not reserved by the assembly caller. That causes the IDTR saved on the stack is corrupted by the C routine. The patch fixes so by reserving the 32 bytes before calling C routine. Signed-off-by: Ray Ni Cc: Chasel Chiu Reviewed-by: Nate DeSimone Cc: Duggapu Chinni B Cc: Ray Han Lim Ng Cc: Star Zeng Reviewed-by: Ted Kuo Reviewed-by: Ashraf Ali S Cc: Susovan Mohapatra

IntelFsp2Pkg: Fix code formatting errors

2022-10-04T16:53:59+00:00

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048 This package did not have CI enabled so code changes were merged that fail uncrustify formatting. This change updates those files to include uncustify formatting. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Michael Kubacki Reviewed-by: Chasel Chiu Reviewed-by: Michael D Kinney

IntelFsp2Pkg: FspSecCore support for X64

2022-04-16T00:18:14+00:00

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 1.Added FspSecCore support for X64. 2.Bumped FSP header revision to 7 to indicate FSP 64bit is supported. 3.Corrected few typos. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo Reviewed-by: Chasel Chiu Reviewed-by: Nate DeSimone

IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-16T00:18:14+00:00

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893 1.Added EFIAPI to FspNotifyPhasePeimEntryPoint, SwapStack and PEI_CORE_ENTRY. 2.Treat both MAX_ADDRESS and MAX_UINT32 as invalid address for FSP global data in FspApiCallingCheck(). 3.Changed AsmReadEsp to AsmReadStackPointer. 4.Changed the type of the return value of AsmReadStackPointer from UINT32 to UINTN. 5.Changed the type of TemporaryMemoryBase, PermenentMemoryBase and BootLoaderStack from UINT32 to UINTN. 6.Some type casting to pointers are UINT32. Changed them to UINTN to accommodate both IA32 and X64. 7.Corrected some typos. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo Reviewed-by: Chasel Chiu Reviewed-by: Nate DeSimone

IntelFsp2Pkg: BaseFspSwitchStackLib Support for X64

2022-03-17T13:23:28+00:00

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3832 Add BaseFspSwitchStackLib Support for X64. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ashraf Ali S Signed-off-by: Ted Kuo Reviewed-by: Chasel Chiu

IntelFsp2Pkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the IntelFsp2Pkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Chasel Chiu

IntelFsp2Pkg: Fix various typos

2019-07-11T13:07:17+00:00

Fix various typos in IntelFsp2Pkg. Signed-off-by: Cœur Reviewed-by: Star Zeng Reviewed-by: Chasel Chiu