Tianocore/edk2.git/IntelFsp2Pkg/FspSecCore, branch dependabot/github_actions/actions/setup-python-7

IntelFsp2Pkg/FspSecCore/Vtf0: NASM and Python 3 fixes

2026-04-09T20:12:55+00:00

Update NASM files to use NASM file extensions. Also update VTF0 Python scripts to Python 3. Signed-off-by: Michael D Kinney

IntelFsp2Pkg/FspSecCore: Do not hang when bootloader IDT is larger

2026-03-19T05:40:01+00:00

The current logic in FspSecCore is when the size of IDT created by the bootloader is larger than the size of IDT that's going to be created by FSP, CpuDeadLoop() is hit. Change PcdFspMaxInterruptSupported from 34 to 255 to avoid such case. Even when the PCD is overriden to a small value, the dead-loop is not necessary. The patch updates the logic to only copy the first part of the IDT entries when bootloader's IDT is larger. A warn is printed in the debug log when such case happens. The change addresses a boot hang in FSP API mode introduced by commit 3454d7ab41. Signed-off-by: Ray Ni

IntelFsp2Pkg/FspSecCore: Allocate correct number of IDT entries on stack

2026-03-19T05:40:01+00:00

PcdFspMaxInterruptSupported is the max interrupt number but it is used as number of interrupts when defining SEC_IDT_TABLE. Fix it by changing the SEC_IDT_TABLE.IdtTable array from IdtTable[FixedPcdGet8 (PcdFspMaxInterruptSupported)]; to IdtTable[FixedPcdGet8 (PcdFspMaxInterruptSupported) + 1]; Signed-off-by: Ray Ni

IntelFsp2Pkg: Save/restore FSBASE/GSBASE in entry and exit

2026-03-09T16:21:26+00:00

FSP may store something in FSBASE/GSBASE while bootloader may do so as well. Add the FSBASE/GSBASE save/restore logic in the FSP entry and exit to avoid the contents in FSBASE/GSBASE are corrupted by the other party. The change assumes there is no very old CPU that does not support rdfsbase/wrfsbase/rdgsbase/wrgsbase instructions. Signed-off-by: Ray Ni

IntelFsp2Pkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

IntelFsp2Pkg: Migrate GDT in SecTemporaryRamSupport

2025-11-23T02:42:34+00:00

FSP API mode is using a separate GDT, which may be in NEM or flash. Need to migrate it into permanent memory Signed-off-by: Zhiguang Liu

IntelFsp2Pkg/FspSecCore: Reserve 32B when calling C function in 64bit

2025-09-23T03:54:45+00:00

After bootloader calls FSP API mode, I found the RDI register is changed in some cases. Below is the first line of function FspApiCallingCheck in assembly dump mov qword ptr [rsp+0x8],rbx We can see compiler will use rsp+0x8 for some purpose, while rsp+0x8 is used to save RDI by FSP in code before. According to the x86-64 calling convention, caller is responsible for allocating 32 bytes of "shadow space" on the stack right before calling the function (regardless of the actual number of parameters used). However FSP code doesn't reserve 32 bytes before calling FspApiCallingCheck C function in 64bit. The patch fixes it by reserving the 32 bytes before calling C routine. Also, make sure the stack is 16-byte alignment, sub 0x28 to RSP. Signed-off-by: Zhiguang Liu

IntelFsp2Pkg: Preserve GDTR and CS/DS/ES/FS/GS/SS

2025-07-18T06:21:48+00:00

Bootloader does not expect FSP modifies GDTR and segment selectors, update FSP entry/exit code to preserve these registers. Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S

IntelFsp2Pkg : Set FSP-I upd data pointer to NULL as default

2025-02-27T16:34:33+00:00

FSP-I upd data pointer should be set NULL as default, it could avoid other code to use it before it was set with correct pointer. Signed-off-by: Hongbin1 Zhang Cc: Chasel Chiu Cc: Ray Ni Cc: Star Zeng Cc: Jiaxin Wu Cc: Duggapu Chinni B Cc: Ted Kuo Cc: Ashraf Ali S Cc: Nate DeSimone

IntelFsp2Pkg/FspSecCore: Update FSP global data in FSP-S/I entry

2025-02-25T04:19:37+00:00

Today when FspSiliconInit/FspSmmInit is called, the corresponding FSP-S/I UPD pointer is saved in FSP_GLOBAL_DATA by gen-specific code. Such code might be duplicated between different gens of FSP implementation. The change is to update FspSecCore module to set the UPD pointer in FSP_GLOBAL_DATA for all API calls: * FspMemoryInit * FspSiliconInit * FspSmmInit This can eliminate the gen-specific code. Signed-off-by: Ray Ni Cc: Chasel Chiu Cc: Nate DeSimone Cc: Duggapu Chinni B Cc: Star Zeng Cc: Ted Kuo Cc: Ashraf Ali S