Tianocore/edk2.git/FmpDevicePkg, branch dependabot/github_actions/github/codeql-action-4EDK II (mirror)https://git.radix-linux.su/Tianocore/edk2.git/atom?h=dependabot%2Fgithub_actions%2Fgithub%2Fcodeql-action-42025-11-03T07:48:00+00:00FmpDevicePkg: GetImageInfo Add missing conditions2025-11-03T07:48:00+00:00Pethaiyan Madhanmadhan.pethaiyan@intel.com2024-04-23T12:51:24+00:00urn:sha1:cb8c8c928558fa56224dee7e0c393cd663ee1aa3
REF: UEFI spec v2.10 23.1.2
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4660
1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage():
Add the following sentence at the end of the Image parameter
description. "May be NULL with a zero ImageSize in order to determine
the size of the buffer needed".
Modify the description of "EFI_INVALID_PARAMETER" return code as "The
ImageSize is not too small and Image is NULL."
2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo():
Add the following sentence at the end of the ImageInfo parameter
description."May be NULL with a zero ImageInfoSize in order to
determine the size of the buffer needed".
Modify the description of "EFI_INVALID_PARAMETER" return code as "The
ImageInfoSize is not too small and Image is NULL." and add new
descriptions for "EFI_INVALID_PARAMETER" return code.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Signed-off-by: Pethaiyan Madhan <madhan.pethaiyan@intel.com>
FmpDevicePkg: Drop ARM32 Support2025-09-25T22:04:10+00:00Oliver Smith-Dennyosde@microsoft.com2025-09-15T14:57:28+00:00urn:sha1:2c059facb3772be3ce8a05fccf26323d935719aa
edk2 is dropping support for the ARM32 architecture. This
commit removes ARM32 code from FmpDevicePkg. This also drops
irrelevant VALID_ARCHITECTURES comments from infs that are
not arch specific.
Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
FmpDevicePkg/FmpDxe: Improve handling of XDR certs2025-09-24T00:02:41+00:00Antaeus Kleinert-Strandantklein@microsoft.com2025-09-18T01:51:18+00:00urn:sha1:17691a2641c2715fc1196aa1b0fe85b85db6c240
The current implementation for XDR certificate handling assumes the
PublicKeyDataXdr buffer is 4-byte aligned. This is not always the case.
For example, if PublicKeyDataXdr=0x02, and the length is 0x05, the
correct offset should be 0x2 + align_up(0x5, 4) -> 0x2 + 0x8 = 0xA. The
current logic produces align_up(0x2 + 0x5, 4) -> align_up(0x7, 4) = 0x8.
Signed-off-by: Antaeus Kleinert-Strand <antklein@microsoft.com>
FmpDevicePkg/Library: Correct comment description2025-09-10T01:36:29+00:00Damien-Cheninkfan130924783@gmail.com2025-07-10T12:31:19+00:00urn:sha1:9b931ae81fccfb98b800f059132f2a2c4c30f85c
Correct comment description.
Signed-off-by: Damien Chen <inkfan130924783@gmail.com>
FmpDevicePkg: Clarify return status of FMP Protocol GetImage()2025-01-09T04:40:45+00:00INDIA\sachinganeshsachinganesh@ami.com2024-10-17T20:27:50+00:00urn:sha1:768adcd9c1483203a089078767fb0ef1d0048c3d
Clarifed the return status of EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage().
As intended in UEFI 2.10 Specification.
Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
Remove all ArmSoftFloatLib library class resolutions2024-11-26T22:00:36+00:00Ard Biesheuvelardb@kernel.org2024-08-29T18:31:34+00:00urn:sha1:e54794bcc63e87e2405745306708949b54754b6e
ArmSoftFloatLib is going away, so remove all residual references to it.
Continuous-integration-options: PatchCheck.ignore-multi-package
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
FmpDevicePkg/FmpDependencyLib: Fix potential overflow in loop2024-10-09T02:13:56+00:00Michael Kubackimichael.kubacki@microsoft.com2024-10-03T04:02:55+00:00urn:sha1:06da7daab1eb129a1bf3eb93ed74c102d1587071
FmpVersionsCount is a UINTN while the loop index variable compared
against it is a UINT8. This can lead to an overflow of the loop
index for FmpVersionsCount values larger than UINT8_MAX. This change
makes Index a UINTN to match in width.
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
FmpDevicePkg: Add StackCheckLibNull2024-09-13T03:58:46+00:00Oliver Smith-Dennyosde@linux.microsoft.com2024-07-23T22:35:58+00:00urn:sha1:715a695c3d0c6058efc308a585c15bcbdc8af4c7
Remove the old stack check lib now that MdeLibs.inc includes
the new one.
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
MdePkg: Move CompilerIntrinsicsLib from ArmPkg2024-09-12T19:36:59+00:00Oliver Smith-Dennyosde@linux.microsoft.com2024-08-05T17:25:07+00:00urn:sha1:8f74b95a21cf106fa4eb4932e22b404c57297ba2
As per the emailed RFC in
https://edk2.groups.io/g/devel/topic/rfc_move/107675828,
this patch moves CompilerIntrinsicsLib from ArmPkg to
MdePkg as this library provides compiler intrinsics, which
are industry standard.
This aligns with the goal of integrating ArmPkg into existing
packages: https://bugzilla.tianocore.org/show_bug.cgi?id=4121.
The newly placed CompilerIntrinsicsLib is added to MdeLibs.dsc.inc
as every DSC that builds ARM/AARCH64 needs this library added. The
old location is removed from every DSC in edk2 in this commit also
to not break bisectability with minimal hoop jumping.
Continuous-integration-options: PatchCheck.ignore-multi-package
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
FmpDevicePkg: Assert on PcdFmpDeviceImageTypeIdGuid Size Mismatch2024-07-27T23:28:50+00:00Bret Barkelewbrbarkel@microsoft.com2018-11-06T18:34:49+00:00urn:sha1:b7f963d570ec5e27bc04d546372c6fc47e4f3b17
This patch adds an assert to FmpDxe.c to catch a platform
misconfiguration of PcdFmpDeviceImageTypeIdGuid.
Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>