Tianocore/edk2.git/FatPkg, branch dependabot/github_actions/actions/github-script-8

FatPkg/EnhancedFatDxe: Remove Iso639Language

2025-10-14T01:45:12+00:00

PR #11380 that removed the Unicode Collation Protocol introduced a logic bug in the use of GetBestLanguage(). Iso639Language would always be computed to TRUE when it should always be passed to GetBestLanguage() as FALSE once Unicode Collation Protocol is removed. Update InitializeUnicodeCollationSupportWorker() to remove the local variable Iso639Language and always call GetBestLanguage() with the Iso639Language parameter set to FALSE. Signed-off-by: Michael D Kinney

FatPkg: Drop ARM32 Support

2025-09-25T22:04:10+00:00

edk2 is dropping support for the ARM32 architecture. This commit removes ARM32 code from FatPkg. Signed-off-by: Oliver Smith-Denny

FatPkg/EnhanceFatDxe:Deprecate EFI_UNICODE_COLLATION_PROTOCOL_GUID

2025-09-05T13:50:50+00:00

EFI_UNICODE_COLLATION_PROTOCOL_GUID was deprecated in favor of a newer version EFI_UNICODE_COLLATION_PROTOCOL2_GUID which provides improved language support and better extensibility. It was officially removed from UEFI specifications 2.10A and 2.11 and should no longer be used in current implementations. Cc: Sachin Ganesh Signed-off-by: Gowtham M

Revert "FatPkg: Validate Reserved FAT Entries on Volume Open"

2025-02-14T06:58:07+00:00

This reverts commit 58766a472932c485d41163b1746fb1d9e7984f07. In edk2 commit 58766a4, validation of the two reserved FAT entries was added. However, it also checked the return of FatGetFatEntry to MAX_UINT32, which is what FatGetFatEntry returns when it encounters an error, e.g. not being able to read the disk. However, MAX_UINT32 is also a valid value for the reserved FAT entries and under some conditions these will be returned in the success case. A FAT volume formatted with these valid values of the reserved FAT entries will fail to boot an OS because the opening of the volume will fail. However, the reason FatGetFatEntry returns MAX_UINT32 is that most other uses of the function are comparing it against the END_OF_CHAIN mark, which MAX_UINT32 will trip and those functions will fail out. Because this is a critical bug that can prevent OS booting and the bug the original commit was solving was accounting for a bad FAT filesystem formatting tool, this commit is reverted for now. Future work will clean up FatGetFatEntry so that it returns an EFI_STATUS, but that involves more work and this bug needs to be resolved in the meantime. Signed-off-by: Oliver Smith-Denny

FatPkg: Validate Reserved FAT Entries on Volume Open

2025-01-21T18:40:11+00:00

There are two reserved FAT entries in the FAT filesystem that are expected to have valid contents in them. Today the FAT drivers do not validate these entries when reading from a device for the first time. This can cause infinite loops in the FAT driver when trying to read corrupted disks as reported in https://github.com/tianocore/edk2/issues/9679. This PR follows the recommended update requested in that bug to check the two reserved FAT entries and validate their contents against the spec defined values in both FatPei and EnhancedFatDxe when opening a device for the first time. Signed-off-by: Oliver Smith-Denny

FatPkg: CI: Add PrEval entry

2025-01-02T23:33:46+00:00

Adds a PrEval entry to the package's ci.yaml file which is used to verify if the package uses a particular library instance when that library instance file (INF) is updated. When a library instance file (INF) is updated, PrEval will review each package's DSC as described in the ci.yaml file to determine if the package uses said library instance. If the package does use the library instance, it will be built and tested to ensure the package is not broken from the change. Signed-off-by: Aaron Pop

FatPkg/EnhancedFatDxe: Add comments around StrSize() checks

2024-11-27T15:57:08+00:00

StrSize() cannot return 0. As done in other packages, StrSize() checks the length of the string doesn't exceed PcdMaximumUnicodeStringLength. Add comments to make it more obvious. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4859 Reported-by: Tormod Volden Signed-off-by: Pierre Gondois

FatPkg/FatPei: Simplify the GPT Header Check

2024-11-13T23:26:12+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4860 - The condition of GPT header checking is mismatched between PEI FatPei module in FatPkg and DXE PartitionDxe module in MdeModulePkg. - This patch is intended to simplify the checking condition within FatPei module to align with PartitionDxe module to reduce code flow gap between both of them. - Below of condition would be checked on GPT header, 1. GPT header signature value 2. GPT header CRC value 3. GPT header LBA value 4. GPT header size of partition entry Signed-off-by: Jason1 Lin

MdePkg: MdeLibs.dsc.inc: Apply StackCheckLibNull to All Module Types

2024-11-13T21:01:46+00:00

Now that the ResetVectors are USER_DEFINED modules, they will not be linked against StackCheckLibNull, which were the only modules causing issues. So, we can now remove the kludge we had before and the requirement for every DSC to include StackCheckLibNull for SEC modules and just apply StackCheckLibNull globally. This also changes every DSC to drop the SEC definition of StackCheckLibNull. Continuous-integration-options: PatchCheck.ignore-multi-package Signed-off-by: Oliver Smith-Denny

FatPkg: Fix potentially uninitialized variable

2024-10-25T18:48:06+00:00

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1559 Initializes the variable to prevent an uninitialized variable warning in Visual Studio with C4701 enabled. Signed-off-by: Michael Kubacki