Tianocore/edk2.git/EmulatorPkg/Unix, branch dependabot/github_actions/actions/setup-python-7

EmulatorPkg: Replace manual alignment checks with helper macros

2026-06-09T07:20:10+00:00

Replace manual alignment checks with IS_ALIGNED() and ADDRESS_IS_ALIGNED(). Convert the following bitmask and modulo forms: - ((E & ((PowOf2Expr) - ONE)) == ZERO) - ((E & ((PowOf2Expr) - ONE)) != ZERO) - ((E % (PowOf2Expr)) == ZERO) - ((E % (PowOf2Expr)) != ZERO) to the corresponding helper macro forms: + IS_ALIGNED (E, PowOf2Expr) + !IS_ALIGNED (E, PowOf2Expr) PowOf2Expr is limited to known power-of-two expressions, including SIZE_* and BASE_* macros, EFI_PAGE_SIZE, CPU_STACK_ALIGNMENT, RUNTIME_PAGE_ALLOCATION_GRANULARITY, sizeof() of UEFI integer types (e.g. BOOLEAN, CHAR16, UINT32, UINTN) and pointer types, and 1 << E1 expressions. Address checks that cast the checked value to UINTN are written with ADDRESS_IS_ALIGNED(). The change was generated with the Coccinelle semantic patch below. ```smpl @power_of_2_expr@ expression PowOf2Expr; expression E1; typedef BOOLEAN, CHAR8, CHAR16, INT8, UINT8, INT16, UINT16, INT32, UINT32, INT64, UINT64, INTN, UINTN; type ScalarType = { BOOLEAN, CHAR8, CHAR16, INT8, UINT8, INT16, UINT16, INT32, UINT32, INT64, UINT64, INTN, UINTN }; type AnyType; type PointerType = AnyType *; idexpression ScalarType ScalarValue; idexpression PointerType PointerValue; constant SizeBase =~ "^(SIZE|BASE)_(1|2|4|8|16|32|64|128|256|512)[KMGTPE]B$"; constant NamedPowerOf2 =~ "^(EFI_PAGE_SIZE|CPU_STACK_ALIGNMENT|RUNTIME_PAGE_ALLOCATION_GRANULARITY)$"; constant ONE = {1, 1U, 1u}; @@ ( ( SizeBase | NamedPowerOf2 | ONE << E1 | sizeof (ScalarType) | sizeof (PointerType) | sizeof (ScalarValue) | sizeof (PointerValue) ) & PowOf2Expr ) @aligned depends on power_of_2_expr disable is_zero,isnt_zero@ expression E; expression power_of_2_expr.PowOf2Expr; constant ONE = {1, 1U, 1u}; constant ZERO = {0, 0U, 0u}; @@ ( ((E & (E - ONE)) == ZERO) | - ((E & ((PowOf2Expr) - ONE)) == ZERO) + IS_ALIGNED (E, PowOf2Expr) | ((E & (E - ONE)) != ZERO) | - ((E & ((PowOf2Expr) - ONE)) != ZERO) + !IS_ALIGNED (E, PowOf2Expr) | - ((E % (PowOf2Expr)) == ZERO) + IS_ALIGNED (E, PowOf2Expr) | - ((E % (PowOf2Expr)) != ZERO) + !IS_ALIGNED (E, PowOf2Expr) ) @address_is_aligned@ typedef UINTN; expression *Address; expression Alignment; @@ - IS_ALIGNED ((UINTN) Address, Alignment) + ADDRESS_IS_ALIGNED (Address, Alignment) @normalize_aligned disable paren expression@ expression E, SZ; @@ ( - (IS_ALIGNED (E, SZ)) + IS_ALIGNED (E, SZ) | - (!IS_ALIGNED (E, SZ)) + !IS_ALIGNED (E, SZ) ) @normalize_macro_args disable paren expression@ expression E, SZ; @@ ( - IS_ALIGNED ((E), SZ) + IS_ALIGNED (E, SZ) | - IS_ALIGNED (E, (SZ)) + IS_ALIGNED (E, SZ) ) ``` Signed-off-by: Mingjie Shen

EmulatorPkg/Host: Remove duplicate procotol in INF file

2026-04-29T09:18:10+00:00

In EmulatorPkg/Unix/Host driver, gEmuIoThunkProtocolGuid appears twice in [Procotols] section, so remove the duplicate one. Signed-off-by: Qihang Gao

EmulatorPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

EmulatorPkg: Use HOST_APPLICATION and add MINGW CLANG

2026-01-07T16:58:11+00:00

* Update EmulatorPkg to use HOST_APPLICATION module type instead of USER_DEFINED to align with UnitTestFrameworkPkg that uses HOST_APPLICATION for all Host-based unit tests. * Move [BuildOptions] from host module INFs files to EmulatorPkg DSC file. This is required to have finer control over build options for MINGW CLANG builds. * Add support for MINGW CLANG builds. * Use WIN_HOST_BUILD to simplify the selection of the Windows host module or the Linux host module. * Add missing StackCheckLib mapping * Override PcdOpensslLibAssemblySourceStyleNasm to TRUE for MINGW CLANG builds that use Windows calling convention. * Add checks for support tool chains with error messages * Set linker BASE to correct values for DLLs and Applications for 32-bit and 64-bit Windows builds. * Update DEBUG, RELEASE, and NOOPT profiles with correct optimization settings and source level debug settings. * Reduce Visual Studio support to VS2019 and VS2022 * Simplify linker settings for Visual Studio builds. Signed-off-by: Michael D Kinney

EmulatorPkg/Unix: Load symbols when modules are loaded

2026-01-07T16:58:11+00:00

Update GdbRun.sh to load symbols as modules are loaded and executed in the EmulatorPkg by executing a command each time the function SecGdbScriptBreak is executed. Set PcdEmulatorLazyLoadSymbols to FALSE to disable lazy symbol loading. With these changes, a break point can be set in any source file that is part of the EmulatorPkg build before the EmulatorPkg is executed. Signed-off-by: Michael D Kinney

EmulatorPkg/Unix/Host: Fix gPpiList multiply defined

2026-01-05T20:32:28+00:00

Multiple defined symbols are reported by clang builds for the symbol gPpiList. Change the name of the variable gPpiList in Host.c to mPpiList to guarantee unique symbols names within the Unit/Host component. Signed-off-by: Michael D Kinney

EmulatorPkg/Unix/Host: Fix symbol loading with clang

2026-01-05T20:32:28+00:00

Fix symbol loading issues with clang compilers where SecGdbSciptBreak() is optimized away and the gdb/lldb breakpoint on that symbol is never hit and no symbols are loaded for any modules. Update the implementation of SecGdbScriptBreak() so it is never inlined and add code to the implementation of SecGdbScriptBreak() to guarantee that the entire function is never optimized away by using a volatile loop variable. Signed-off-by: Michael D Kinney

EmulatorPkg: Do not require deprecated termio.h

2025-11-21T16:33:06+00:00

The termio.h of glibc has been deprecated for decades and was finally removed in glibc 2.42. EmulatorPkg still pulls it in for no reason (the "new" termios.h is being included already). Remove the include of termio.h. Signed-off-by: Oliver Steffen

EmulatorPkg/Unix/Host: Add CLANGDWARF support and reduce warnings

2025-09-22T07:12:48+00:00

Use GCC family and remove references to specific tool chain tags. This allows all GCC families to be supported including CLANGDWARF. Add -z noexecstack to reduce warnings. Signed-off-by: Michael D Kinney

EmulatorPkg/Unix/Host: Fix set but unused variables

2025-09-22T07:12:48+00:00

Signed-off-by: Michael D Kinney