Tianocore/edk2.git/EmbeddedPkg/Universal, branch master

EmbeddedPkg: MmcIoBlocks: Fix logical error in timeout

2026-09-04T01:50:12+00:00

In eMMC status detection logic in the `MmcIoBlocks' function, if a timeout occurs, the Timeout variable will end with a value -1 as the self- subtraction operation is performed after determining 0 in the while loop. This means that the function could never return a `EFI_NOT_READY' status. As Timeout is of a signed type, change the conditional statement to less-than-or-equal to 0 to fix timeout/busy detection. Signed-off-by: snowpiaoling <1972997989@qq.com>

EmbeddedPkg: MmcTransferBlock: Add Timeout Handle

2026-09-03T14:08:04+00:00

In the `MmcTransferBlock' function, the `Timeout' variable is defined but not processed, so timeout handling is added. Signed-off-by: snowpiaoling <1972997989@qq.com>

EmbeddedPkg: normalize mmc interaction latency to 1us

2026-08-30T01:48:20+00:00

Upon inspecting the source code, I found that the original implementation of eMMC timeout in MmcDxe is affected by the CPU execution speed. With higher-performance CPUs, the actual timeout duration would be shortened as it was not based on wall clock. Add a precise 1us delay to each iteration of the wait loop to make the actual duration of the delay clock- and performance-agnostic. Signed-off-by: snowpiaoling <1972997989@qq.com>

EmbeddedPkg: Replace include guards with #pragma once

2026-02-23T21:01:28+00:00

Replace traditional `#ifndef`/`#define`/`#endif` include guards with `#pragma` once. `#pragma once` is a widely supported preprocessor directive that prevents header files from being included multiple times. It is supported by all toolchains used to build edk2: GCC, Clang/LLVM, and MSVC. Compared to macro-based include guards, `#pragma once`: - Eliminates the risk of macro name collisions or copy/paste errors where two headers inadvertently use the same guard macro. - Eliminate inconsistency in the way include guard macros are named (e.g., some files use `__FILE_H__`, others use `FILE_H_`, etc.). - Reduces boilerplate (three lines replaced by one). - Avoids polluting the macro namespace with guard symbols. - Can improve build times as the preprocessor can skip re-opening the file entirely, rather than re-reading it to find the matching `#endif` ("multiple-include optimization"). - Note that some compilers may already optimize traditional include guards, by recognzining the idiomatic pattern. This change is made acknowledging that overall portability of the code will technically be reduced, as `#pragma once` is not part of the C/C++ standards. However, this is considered acceptable given: 1. edk2 already defines a subset of supported compilers in BaseTools/Conf/tools_def.template, all of which have supported `#pragma once` for over two decades. 2. There have been concerns raised to the project about inconsistent include guard naming and potential macro collisions. Approximate compiler support dates: - MSVC: Supported since Visual C++ 4.2 (1996) - GCC: Supported since 3.4 (2004) (http://gnu.ist.utl.pt/software/gcc/gcc-3.4/changes.html) - Clang (LLVM based): Since initial release in 2007 Signed-off-by: Michael Kubacki

EmbeddedPkg/Universal/MmcDxe: Fix VS2022 NOOPT IA32/X64 issues

2026-01-22T18:02:39+00:00

Signed-off-by: Michael D Kinney

EmbeddedPkg: Remove non-needed MDEPKG_NDEBUG dependent code

2024-10-23T20:30:49+00:00

Remove small amount of MDEPKG_NDEBUG dependent code which is no longer needed, given update of 'null' debug macros in ae83c6b7fd83a5906e016a32027c1bcd792a624e to explicitly mark debug-only code as discarded. Additionally, correctly mark as STATIC the two arrays within the updated code block. Signed-off-by: Mike Beaton

EmbeddedPkg: Update code to be more C11 compliant by using func

2023-04-10T14:19:57+00:00

__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among others support, while __func__ was standardized in C99. Since it's more standard, replace __FUNCTION__ with __func__ throughout EmbeddedPkg. Signed-off-by: Rebecca Cran Reviewed-by: Michael D Kinney Reviewed-by: Ard Biesheuvel Reviewed-by: Abner Chang

EmbeddedPkg: Apply uncrustify changes

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3737 Apply uncrustify changes to .c/.h files in the EmbeddedPkg package Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Michael Kubacki Reviewed-by: Andrew Fish

EmbeddedPkg: Change use of EFI_D_* to DEBUG_*

2021-12-07T17:24:28+00:00

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3739 Update all use of EFI_D_* defines in DEBUG() macros to DEBUG_* defines. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael Kubacki Signed-off-by: Michael D Kinney Reviewed-by: Ard Biesheuvel

EmbeddedPkg: Fix build error for MmcDxe

2020-07-23T12:05:44+00:00

The following command line: build -b NOOPT -a IA32 -t VS2017 -p edk2\EmbeddedPkg\EmbeddedPkg.dsc Generates the following error: MmcDxe.lib(Diagnostics.obj) : error LNK2001: unresolved external symbol __allshl MmcDxe.lib(Diagnostics.obj) : error LNK2001: unresolved external symbol __aullshr MmcDxe.lib(MmcBlockIo.obj) : error LNK2001: unresolved external symbol __allmul These erros are due to the use of shift/multiply operations on UINT64 variable on a IA32 architecture. Signed-off-by: Pierre Gondois Reviewed-by: Leif Lindholm

Tianocore/edk2.git/EmbeddedPkg/Universal, branch master

EmbeddedPkg: MmcIoBlocks: Fix logical error in timeout

EmbeddedPkg: MmcTransferBlock: Add Timeout Handle

EmbeddedPkg: normalize mmc interaction latency to 1us

EmbeddedPkg: Replace include guards with #pragma once

EmbeddedPkg/Universal/MmcDxe: Fix VS2022 NOOPT IA32/X64 issues

EmbeddedPkg: Remove non-needed MDEPKG_NDEBUG dependent code

EmbeddedPkg: Update code to be more C11 compliant by using __func__

EmbeddedPkg: Apply uncrustify changes

EmbeddedPkg: Change use of EFI_D_* to DEBUG_*

EmbeddedPkg: Fix build error for MmcDxe

EmbeddedPkg: Update code to be more C11 compliant by using func